09:05 <tokyovigilante> Just testing with the latest u-boot master, and see that https://lore.kernel.org/u-boot/20240614005309.34433-12-marek.vasut+renesas@mailbox.org/ breaks USB gadget ethernet on the RG35XX. Redefining dm_usb_gadget_handle_interrupts in drivers/usb/gadget/udc/udc-uclass.c as __weak fixes the driver. Is this worth reporting or am I misunderstanding something? #ifdef 0'ing the equivalent sunxi driver function allows a compile but

09:05 <tokyovigilante> the ethernet gadget driver is then non-functional

10:59 <Jookia> tokyovigilante: you need the patch sam edwards for gadget to work: https://lore.kernel.org/all/20230608195631.55364-1-CFSworks@gmail.com/

10:59 <Jookia> if you want you could join the mailing thread requesting for it to be merged

11:02 <Jookia> if you use DM, that is

11:02 <Jookia> more and more drivers seem to assume DM

11:04 <Jookia> unless although it looks like the patch i sent would get broken by this change

11:05 <Jookia> maybe that's the issue in the first place

11:05 <Jookia> since sunxi by default doesn't have dm_usb_gadget_handle_interrupts but the DM support patch adds it...

11:06 <Jookia> it looks like maybe someone has to port the sunxi DM musb patch to the new API :\

20:58 <tokyovigilante> thanks Jookia, did see that patch and will give it a try and feed back, although perhaps should have been merged before the breaking change?

22:01 <Jookia> i'm not sure if it will help here

22:02 <Jookia> sunxi musb doesn't implement DM support atm outside the patch i linked

22:03 <Jookia> but i think this API change means a new patch needs to be made

23:35 <Jookia> i've had some time to think and have decided not to send any more patches to u-boot/linux. not sure if i should be here given that. but consider my patches in the mailing list abandoned please