schwicht has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
Tapper has joined #openwrt-devel
JohnA has quit [Quit: Leaving]
digitalcircuit has quit [Quit: Signing off from Quassel - see ya!]
digitalcircuit has joined #openwrt-devel
ylk has joined #openwrt-devel
ylk has left #openwrt-devel [#openwrt-devel]
philipp64|work has joined #openwrt-devel
philipp64 has joined #openwrt-devel
rmilecki has joined #openwrt-devel
feriman has joined #openwrt-devel
BobbyJr has quit [Quit: Leaving]
Tapper has quit [Remote host closed the connection]
Tapper has joined #openwrt-devel
feriman has quit [Ping timeout: 484 seconds]
Borromini has joined #openwrt-devel
mcarroll76 has joined #openwrt-devel
<mcarroll76>
Hi folks.
<mcarroll76>
Just wondering... at this stage in the cycle, what are the chances of getting a small change merged and cherry-picked back to the 21.02 branch before final release?
<Namidairo>
small is relative
<mcarroll76>
It's a single line kernel config change and without it the x86/64 image fails to boot on a lot of VMWare setups, so you could regard it as a bug fix rather than a feature add.
<mcarroll76>
Already raised the pull request, just thought I'd poke my head in here to see what people thought (and maybe get it reviewed quicker).
<Borromini>
if it's in master it shouldn't be too much of an issue if it's not invasive
<mcarroll76>
That actually is a question I had - Should I raise a seperate PR for the 21.02 branch? I figured get it in master first.
<rmilecki>
mcarroll76: get it into master first
<rmilecki>
mcarroll76: if that is small, you can just try pinging us here like you just did (after getting it pushed to the master)
<mcarroll76>
That's kinda what I was hoping by coming here.
<mcarroll76>
Actually, another point, should I raise it on the bug tracker? As I knew the solution myself I went straight to raising a pull request, but would raising a bug for "fails to mount rootfs under VMWare" be a good idea, or just generating unnecessary work for you folks?
dedeckeh has joined #openwrt-devel
gladiac has quit [Read error: Connection reset by peer]
gladiac has joined #openwrt-devel
Tapper has quit [Ping timeout: 484 seconds]
Tapper has joined #openwrt-devel
Zaba2 has joined #openwrt-devel
feriman has joined #openwrt-devel
Zaba2 has quit [Quit: Leaving.]
rejoicetreat has joined #openwrt-devel
<blocktrron>
mangix: there is arc hardware around, quantenna uses it in their SoCs
<blocktrron>
mcarroll76: looks good, can you make sure SoB matches commit author?
<mcarroll76>
blocktrron: The reason they don't match is that I'm fairly new to this and screwed up by trying to do it with the github web interface first. Then when I was being asked to squash commits etc, I realised I'd have to use git properly. I think I'll have to recreate the commit from scratch, but not really a problem for two lines, so I'll do that now.
<mcarroll76>
Oh, looks like I can do it with 'git commit amend' easily enough.
<mcarroll76>
hauke: Thanks for merging my PR.I was wondering if maybe we could get this cherry-picked back to 21.02 before release, as it fixes a boot failure on some hardware.
Zaba2 has quit [Quit: Leaving.]
danitool has joined #openwrt-devel
dorf_ has quit [Remote host closed the connection]
nlowe has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]