<robimarko>
Like others, I am worried about the size increase
<robimarko>
It should probably be linked with larger storage devices only
<colo>
robimarko: what I don't understand is... how come you think some 20kb image size increase make a difference, when devices <16MB flash are not really considered viable anymore?
<robimarko>
colo: Why wouldnt 16MB devices be viable?
<colo>
- For OpenWrt 21.02, we recommend 16/128 devices - at least 16Mbytes Flash and 128MBytes RAM.
<robimarko>
My bad, I misread
<robimarko>
But same argument applies, why waste 20k?
<robimarko>
Just make it configurable in menuconfig
<colo>
all this IS already configurable in menuconfig. the point is to change the defaults, so that more capable devices do not have to be forever constrained by an (unviable) least common denominator. why not put the onus on the devices that lack required resources? their users will have to make _other_ tradeoffs with high probability, too, anyway.
bbezak has joined #openwrt-devel
<colo>
I wonder if there is any device/target that would become too small/constrained for the current default image, were these additional busbox features enabled. any ideas how one could quickly check for that? is it enough to compare gzipped image sizes with device ToH data?
<colo>
I guess the IMAGE_SIZE variable in the Makefiles is what matters in the end if a generated image is considered viable?
<colo>
some hacky awk later, I arrived at this list: https://coloss.us.to/imgsizes_per_device.txt - does this seem within the realm of the possible? :) (max. image size to be flashed per device supported)
xavifr has joined #openwrt-devel
schwicht has joined #openwrt-devel
schwicht has quit []
schwicht has joined #openwrt-devel
schwicht has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
<f00b4r0>
robimarko: you can't make this per-device choice, since it's busybox.
<f00b4r0>
remember the telnet client argument :)
<colo>
does IMAGE_SIZE refer to the max. size _before_ the resulting squashfs image is gzipped?
<robimarko>
f00b4r0: I know, its not selectable outside of menuconfig itself
<robimarko>
colo: I think that would be the resulting flashable image size
<robimarko>
Its usually for the single "firmware" partition kind of style
<colo>
robimarko: so I guess the toolchain zero-fills a resulting image to pad it to this size, in case the result is shorter than this value?
<robimarko>
colo: No, there is no need for that
<robimarko>
If there is any padding that needs to happen before the end image
<colo>
ok
<robimarko>
There are slim chances of any of the current devices that arent already disabled getting over the limit currently with those 20k
<colo>
according to the TOH, there's no device supported by 22.03.5 that has less than 8MB of flash. that sounds right to you, doesn't it?
<colo>
yeah, I am trying to work that out :)
<colo>
haven't found any candidates so far
<robimarko>
There shouldnt be any 8MB devices enabled by default currently
Danct12 has quit [Remote host closed the connection]
Danct12 has joined #openwrt-devel
sauce has joined #openwrt-devel
<colo>
robimarko: are you sure? I see plenty of 8MB devices from the TOH available in the fw selector
<colo>
(but their image sizes are pretty far below the 8MB boundary. mostly below 6MB. so I would argue +20K would not do any harm)
<f00b4r0>
feel free to add the busybox telnet client to that list :3
* f00b4r0
hides
<colo>
was that a contested addition in the past? :)
<f00b4r0>
it's an extra ~3-5kB depending on target
<f00b4r0>
and was shot down because "bloat". So good luck with your extra 20k :)
<colo>
heh. shot down by whom, and how/where?
<colo>
I'd appreciate others who share my POV on the matter to chime in on the PR btw ;)
<f00b4r0>
PR#10462
<f00b4r0>
in the end we got a separate bsd-telnet package, which is ~40kB installed
<f00b4r0>
but let's not reopen old wounds ;)
<colo>
in 2022 :X
<colo>
jeez
schwicht has joined #openwrt-devel
<colo>
is there even anything telnet-bsd can do that socat can't?
schwicht has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
<KanjiMonster>
colo: IMAGE_SIZE is usually the size of the image/firmware partition; trying to flash larger images can brick some devices (so this is more a hard limit. Usable maximum image size is a bit less than that, as you require additional space for the overlay jffs partition, which requires 5 erase blocks (so e.g. 320k with 64k erase blocks)
<colo>
KanjiMonster: thanks for the explanation :)
<KanjiMonster>
colo: and while 20k don't seem much, software size only knows one way, up, so with each release the images already grow without even adding anything new
<KanjiMonster>
so any extra software will shorten the time until the image eventually becomes too large and the device unsupported
<KanjiMonster>
that's why there needs to be a good justification for adding additional programs
<KanjiMonster>
death of a thousand cuts etc
<colo>
KanjiMonster: I am aware of that, but that is the perfect argument/pretext for total (userland) stagnation.
<KanjiMonster>
a good justification is software required to connect to the internet; because without it you'll end in a catch-22. most other things are fine as extra packages, since once you have internet, you can just install it via opkg
<colo>
the better hardware becomes, the less those 20KB are going to matter. when the next batch of devices with ~8M flash has to die away due to everything having grown even more, these 20K are SO TINY when measured against the whole
<colo>
KanjiMonster: I actually cannot install a better busybox via opkg ;)
<colo>
(unless I build it myself first. but then why would I not install a custom image?)
<KanjiMonster>
sure, but usually you can install the full version of the software instead
<colo>
true, but this PR is not dealing with any software, it is dealing with busybox. it has a wealth of great features that come at so tiny a cost, and there is no way to retrofit them after the fact that the image has been built. I'd argue it is a special case.
schwicht has joined #openwrt-devel
<colo>
(fwiw, I do build/glue together my own images using the image builder for all my devices, but nothing I can do with that will ever make ash have history search, which makes me really sad whenever I have to use the OpenWrt shell ;))
schwicht has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
schwicht has joined #openwrt-devel
minimal has quit [Quit: Leaving]
schwicht has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
robimarko has quit [Quit: Leaving]
schwicht has joined #openwrt-devel
goliath has quit [Quit: SIGSEGV]
schwicht has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
schwicht has joined #openwrt-devel
schwicht has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
schwicht has joined #openwrt-devel
schwicht has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
schwicht has joined #openwrt-devel
schwicht has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]