<Ansuel>
oh nice that single check is the only part ?
<aparcar>
I think one needs to decode the public key and read it
<Ansuel>
are we sure mbedtls_pk_parse_key doesn't already do what openssl i2d_PublicKey does in 2 step ?
<aparcar>
Nope
<Ansuel>
aparcar any idea how to test the thing?
<aparcar>
first make it compile 🙂
<Ansuel>
ouch
<Ansuel>
HAHAHA
<Ansuel>
but maybe i'm on to something
robimarko has quit [Remote host closed the connection]
<aparcar>
Ansuel: please see the DMs 🙂
robimarko has joined #openwrt-devel
<KanjiMonster>
Mangix: ah, wasn't aware we have a local backport of it
skynet2 has joined #openwrt-devel
rsalvaterra has joined #openwrt-devel
minimal has joined #openwrt-devel
<Ansuel>
robimarko did you notice nss-dp makes the kernel panic on rmmod ?
<mrnuke>
Ansuel: It's written in the ancient scriptures that rmmod shall crash. You haven;t been keeping up on your QCA mythology, have you?
goliath has quit [Quit: SIGSEGV]
<Ansuel>
well this is not true...
<Ansuel>
* The cleanup can happen from data plane override
<Ansuel>
* or from module_exit, we want to cleanup only once
<Ansuel>
*/
<Ansuel>
they have some logic to support that
<mrnuke>
QCA and logic in the same context ...?
<mrnuke>
I have noticed that too. On ipq8074, on ipq6018, and lately on ipq95xx. It crashes equally well
<Ansuel>
think i got why the thing crash... flawed logic i guess? They call the cleanup once but at the first call instead of at the last call (aka when there is no usr of the context)
<Ansuel>
also this is all loverly caused by them allocating a shared struct at the start of the driver instead of refcount and putting the priv struct in the nss_dp_data_plane_ctx
<mrnuke>
I noticed this trend in kmod-qca-... to allocate a metric tonne of global data structures
<mrnuke>
Ansuel: Do you think it's worth trying to put in the time ti fix the rmmod ?
<Ansuel>
if i'm right about this it's a quick fix
<Ansuel>
but i recently wiped my buildroot with all my staging stuff so I'm waiting for everything to rebuild
<Ansuel>
mrnuke tempted to drop the global struct and add a priv entry in the nss_dp_data_plane_ctx struct :D