kesslerd has quit [Quit: Konversation terminated!]
aomizu has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
jhan has joined #asahi-gpu
jhan has quit [Ping timeout: 480 seconds]
aomizu has joined #asahi-gpu
jhan has joined #asahi-gpu
jhan has quit [Remote host closed the connection]
jhan has joined #asahi-gpu
aomizu has quit [Max SendQ exceeded]
jhan has quit [Ping timeout: 480 seconds]
jhan has joined #asahi-gpu
<alyssa>
lina: I pushed an agx/next
<alyssa>
towards the top there is a commit "asahi: Use a dynarray for writers" which I'm on the fence about no pun intended
<alyssa>
and then the batch tracking code I rebased on top of it (easy conflicts)
<alyssa>
i'm not convinced I did it right
<alyssa>
but it does fix the use after free
jhan has quit [Ping timeout: 480 seconds]
<alyssa>
I'm starting to think there's a much dumber solution I should've gone with, actually..
<alyssa>
otoh the dynarray approach is almost certainly lighterweight than the hash table so not inclined to drop the commit
<alyssa>
(i've seen that hash table be a big chunk %wise of CPU overhead for the driver)
<alyssa>
"i'm not convinced" see the "XXX: is this kosher"
<alyssa>
because agx_writer_add asserts there's no existing writer, but if there's something submitted but not finished there's a writer there
<alyssa>
and ... in terms of batch ordering, the implicit in-order guarantee from the kernel says that's totally fine
<alyssa>
in terms of waiting for a BO to be ready, there's now a new writer to wait on so that's right
<alyssa>
the only dicey thing is that newfangled BO syncobj
<alyssa>
if there's an export, that doesn't trigger a flush so it needs to use the existing syncobj
<alyssa>
we don't touch the syncobj there so that's fine
jhan has joined #asahi-gpu
<alyssa>
but then the new syncobj will get swapped in later on submit which.. I guess is also fine
<alyssa>
but cleared if it finishes first which is.. also fine
<alyssa>
ok. I guess this is kosher after all.
<alyssa>
OK, yeah, I'm ok with it if you are
<alyssa>
lina: I've pushed my changes to lina/agx/uapi-prep
<alyssa>
(i.e. your branch, the one in the MR)
<alyssa>
fixing the UAF
<alyssa>
didn't address the other stuff from review
jhan has quit [Ping timeout: 480 seconds]
jhan has joined #asahi-gpu
jhan has quit [Ping timeout: 480 seconds]
jhan has joined #asahi-gpu
jhan has quit [Remote host closed the connection]
possiblemeatball has quit [Quit: Quit]
jhan has joined #asahi-gpu
jhan has quit [Remote host closed the connection]
jhan has joined #asahi-gpu
jhan has quit [Remote host closed the connection]
c10l has quit [Ping timeout: 480 seconds]
jhan has joined #asahi-gpu
jhan has quit [Remote host closed the connection]
jhan has joined #asahi-gpu
DarkShadow4444 has quit [Read error: Connection reset by peer]
DarkShadow44 has joined #asahi-gpu
DarkShadow44 has quit []
DarkShadow44 has joined #asahi-gpu
DarkShadow44 has quit []
DarkShadow44 has joined #asahi-gpu
<lina>
alyssa: Do you have a log from the piglit thing? I don't know if I'll get to it today/tomorrow...
DarkShadow44 has quit []
<lina>
One thing is the timestamps in your log suggest you have a slow dmesg consumer, maybe serial? So just printing fault messages takes a while, and that blocks the GPU, and then GPU context invals are getting dropped which can definitely crash the firmware.
<lina>
That doesn't explain the drm_sched splat you got though...
DarkShadow44 has joined #asahi-gpu
<lina>
I'll fix that by bumping the timeout way up for those invals
DarkShadow44 has joined #asahi-gpu
aomizu has joined #asahi-gpu
aomizu has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
aomizu has joined #asahi-gpu
<jannau>
spikerguy: for most things you don't need it. m1n1's HV provides a virtual uart
aomizu has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
kesslerd has joined #asahi-gpu
djorz has quit [Quit: Gateway shutdown]
possiblemeatball has joined #asahi-gpu
<alyssa>
lina: no serial here, native booted linux and just have dmesg open in a terminal
<lina>
Depending on your cmdline options you might be sending dmesg to serial anyway ^^
<lina>
(Or on how you actually boot linux)
<lina>
In particular if you use linux.py, I think the default stdout-path gets set to serial (u-boot normally changes that to fb...)
<lina>
I think console=tty0 will fix it, otherwise just do what I do and echo 0 > /proc/sys/kernel/printk before doing anything interesting (dmesg still works) ^^
<alyssa>
okie
bisko has joined #asahi-gpu
bisko has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
bisko has joined #asahi-gpu
bisko has quit []
nyilas has joined #asahi-gpu
amarioguy has joined #asahi-gpu
amarioguy has quit [Ping timeout: 480 seconds]
kesslerd has quit [Ping timeout: 480 seconds]
c10l has joined #asahi-gpu
djorz has joined #asahi-gpu
<alyssa>
lina: Ideally the mountain of commits that make it up would get reviewed and merged upstream, but as a release candidate I've pushed agx/release to my repo
<alyssa>
deqp should be clean, piglit is a nightmare but I think you were going to look at that because there's not too much I can do when every hit causes my system to hang
<alyssa>
s/hit/run/
<alyssa>
this includes new UAPI so should be moar perf
<alyssa>
but notably does not include GL3 or ES3
<alyssa>
since the multisampling impl is too broken for me to tolerate
<alyssa>
yeah, ok
<alyssa>
lina: agx/release is my branch
amarioguy has joined #asahi-gpu
<alyssa>
Debug more what you will (would love more piglit fixes) but when you're satisfied, push it to asahi/mesa:main and give marcan the greenlight to push out the new packages
jhan has quit [Remote host closed the connection]
<alyssa>
It's not as regression-free as I would like but, it's still edge after all, and I don't know of any real (i.e. non piglit) regressions and yeah
<alyssa>
I don't have the energy to keep working at this right now, passing the baton back to you
jhan has joined #asahi-gpu
user982492 has joined #asahi-gpu
jhan has quit [Ping timeout: 480 seconds]
jhan has joined #asahi-gpu
kesslerd has joined #asahi-gpu
jhan has quit [Ping timeout: 480 seconds]
jhan has joined #asahi-gpu
Z751 has joined #asahi-gpu
jhan has quit [Ping timeout: 480 seconds]
kesslerd_ has joined #asahi-gpu
Z751 has quit []
kesslerd has quit [Ping timeout: 480 seconds]
alyssa has quit [Quit: leaving]
jhan has joined #asahi-gpu
user982492 has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
jhan has quit [Ping timeout: 480 seconds]
luc has joined #asahi-gpu
luc has quit []
jhan has joined #asahi-gpu
user982492 has joined #asahi-gpu
jhan has quit [Ping timeout: 480 seconds]
jhan has joined #asahi-gpu
nopeslide1 has quit []
jhan has quit [Ping timeout: 480 seconds]
nopeslide1 has joined #asahi-gpu
amarioguy has quit [Ping timeout: 480 seconds]
jhan has joined #asahi-gpu
D-Spirits has joined #asahi-gpu
jhan has quit [Ping timeout: 480 seconds]
jhan has joined #asahi-gpu
jhan has quit [Ping timeout: 480 seconds]
nyilas has quit [Remote host closed the connection]