<Company>
so it's dynamically uniform, but not constant
<pq>
but if it's uniform and not constant at shader compile time, then how could the shader compiler know it can do that dead code elimination?
<pq>
maybe you need a #define'd constant for the max id instead of using id itself for the dead code thing?
<Company>
it's Vulkan, so I can't #define
<Company>
all I can do is use specialization constants
<pq>
well, any way you set compile time constants there
frieder has quit [Ping timeout: 480 seconds]
jkrzyszt has joined #dri-devel
<Company>
that's why I'm asking about specialization constants
<Company>
and their semantics
<pq>
ok
<Company>
if it turns out I need to know at spirv compile time, I'm a bit screwed, because I don't have a builtin spirv compiler
<Company>
I compile the spirv at build time
anholt has joined #dri-devel
glennk has quit [Ping timeout: 480 seconds]
<dj-death>
Company: the way it's implemented right now is that specilization constants are just replaced with constants while parsing spirv if I remember correctly
<dj-death>
Company: so it's a bit surprising that v3dv won't remove the dead branches
<Company>
maybe it does the lowering before dead code elimination
<dj-death>
Company: unfortunately that's stuff you need to debug looking at NIR optimization passes
lynxeye has joined #dri-devel
<Company>
but I'm also curious about what *should* happen
frieder has joined #dri-devel
<Company>
doesn't help if I fix v3dv and then other drivers have the same issue, too
<dj-death>
Company: possible... but really DCE should run way before stuff gets lowered
<Company>
particularly closed ones
<dj-death>
maybe it's more subtle
<dj-death>
it could be that the driver relies on the variable array size
<dj-death>
code might be get culled, but the array size is not shrinked and ...
<Company>
hehe
<Company>
first I want to figure out what *should* happen
<dj-death>
it's implementation specific at this point
<Company>
I was hoping some spec says something about it
Haaninjo has quit [Quit: Ex-Chat]
anholt has quit [Ping timeout: 480 seconds]
<Company>
because otherwise I'd just limit myself to 16 texture units because that's required by the spec
<Company>
and then I don't need to play around with specializations there
glennk has joined #dri-devel
anholt has joined #dri-devel
apinheiro has joined #dri-devel
maxzor has joined #dri-devel
jkrzyszt has quit [Remote host closed the connection]
<wv>
But while investigating, we stumbled upon something strange/interesting. It appears that the last column and last row of a surface are always black
<wv>
Whether that's on weston surfaces, or just via plain drm
<wv>
but only on imx53. We verified on imx6 too, and the issue seems not to be apparent there (at first sight)
<hakzsam>
anyone knows if more 23.2 releases will happen?
<cmichael>
eric_engestrom, ^
ficoPRO10 has joined #dri-devel
<mripard>
tursulin: I'm on it
<mripard>
you don't have commit access to drm-misc?
<mriesch>
javierm: cool, thanks for the pointer
anholt has quit [Ping timeout: 480 seconds]
jkrzyszt has quit [Ping timeout: 480 seconds]
anholt has joined #dri-devel
<tursulin>
mripard: thanks for merging it! no, I don't have commit access.
anholt has quit [Ping timeout: 480 seconds]
aravind has quit [Ping timeout: 480 seconds]
<dj-death>
jenatali: any bad experience with header files in clc?
<dj-death>
jenatali: I have this #include "libanv_shaders.h"
<dj-death>
jenatali: and somehow clc is failing with this message :
<dj-death>
error: error reading 'libanv_shaders'
<dj-death>
weirdly missing the .h suffix
flom84 has joined #dri-devel
anholt has joined #dri-devel
<Company>
dj-death: your idea of looking at nir instructions was great, thx
<Company>
not because it answered my question, but because it showed me a subtle bug in my code that lead to the code not being dead and therefor not being eliminated
<dj-death>
Company: oh nice
<Company>
so Mesa does eliminate the code just fine now
<Company>
I'd still like to know if the spec requires it though
<dj-death>
I don't think so
<alyssa>
dj-death: libanv_shaders.h eh?
<dj-death>
alyssa: yeah, giving it a try
<dj-death>
alyssa: no clue as to why the GRL shaders just work and this one fails
<alyssa>
wheeee.
<alyssa>
good luck ^^
<alyssa>
I didn't have any #include issues fwiw,
<alyssa>
but why are you including the generated clc output from the cl code itself?
<dj-death>
yeah, I have no idea...
<alyssa>
that seems.. circular..
<dj-death>
alyssa: I'm just include a shared header between the host/gpu stuff
<alyssa>
libagx_shaders.h is generated at buildtime
<alyssa>
so header name collision at the very least?
<dj-death>
I'm generating libanv_shaders_code.h
<alyssa>
ah
glennk has quit [Ping timeout: 480 seconds]
<dj-death>
like clang is crapping itself double freeing data
<dj-death>
wtf...
<alyssa>
dj-death: are you setting include paths properly from meson.build?
<dj-death>
yeah
co1umbarius has joined #dri-devel
<alyssa>
alright..
<dj-death>
fun fact, if I move the include to #include "plop.h"
<dj-death>
why am I not running into this with GRL??
<karolherbst>
kinda looks like an llvm bug
<karolherbst>
jenatali might have some ideas here ^^
<alyssa>
dj-death: dumb but consider renaming the .h :p
<karolherbst>
what version of llvm is that?
maxzor has joined #dri-devel
<karolherbst>
anyway.. we just call unique_ptr::release on memory and then it's up to LLVM to manage that
<karolherbst>
and it seems like it fails to do that
<karolherbst>
I haven't seen an error like that with llvm-16
<karolherbst>
and llvm-15 is EoL
<karolherbst>
so you might want to file a bug against your distribution
<dj-death>
oh...
Ahuj has quit [Ping timeout: 480 seconds]
<dj-death>
this is something to do with --prefix apparently
<karolherbst>
anyway.. you need to specify all include paths explicitly
<dj-death>
yeah I did
<karolherbst>
sooo
kts has joined #dri-devel
<karolherbst>
generally in CL it's advised to provide all files as buffers in RAM, so scanning for real files could cause issues as that's not well tested
<alyssa>
wfm.
<dj-death>
yeah forget it
<dj-death>
it's all about me failing to parse the -- I think
<Company>
success - finally got Vulkan running on the rpi. Though it does seem to fall over if the process wants to use both GL (with GStreamer) and Vulkan (with GTK)
<gfxstrand>
Yeah, it's really strange. The file is right there.
<karolherbst>
yeah...
<karolherbst>
seems that way
gildekel has joined #dri-devel
<gfxstrand>
IDK why NAK is okay but rusticl isn't
<karolherbst>
maybe something with updated meson?
<karolherbst>
never seen that error, so no idea
<gfxstrand>
Yeah, it's definitely something with the meson update
<gfxstrand>
Let's look at 1.2.1 does
lynxeye has quit [Quit: Leaving.]
<gfxstrand>
Ugh... unresolved import `libc_rust_gen` with mesa/main and meson 1.2.1
tzimmermann has quit [Quit: Leaving]
<karolherbst>
pain
ficoPRO10 has quit [Ping timeout: 480 seconds]
<karolherbst>
I think 1.2.1 was also broken?
<karolherbst>
I'm on 1.2.3
kts has quit [Quit: Konversation terminated!]
sarnex has quit [Read error: No route to host]
<gfxstrand>
Yeah, 1.2.3 doesn't work either
<karolherbst>
mhhh
sarnex has joined #dri-devel
<karolherbst>
odd
<karolherbst>
`unresolved import `libc_rust_gen`` that sometimes happen if the lib was built with an older rust compiler
<karolherbst>
tried a clean build?
<gfxstrand>
But I just torched my build dir
<gfxstrand>
Like rm -r _build
<karolherbst>
mhhh
<karolherbst>
pain
<karolherbst>
mind pasting the entire log?
<gfxstrand>
Oh, now it built. :rolling_eyes:
<gfxstrand>
Okay, I see what's happening.
<gfxstrand>
Meson started adding paths for link things
<gfxstrand>
So the working version does `-l static=gallium -L src/gallium/auxiliary` but the new does `-l static=src/gallium/auxiliary -L src/gallium/auxiliary`
<gfxstrand>
Guess we get to wait for more meson bugs to be fixed. :weary:
greenjustin_ has quit [Ping timeout: 480 seconds]
<ccr>
:/
glennk has quit [Ping timeout: 480 seconds]
flom84 has joined #dri-devel
glennk has joined #dri-devel
ungeskriptet has quit [Read error: Connection reset by peer]
ungeskriptet has joined #dri-devel
DodoGTA has quit [Quit: DodoGTA]
DodoGTA has joined #dri-devel
biju has quit [Quit: Konversation terminated!]
frieder has quit [Remote host closed the connection]
a-865 has quit [Quit: ChatZilla 0.17.1 [SeaMonkey 2.53.17.1/20230917131154]]
heat_ has joined #dri-devel
heat has quit [Read error: No route to host]
heat_ has quit []
heat has joined #dri-devel
flom84 has quit [Ping timeout: 480 seconds]
jernej_ has joined #dri-devel
heat_ has joined #dri-devel
wv- has joined #dri-devel
sre9 has joined #dri-devel
mort_6 has joined #dri-devel
sigmaris_ has joined #dri-devel
nashpa has joined #dri-devel
rppt_ has joined #dri-devel
JoshuaAshton has joined #dri-devel
larunbe has joined #dri-devel
noord_ has joined #dri-devel
jeeeun84135190 has joined #dri-devel
yrlf5 has joined #dri-devel
novaisc93 has joined #dri-devel
milek7_ has joined #dri-devel
hikiko_ has joined #dri-devel
kugel_ has joined #dri-devel
digetx_ has joined #dri-devel
Adrinael_ has joined #dri-devel
kxkamil2 has joined #dri-devel
pcercuei_ has joined #dri-devel
vsyrjala_ has joined #dri-devel
Stary_ has joined #dri-devel
kj_ has joined #dri-devel
cazzacar1a has joined #dri-devel
yang3__ has joined #dri-devel
bnieuwenhuizen_ has joined #dri-devel
columbarius has joined #dri-devel
co1umbarius has quit [reticulum.oftc.net helix.oftc.net]
pcercuei has quit [reticulum.oftc.net helix.oftc.net]
tursulin has quit [reticulum.oftc.net helix.oftc.net]
lemonzest has quit [reticulum.oftc.net helix.oftc.net]
yrlf has quit [reticulum.oftc.net helix.oftc.net]
mceier has quit [reticulum.oftc.net helix.oftc.net]
vdavid003[m] has quit [reticulum.oftc.net helix.oftc.net]
anfanite396[m] has quit [reticulum.oftc.net helix.oftc.net]
naheemsays[m] has quit [reticulum.oftc.net helix.oftc.net]
heat has quit [reticulum.oftc.net helix.oftc.net]
glennk has quit [reticulum.oftc.net helix.oftc.net]
nyorain[m] has quit [reticulum.oftc.net helix.oftc.net]
viciouss[m] has quit [reticulum.oftc.net helix.oftc.net]
Hazematman has quit [reticulum.oftc.net helix.oftc.net]
bubblethink[m] has quit [reticulum.oftc.net helix.oftc.net]
isinyaaa[m] has quit [reticulum.oftc.net helix.oftc.net]
knr has quit [reticulum.oftc.net helix.oftc.net]
reactormonk[m] has quit [reticulum.oftc.net helix.oftc.net]
q4a has quit [reticulum.oftc.net helix.oftc.net]
kunal_10185[m] has quit [reticulum.oftc.net helix.oftc.net]
hch12907 has quit [reticulum.oftc.net helix.oftc.net]
FloGrauper[m] has quit [reticulum.oftc.net helix.oftc.net]
jernej has quit [reticulum.oftc.net helix.oftc.net]
ajhalaney[m] has quit [reticulum.oftc.net helix.oftc.net]
znullptr[m] has quit [reticulum.oftc.net helix.oftc.net]
jeeeun8413519 has quit [reticulum.oftc.net helix.oftc.net]
ttayar[m] has quit [reticulum.oftc.net helix.oftc.net]
KunalAgarwal[m][m] has quit [reticulum.oftc.net helix.oftc.net]
halfline[m] has quit [reticulum.oftc.net helix.oftc.net]
ram15[m] has quit [reticulum.oftc.net helix.oftc.net]
dantob has quit [reticulum.oftc.net helix.oftc.net]
gdevi has quit [reticulum.oftc.net helix.oftc.net]
Targetball[m] has quit [reticulum.oftc.net helix.oftc.net]
tomeu1 has quit [reticulum.oftc.net helix.oftc.net]
enick_185 has quit [reticulum.oftc.net helix.oftc.net]
tak2hu[m] has quit [reticulum.oftc.net helix.oftc.net]
nicofee[m] has quit [reticulum.oftc.net helix.oftc.net]
zzxyb[m] has quit [reticulum.oftc.net helix.oftc.net]
dhirschfeld2[m] has quit [reticulum.oftc.net helix.oftc.net]
aura[m] has quit [reticulum.oftc.net helix.oftc.net]
daniliberman[m] has quit [reticulum.oftc.net helix.oftc.net]
exp80[m] has quit [reticulum.oftc.net helix.oftc.net]
Newbyte has quit [reticulum.oftc.net helix.oftc.net]
nick1343[m] has quit [reticulum.oftc.net helix.oftc.net]
xroumegue has quit [reticulum.oftc.net helix.oftc.net]
rppt has quit [reticulum.oftc.net helix.oftc.net]
kxkamil has quit [reticulum.oftc.net helix.oftc.net]
alarumbe has quit [reticulum.oftc.net helix.oftc.net]
ids1024[m] has quit [reticulum.oftc.net helix.oftc.net]
a1batross has quit [reticulum.oftc.net helix.oftc.net]
mauld has joined #dri-devel
lemonzest has joined #dri-devel
linkmauve has quit [reticulum.oftc.net helix.oftc.net]
dtmrzgl has quit [reticulum.oftc.net helix.oftc.net]
kj has quit [reticulum.oftc.net helix.oftc.net]
JoshuaAshton_ has quit [reticulum.oftc.net helix.oftc.net]
sre7 has quit [reticulum.oftc.net helix.oftc.net]
novaisc9 has quit [reticulum.oftc.net helix.oftc.net]
digetx has quit [reticulum.oftc.net helix.oftc.net]
mort_ has quit [reticulum.oftc.net helix.oftc.net]
swiftgeek has quit [reticulum.oftc.net helix.oftc.net]
hikiko has quit [reticulum.oftc.net helix.oftc.net]
sigmaris has quit [reticulum.oftc.net helix.oftc.net]
wv has quit [reticulum.oftc.net helix.oftc.net]
bnieuwenhuizen has quit [reticulum.oftc.net helix.oftc.net]
kugel has quit [reticulum.oftc.net helix.oftc.net]
turol has quit [reticulum.oftc.net helix.oftc.net]
dliviu has quit [reticulum.oftc.net helix.oftc.net]
shoragan has quit [reticulum.oftc.net helix.oftc.net]
yang3 has quit [reticulum.oftc.net helix.oftc.net]
zehortigoza has quit [reticulum.oftc.net helix.oftc.net]
Adrinael has quit [reticulum.oftc.net helix.oftc.net]
mauld has quit [reticulum.oftc.net helix.oftc.net]
noord has quit [reticulum.oftc.net helix.oftc.net]
Stary has quit [reticulum.oftc.net helix.oftc.net]
Ristovski has quit [reticulum.oftc.net helix.oftc.net]
milek7 has quit [reticulum.oftc.net helix.oftc.net]
APic has quit [reticulum.oftc.net helix.oftc.net]
tjaalton has quit [reticulum.oftc.net helix.oftc.net]
marex has quit [reticulum.oftc.net helix.oftc.net]
Prf_Jakob has quit [reticulum.oftc.net helix.oftc.net]
cazzacarna has quit [reticulum.oftc.net helix.oftc.net]
vsyrjala has quit [reticulum.oftc.net helix.oftc.net]
tursulin has joined #dri-devel
dtmrzgl has joined #dri-devel
Adrinael_ is now known as Adrinael
marex has joined #dri-devel
anfanite396[m] has joined #dri-devel
glennk has joined #dri-devel
tjaalton has joined #dri-devel
vdavid003[m] has joined #dri-devel
mceier has joined #dri-devel
[Ristovski] has joined #dri-devel
jernej has joined #dri-devel
yrlf has joined #dri-devel
KunalAgarwal[m][m] has joined #dri-devel
dantob has joined #dri-devel
halfline[m] has joined #dri-devel
ram15[m] has joined #dri-devel
gdevi has joined #dri-devel
tomeu1 has joined #dri-devel
Targetball[m] has joined #dri-devel
enick_185 has joined #dri-devel
nicofee[m] has joined #dri-devel
ids1024[m] has joined #dri-devel
zzxyb[m] has joined #dri-devel
dhirschfeld2[m] has joined #dri-devel
aura[m] has joined #dri-devel
daniliberman[m] has joined #dri-devel
nick1343[m] has joined #dri-devel
xroumegue has joined #dri-devel
linkmauve has joined #dri-devel
novaisc9 has joined #dri-devel
mort_ has joined #dri-devel
sre7 has joined #dri-devel
ttayar[m] has joined #dri-devel
vsyrjala has joined #dri-devel
zehortigoza has joined #dri-devel
bnieuwenhuizen has joined #dri-devel
Ristovski has joined #dri-devel
Stary has joined #dri-devel
turol has joined #dri-devel
APic has joined #dri-devel
Prf_Jakob has joined #dri-devel
swiftgeek has joined #dri-devel
naheemsays[m] has joined #dri-devel
ajhalaney[m] has joined #dri-devel
nyorain[m] has joined #dri-devel
znullptr[m] has joined #dri-devel
Hazematman has joined #dri-devel
viciouss[m] has joined #dri-devel
bubblethink[m] has joined #dri-devel
reactormonk[m] has joined #dri-devel
isinyaaa[m] has joined #dri-devel
knr has joined #dri-devel
q4a has joined #dri-devel
kunal_10185[m] has joined #dri-devel
hch12907 has joined #dri-devel
FloGrauper[m] has joined #dri-devel
jeeeun8413519 has joined #dri-devel
vsyrjala has quit [Ping timeout: 480 seconds]
FloGrauper[m] has quit [Ping timeout: 480 seconds]
dantob has quit [Ping timeout: 480 seconds]
tomeu1 has quit [Ping timeout: 480 seconds]
sumoon has quit [Write error: connection closed]
ella-0 has quit [Write error: connection closed]
pitust has quit [Write error: connection closed]
kchibisov has quit [Write error: connection closed]
rosefromthedead has quit [Write error: connection closed]
ifreund has joined #dri-devel
rosefromthedead has joined #dri-devel
kennylevinsen has joined #dri-devel
ella-0 has joined #dri-devel
sumoon has joined #dri-devel
rpigott has quit [Write error: connection closed]
kennylevinsen has quit [Write error: connection closed]
ifreund has quit [Write error: connection closed]
pitust has joined #dri-devel
rpigott has joined #dri-devel
kchibisov has joined #dri-devel
yrlf has quit [Ping timeout: 534 seconds]
anfanite396[m] has quit [Ping timeout: 544 seconds]
ajhalaney[m] has quit [Ping timeout: 539 seconds]
nyorain[m] has quit [Ping timeout: 534 seconds]
Hazematman has quit [Ping timeout: 529 seconds]
bubblethink[m] has quit [Ping timeout: 519 seconds]
knr has quit [Ping timeout: 549 seconds]
jernej has quit [Ping timeout: 514 seconds]
jeeeun8413519 has quit [Ping timeout: 539 seconds]
halfline[m] has quit [Ping timeout: 554 seconds]
gdevi has quit [Ping timeout: 519 seconds]
Targetball[m] has quit [Ping timeout: 544 seconds]
enick_185 has quit [Ping timeout: 544 seconds]
nicofee[m] has quit [Ping timeout: 534 seconds]
zzxyb[m] has quit [Ping timeout: 534 seconds]
ids1024[m] has quit [Ping timeout: 544 seconds]
sre7 has quit [Ping timeout: 534 seconds]
novaisc9 has quit [Ping timeout: 529 seconds]
mort_ has quit [Ping timeout: 519 seconds]
bnieuwenhuizen has quit [Ping timeout: 519 seconds]
Ristovski has quit [Ping timeout: 534 seconds]
Stary has quit [Ping timeout: 539 seconds]
heat_ has quit [Remote host closed the connection]
Quinten[m] has quit [Ping timeout: 480 seconds]
EricCurtin[m] has quit [Ping timeout: 480 seconds]
talcohen[m] has quit [Ping timeout: 480 seconds]
heat_ has joined #dri-devel
doras has quit [Ping timeout: 480 seconds]
vidal72[m] has quit [Ping timeout: 480 seconds]
orowith2os[m] has quit [Ping timeout: 480 seconds]
K0bin[m] has quit [Ping timeout: 480 seconds]
Armote[m] has quit [Ping timeout: 480 seconds]
yshui` has quit [Ping timeout: 480 seconds]
ohadsharabi[m] has quit [Ping timeout: 480 seconds]
Vin[m] has quit [Ping timeout: 480 seconds]
Ella[m] has quit [Ping timeout: 480 seconds]
egalli has quit [Ping timeout: 480 seconds]
samueldr has quit [Ping timeout: 480 seconds]
jenatali has quit [Ping timeout: 480 seconds]
ofirbitt[m] has quit [Ping timeout: 480 seconds]
koki23[m] has quit [Ping timeout: 480 seconds]
gallo[m] has quit [Ping timeout: 480 seconds]
heftig has quit [Ping timeout: 480 seconds]
Anson[m] has quit [Ping timeout: 480 seconds]
tintou has quit [Ping timeout: 480 seconds]
Sumera[m] has quit [Ping timeout: 480 seconds]
Mershl[m] has quit [Ping timeout: 480 seconds]
cmeissl[m] has quit [Ping timeout: 480 seconds]
jasuarez has quit [Ping timeout: 480 seconds]
moben[m] has quit [Ping timeout: 480 seconds]
tomba has quit [Ping timeout: 480 seconds]
undvasistas[m] has quit [Ping timeout: 480 seconds]
MotiH[m] has quit [Ping timeout: 480 seconds]
YHNdnzj[moz] has quit [Ping timeout: 480 seconds]
zamundaaa[m] has quit [Ping timeout: 480 seconds]
pp123[m] has quit [Ping timeout: 480 seconds]
tomeu has quit [Ping timeout: 480 seconds]
enunes[m] has quit [Ping timeout: 480 seconds]
fkassabri[m] has quit [Ping timeout: 480 seconds]
enick_991 has quit [Ping timeout: 480 seconds]
tleydxdy has quit [Ping timeout: 480 seconds]
kusma has quit [Ping timeout: 480 seconds]
YaLTeR[m] has quit [Ping timeout: 480 seconds]
znullptr[m] has quit [Ping timeout: 480 seconds]
nick1343[m] has quit [Ping timeout: 480 seconds]
dhirschfeld2[m] has quit [Ping timeout: 480 seconds]
aura[m] has quit [Ping timeout: 480 seconds]
ram15[m] has quit [Ping timeout: 480 seconds]
isinyaaa[m] has quit [Ping timeout: 480 seconds]
kunal_10185[m] has quit [Ping timeout: 480 seconds]
naheemsays[m] has quit [Ping timeout: 480 seconds]
exp80[m] has joined #dri-devel
tursulin has quit [Ping timeout: 480 seconds]
dantob has joined #dri-devel
ajhalaney[m] has joined #dri-devel
Kayden has quit [Quit: -> JF]
knr has joined #dri-devel
bubblethink[m] has joined #dri-devel
vsyrjala_ is now known as vsyrjala
heat_ has quit [Remote host closed the connection]
heat_ has joined #dri-devel
Haaninjo has joined #dri-devel
ficoPRO10 has joined #dri-devel
Kayden has joined #dri-devel
heftig has joined #dri-devel
crabbedhaloablut has quit []
anfanite396[m] has joined #dri-devel
K0bin[m] has joined #dri-devel
donaldrobson has quit [Ping timeout: 480 seconds]
Vin[m] has joined #dri-devel
<dj-death>
is there a way to tell a NIR variable represent both a sampler & texture?
<gfxstrand>
Not easily, no.
<gfxstrand>
I've tried to split that multiple times but failed to get it totally clean.
<dj-death>
gfxstrand: hmm :(
<dj-death>
gfxstrand: maybe you know a way to tell from NIR shader whether a particular binding will be used a image-only/sampler-only/image-sampler-combined?
gouchi has joined #dri-devel
<gfxstrand>
dj-death: You can chase all the derefs.
<dj-death>
gfxstrand: I thought I figured that out a while ago, but I must have forgotten
<dj-death>
ah okay
<gfxstrand>
dj-death: Even there, though, Vulkan lets you alias so you aren't just looking for NIR variables, you're looking for bindings.
<dj-death>
for buffers it's easier
a-865 has joined #dri-devel
<dj-death>
gfxstrand: so if a shader uses only a binding as a sampler, can you assume that maps exactly to a SAMPLER type decriptor?
<gfxstrand>
Nope
<dj-death>
dammit :)
<gfxstrand>
Could still be a combined image/sampler and the image part is unused
<dj-death>
alright then
<dj-death>
oh
<dj-death>
so I might be looking at a CTS bug then
<gfxstrand>
combined image/samplers were a mistake, IMO
<dj-death>
because if the descriptor is mutable and includes a COMBINED version
<dj-death>
then it has to write it as combined
tonyk4 is now known as tonyk
<dj-death>
or there is an issue with descriptor buffers
sima has quit [Ping timeout: 480 seconds]
<dj-death>
if you create a layout with combined, write it as sampler
<dj-death>
how is the implementation supposed to know where to find the data?
<dj-death>
because the layout has space for image+sampler
yshui` has joined #dri-devel
gouchi has quit [Quit: Quitte]
<dj-death>
but the vkGetDescriptorEXT() doesn't have the information about the layout
<dj-death>
so it doesn't know that there is an additional offset for where to put the sampler
heat__ has joined #dri-devel
<gfxstrand>
is combined allowed with descriptor buffer?
tobiasjakobi has joined #dri-devel
heat_ has quit [Read error: No route to host]
<dj-death>
gfxstrand: I have a comment in Anv that says no :)
<dj-death>
gfxstrand: but I can't find the reference in the spec
<dj-death>
and validation layers don't scream
<gfxstrand>
Ah, the eternal Vulkan spec issue...
<dj-death>
I think it's allowed
<dj-death>
proposals/VK_EXT_descriptor_buffer.adoc:Buffers containing `VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER` descriptors must have been created with both
<dj-death>
I guess I'm off to write a spec bug
fkassabri[m] has joined #dri-devel
<gfxstrand>
Yeah, they're definitely allowed
<gfxstrand>
There's this weird array property that affects them.
<dj-death>
I don't know that Anv can do combined-image-sampler with mutable and descriptor buffers
<dj-death>
I mean the information to put/fetch the data in the right place just isn't there
tleydxdy has joined #dri-devel
egalli has joined #dri-devel
Anson[m] has joined #dri-devel
MotiH[m] has joined #dri-devel
ohadsharabi[m] has joined #dri-devel
talcohen[m] has joined #dri-devel
Ristovski has joined #dri-devel
Aura has quit [Ping timeout: 480 seconds]
heat_ has joined #dri-devel
marex_ has joined #dri-devel
ficoPRO10 has quit [reticulum.oftc.net helix.oftc.net]
Haaninjo has quit [reticulum.oftc.net helix.oftc.net]
knr has quit [reticulum.oftc.net helix.oftc.net]
dantob has quit [reticulum.oftc.net helix.oftc.net]
exp80[m] has quit [reticulum.oftc.net helix.oftc.net]
ttayar[m] has quit [reticulum.oftc.net helix.oftc.net]
daniliberman[m] has quit [reticulum.oftc.net helix.oftc.net]
heat__ has quit [reticulum.oftc.net helix.oftc.net]
anfanite396[m] has quit [reticulum.oftc.net helix.oftc.net]
reactormonk[m] has quit [reticulum.oftc.net helix.oftc.net]
linkmauve has quit [reticulum.oftc.net helix.oftc.net]
hch12907 has quit [reticulum.oftc.net helix.oftc.net]
Prf_Jakob has quit [reticulum.oftc.net helix.oftc.net]
vdavid003[m] has quit [reticulum.oftc.net helix.oftc.net]
q4a has quit [reticulum.oftc.net helix.oftc.net]
APic has quit [reticulum.oftc.net helix.oftc.net]
viciouss[m] has quit [reticulum.oftc.net helix.oftc.net]
mceier has quit [reticulum.oftc.net helix.oftc.net]
swiftgeek has quit [reticulum.oftc.net helix.oftc.net]
glennk has quit [reticulum.oftc.net helix.oftc.net]
marex has quit [reticulum.oftc.net helix.oftc.net]
turol has quit [reticulum.oftc.net helix.oftc.net]
xroumegue has quit [reticulum.oftc.net helix.oftc.net]
[Ristovski] has quit [reticulum.oftc.net helix.oftc.net]
zehortigoza has quit [reticulum.oftc.net helix.oftc.net]
tjaalton has quit [reticulum.oftc.net helix.oftc.net]
KunalAgarwal[m][m] has quit [reticulum.oftc.net helix.oftc.net]
ficoPRO10 has joined #dri-devel
mceier has joined #dri-devel
dantob has joined #dri-devel
knr has joined #dri-devel
Haaninjo has joined #dri-devel
heat__ has joined #dri-devel
anfanite396[m] has joined #dri-devel
turol has joined #dri-devel
APic has joined #dri-devel
xroumegue has joined #dri-devel
reactormonk[m] has joined #dri-devel
viciouss[m] has joined #dri-devel
glennk has joined #dri-devel
[Ristovski] has joined #dri-devel
vdavid003[m] has joined #dri-devel
exp80[m] has joined #dri-devel
q4a has joined #dri-devel
ttayar[m] has joined #dri-devel
daniliberman[m] has joined #dri-devel
swiftgeek has joined #dri-devel
Prf_Jakob has joined #dri-devel
zehortigoza has joined #dri-devel
viciouss[m] has quit [Ping timeout: 480 seconds]
ttayar[m] has quit [Ping timeout: 480 seconds]
anfanite396[m] has quit [Ping timeout: 480 seconds]
exp80[m] has quit [Ping timeout: 480 seconds]
[Ristovski] has quit [Ping timeout: 480 seconds]
heat__ has quit [Ping timeout: 480 seconds]
APic has quit [Ping timeout: 480 seconds]
Haaninjo has quit [Ping timeout: 480 seconds]
APic has joined #dri-devel
reactormonk[m] has quit [Ping timeout: 480 seconds]
Haaninjo has joined #dri-devel
linkmauve has joined #dri-devel
tjaalton has joined #dri-devel
mvlad has quit [Remote host closed the connection]