<tzimmermann>
and for usb, we require special handling of buffer imports because it requires a dma-capable device and usb devices don't have dma
<tzimmermann>
we use the usb-controller device instead
<tzimmermann>
and that got me thinking that we have plenty of drivers on serial busses. i wonder if these devices are capable of dma
<tzimmermann>
like i2c and spi in the solomon driver
Kayden has quit [Quit: Leaving]
<javierm>
tzimmermann: in most cases they are not, just like USB devices you need to copy from system memory to a device internal memory using I2C or SPI commands
chaos_princess has joined #dri-devel
Kayden has joined #dri-devel
<javierm>
I didn't know about this limitation of drm_gem_prime_* helpers
Surkow|laptop has quit [Ping timeout: 480 seconds]
<tzimmermann>
not sure, but that would imply that they have no dma-capability set either. they'd need that workaround as well
<javierm>
tzimmermann: yeah, I'm looking at drivers/gpu/drm/tiny/gm12u320.c that has a custom gm12u320_gem_prime_import() helper that queries the DMA device of the USB controller
<javierm>
but that seems to be a workaround indeed
<tzimmermann>
also in udl and gud
<javierm>
ah, I just did `git grep .gem_prime_import -- drivers/gpu/drm/tiny/` :) to see if a simple driver used it
<tzimmermann>
i just thought that the problem might not be exclusive to usb
<javierm>
tzimmermann: for sure is not exclusive to usb
kts has quit [Ping timeout: 480 seconds]
<javierm>
any simple panel would have the same issue
<tzimmermann>
no one complained so far
<javierm>
I2C, SPI, parallel port, MIPI DBI, I think all will have the same problem
<tzimmermann>
still not pretty ...
<sima>
javierm, yeah we probably need special helpers that do cpu-only imports
chewitt has joined #dri-devel
<sima>
ah just caught up with the todo.rst link
<javierm>
tzimmermann: what's the actual error, if I'm reading the code correctly, the prime import will fail with -EINVAL?
<javierm>
sima, tzimmermann: but I was wondering if this isn't the correct behavior. I mean, after all zero copy is not supported for cpu-only imports
<javierm>
although I understand that might be desirable to provide a consistent uAPI for all KMS devices for user-space to not care
<sima>
javierm, well it's not more copies than what you'd get with a dumb buffer created on the device directly
<javierm>
sima: that's true
<sima>
if we'd fail import, then you'd get a copy done by userspace and one again in the kernel
<javierm>
sima: yeah, and also is annoying for user-space that might expect let's say a GStreamer pipline that does dma-buf import/export between a camera sensor and a display driver, to always work
<javierm>
(assuming that can negotiate the correct pixel format and whatnot)
<tzimmermann>
javierm, i think the device doesn't have a dma mask
<tzimmermann>
but i cannot find the actual test that fails
<javierm>
tzimmermann: I see
<javierm>
tzimmermann: thanks for mentioning this issue, I never thought about it
rasterman has joined #dri-devel
Surkow|laptop has quit [Read error: Connection timed out]
<sima>
mripard, hm I thought I've acked that already? at least gives me old memories vibes, and I think it summarizes the discussion we had a while back
<sima>
we = bunch of folks on dri-devel, not me iirc
<sima>
or do you mean the question where to put it?
<sima>
or maybe move the entire uapi stuff out into the uapi top-level doc dir
<javierm>
so makes sense to have their the expections documented
<javierm>
*there
<sima>
hm I'd move the entire thing to the top-level contributing maybe?
<sima>
drm-internals.rst is kinda about core drm concepts like drm_device and a few other things like that
<javierm>
sima: hmm, that sound correct indeed. But in any case would be a separate patch
<sima>
we don't do kunit just for that, but for all of drm
<sima>
yeah
<sima>
yeah kunit testing in there feels rather wrong to me ...
kts has joined #dri-devel
<javierm>
sima: agreed
<sima>
it's also annoying that the new stylesheet doesn't have a deep doc, so it's really hard to navigate
<sima>
I still keep the old one for those reasons
<sima>
since so much structure is lost otherwise
Surkow|laptop has joined #dri-devel
<sima>
and people just dump stuff into the top-level for lack of better place
<mripard>
sima: I didn't have any ack but jani's so I didn't merge it, and I'd still like to merge it :)
<mripard>
but yeah, I can shuffle the doc around
<mripard>
it's not clear to me what you want me to do from thta discussion though
<sima>
mripard, I think get some more acks from people working on kunit stuff
<sima>
tursulin just did a few drm/sched tests
<sima>
and then land it
<sima>
javierm, also wondering whether we should move all the uapi stuff into Documentation/userspace-api/gpu/ or so
<javierm>
sima, mripard: I just r-b the patch too in case it helps
<javierm>
sima: I don't have strong opinions on that. On one hand, having all the docs in the same dir could be convenient but separating uAPI and internal could be desirable too
jkrzyszt has joined #dri-devel
<mmind00>
robertfoss: for the dw-hdmi-qp audio patch you gave a Reviewed-by ... can I just apply that patch to drmmisc or should I wait for a listed bridge maintainer to pick that up (seems I don't venture out of drm/rockchip enough)
tango_ has quit [Ping timeout: 480 seconds]
siak has joined #dri-devel
kode54 has joined #dri-devel
Surkow|laptop has quit [Read error: Connection timed out]
Surkow|laptop has joined #dri-devel
kode54 has quit [Remote host closed the connection]
<sima>
javierm, we can still link criss-cross to help find stuff
edolnx has joined #dri-devel
edolnx_ has quit [Ping timeout: 480 seconds]
Surkow|laptop has quit [Ping timeout: 480 seconds]
<javierm>
sima: I meant more for developers doing grep than users but yeah
<sima>
hm
<sima>
javierm, that already fails since large chunks of our docs are in source files within DOC: blocks
<javierm>
sima: right, that's true too
<mlankhorst>
mripard: looks like there's a potential mismatch between expectations of maintainership of dmem. :)
<sima>
mlankhorst, hm why?
kode54 has joined #dri-devel
<sima>
but yeah if tejun doesn't want it, I guess we should have a MAINTAINERS entry for cc: dri-devel and pointing at drm-misc git?
<sima>
tejun should still get them that way too
moony has joined #dri-devel
probablymoony has quit [Read error: No route to host]
Kayden has quit [Quit: Leaving]
Kayden has joined #dri-devel
mehdi-djait3397165695212282475 has quit [Ping timeout: 480 seconds]
pjakobsson has quit [Remote host closed the connection]
<mlankhorst>
Yeah
sinatosk has quit [Quit: Leaving]
Kayden has quit [Quit: Leaving]
Kayden has joined #dri-devel
sally has quit [Quit: sally]
<sima>
mlankhorst, you'll send a MAINTAINERS patch then?
<mripard>
mlankhorst: yeah, I'm a bit confused
<mripard>
we're going to use it for more than drm, and it's a cgroup, so I'm not sure why we should maintain it in the first place
<mripard>
I know at least I don't know anyting about cgroups :)
<mripard>
sima: back to the bridge state discussion, you said you were fine with patches up until patch 30, does that mean I can add your r-b / a-b for those?
Surkow|laptop has joined #dri-devel
<sima>
mripard, I didn't really read most of them closely since they had an r-b already, but it looked all reasonable
<sima>
if you need an r-b or ack on specific ones, I think I'd need to look a bit more closely
sally has joined #dri-devel
<javierm>
mripard: I guess if fair for tejun to ask you (Friedrich, mlankhorst and you) to be Cc'ed in patches and listed as maintainer in MAINTAINERS but the list and tree should be cgroup indeed
<javierm>
just like is the case for any other cgroup driver in kernel/cgroup
<javierm>
tzimmermann: because IIUC the agreegment is that KMS devices that don't support zero-copy, will "emulate" and support prime import. Similar like all KMS devices can emulate supporting XRGB8888
<mripard>
sima: I have the r-b I need already, so it's all good :)
pcercuei has joined #dri-devel
<stsquad>
I'm still struggling to figure out what needs enabling in mesa to support the VK_KHR_display extension. AFAICT the bits of wsi_common_display.c that are marked for the extension are linked into the build - but I don't know what the entry point should look like.
<mlankhorst>
pixelcluster: want to be dmem maintainer too?
jsa1 has quit [Ping timeout: 480 seconds]
<mripard>
mlankhorst: yep
rgallaispou1 has quit [Read error: Connection reset by peer]
rgallaispou has joined #dri-devel
<javierm>
tzimmermann: yeah, the first step sounds desirable regardless
<tzimmermann>
javierm, the second step involves per-driver review. that might take abit longer to get right
DodoGTA has quit [Quit: DodoGTA]
DodoGTA has joined #dri-devel
pcercuei_ has joined #dri-devel
pcercuei has quit [Ping timeout: 480 seconds]
pcercuei has joined #dri-devel
pcercuei_ has quit [Ping timeout: 480 seconds]
pcercuei_ has joined #dri-devel
pcercuei has quit [Ping timeout: 480 seconds]
<mlankhorst>
sima: so through cgroup git tree or drm-misc?
<sima>
mlankhorst, I'd propose drm-misc and ask tejun to ack that?
itoral has quit [Quit: Leaving]
<sima>
seems where most of the interactions are currently
<sima>
mlankhorst, and I guess list you+whoever else as maintainers, plus dri-devel as list?
<mlankhorst>
Yeah ok, lets see. :)
tomba has quit [Ping timeout: 480 seconds]
tomba has joined #dri-devel
<pixelcluster>
mlankhorst: I'd be honored :)
<pixelcluster>
jfyi I'm kinda in the middle of transitioning and switching everything over to new name - hadn't yet used it for the initial dmem patchset but if we could switch to "Natalie Vock <natalie.vock@gmx.de>" going forward that'd be cool
<sima>
pixelcluster, could also sneak in the .mailmap entry in the same patch if you want
<sima>
maybe even extra sneaky just as part of applying it
DodoGTA has quit [Remote host closed the connection]
<sima>
entirely up to you, there's no requirement to have .mailmap entries in public upstream at all
<pixelcluster>
sima: <3
<pixelcluster>
had thought about that already but was scared to ask because "I've only written a handful of patches so far..."
<sima>
sometimes airlied or me also pushed one directly to drm.git somewhere in the middle of the merge-window pile where no one looks
<sima>
pixelcluster, a name change is a name change
<sima>
(mr incredible meme here)
<pixelcluster>
lmao
guludo has joined #dri-devel
DodoGTA has joined #dri-devel
DodoGTA has left #dri-devel [#dri-devel]
Surkow|laptop has quit [Quit: 418 I'm a teapot - NOP NOP NOP]
kode54 has joined #dri-devel
epoch101 has joined #dri-devel
rasterman has quit [Quit: Gettin' stinky!]
rasterman has joined #dri-devel
<mlankhorst>
pixelcluster: will add you under that name, if you want can add the mailmap in the patch
<mlankhorst>
or have sima do it
tango_ has joined #dri-devel
<DemiMarie>
pixelcluster: Congratulations!
kts has joined #dri-devel
<pixelcluster>
mlankhorst: adding it in the patch sounds good to me, thanks!
kts has quit [Ping timeout: 480 seconds]
pcercuei has joined #dri-devel
DodoGTA has joined #dri-devel
pcercuei_ has quit [Ping timeout: 480 seconds]
fab has quit [Ping timeout: 480 seconds]
jsa1 has joined #dri-devel
haaninjo has joined #dri-devel
mehdi-djait3397165695212282475 has joined #dri-devel
kzd has joined #dri-devel
mehdi-djait3397165695212282475 has quit []
bolson has joined #dri-devel
mvlad has joined #dri-devel
epoch101 has quit []
epoch101 has joined #dri-devel
jsa1 has quit [Ping timeout: 480 seconds]
phasta has quit [Ping timeout: 480 seconds]
rgallaispou has left #dri-devel [#dri-devel]
anholt has quit [Ping timeout: 480 seconds]
<daniels>
eric_engestrom: thanks for the release!
<zmike>
eric_engestrom: 💪
<HdkR>
🎉
psykose has quit [Remote host closed the connection]
Duke`` has joined #dri-devel
psykose has joined #dri-devel
nchery has joined #dri-devel
<eric_engestrom>
:)
<eric_engestrom>
and thanks to gfxstrand for correcting me!
<eric_engestrom>
I should've asked here for confirmation
lynxeye has joined #dri-devel
mbosse has joined #dri-devel
<daniels>
meh, give it another week
mbrost has joined #dri-devel
davispuh has joined #dri-devel
anholt has joined #dri-devel
<eric_engestrom>
daniels: ?
Duke`` has quit [Ping timeout: 480 seconds]
fab has joined #dri-devel
<daniels>
panvk will obviously be at 1.4 rsn :P
fab is now known as Guest9531
<eric_engestrom>
haha
<eric_engestrom>
too late for 25.0 though :P
<eric_engestrom>
scrolling back a bit; congrats pixelcluster!
Duke`` has joined #dri-devel
vedm_ is now known as vedm
jsa1 has joined #dri-devel
rsalvaterra has quit []
rsalvaterra has joined #dri-devel
mbosse has quit [Remote host closed the connection]
heat is now known as Guest9534
Guest9534 has quit [Read error: Connection reset by peer]
heat has joined #dri-devel
frieder has quit [Remote host closed the connection]
heat has quit [Remote host closed the connection]
heat has joined #dri-devel
anholt has quit [Ping timeout: 480 seconds]
u-amarsh04 has quit []
u-amarsh04 has joined #dri-devel
<any1>
I think I recall two different people saying in here that they made some tools for generating EDIDs, but I don't remember who. Care to refresh my memory?