<steev>
brgl: oh i'm not in a rush for it, was just wondering. the pwrseq looks interesting and i look forward to testing it on x13s :)
ektor5 has quit [Quit: WeeChat 4.3.2]
ektor5 has joined #linux-msm
<arnd>
bamse: in e2ebc65958ef ("Merge branch '20240602114439.1611-1-quic_jkona@quicinc.com' into arm64-for-6.11"), did you intentionally pull in both the binding and the driver, or was that a mistake?
<arnd>
I've pulled it in already, but last time this happened, torvalds noticed it and asked me about it, so I want to be sure I explain it correctly in my own pull request
<arnd>
Usually we only pull in the binding if that needs to be shared with another branch, and this one looks like it would have been trivial to do that way, but I may be missing something
<marc|gonzalez>
bamse: jhugo: Errrrr, about include/dt-bindings/clock/qcom,gcc-msm8998.h ... WTF is this file? There are a bunch of identifiers in no particular order associated with a sequentially increasing value. Then a second short "block" of identifiers (GDSCs apparently), then a 3rd block (BCRs only?) ... First block is only clocks?
<aka_[m]>
marc|gonzalez: indexes for gcc-msm8998.c clock list
<marc|gonzalez>
what is an index? why do we need to manage a list manually?
<marc|gonzalez>
Right, I had found that code. But why are we managing the indices manually? Because they must be shared by different code? (driver & DTS)
<aka_[m]>
I guess so
<aka_[m]>
It's easier to reference
<aka_[m]>
Not developer so cannot tell
<marc|gonzalez>
Then why not an enum? Why do we have to manually select a number???
<marc|gonzalez>
A sequentially increasing number, which is exactly what an enum is for
<marc|gonzalez>
... Because an enum can't be used in DTS, only a CPP definition
<marc|gonzalez>
ugh
<aka_[m]>
Icc drivers do enum for qnodes but still we have #defines in bindings
<bamse>
arnd: that was a mistake :(
<bamse>
marc|gonzalez: that header file defines the ABI between the dtb and the OS implementation...in some such cases constants are representing something in the underlying hardware, in this case it's just there to give human readable names to the indexes in a table that needs to match on both sides
<bamse>
marc|gonzalez: it's not a enum, because it's not an enumeration of values where order might matter, but the values must stay constant - to keep compatibility between the different entities (dtb, different OS, bootloaders...)
<aka_[m]>
😑
<bamse>
z3ntu: typically someone like Andrew picks those, but as it hasn't been picked up i did so now
srinik has quit [Ping timeout: 480 seconds]
Caterpillar has quit [Quit: Konversation terminated!]
<aka_[m]>
krzk: can you check these when you get some time?
<aka_[m]>
I don't want to send to once again be told that I'm not describing stuff as I should