00:24 <owrt-images-builds> Build [#339](https://buildbot.openwrt.org/images/#/builders/149/builds/339) of `master_mediatek/filogic` failed.

06:52 <owrt-images-builds> Build [#346](https://buildbot.openwrt.org/images/#/builders/61/builds/346) of `master_ramips/mt7621` completed successfully.

11:20 <owrt-images-builds> Build [#354](https://buildbot.openwrt.org/images/#/builders/231/builds/354) of `master_mpc85xx/p1010` completed successfully.

17:26 <stintel> https://gist.github.com/stintel/f6b62dfed46113be3256f70d6f8ea13f

17:26 <stintel> In file included from /home/stijn/Development/OpenWrt/openwrt/build_dir/target-aarch64_cortex-a53_musl/linux-mediatek_mt7622/mt76-2024.08.25~904ef52a/util.c:7:

17:26 <stintel> /home/stijn/Development/OpenWrt/openwrt/build_dir/target-aarch64_cortex-a53_musl/linux-mediatek_mt7622/mt76-2024.08.25~904ef52a/mt76.h: In function 'mt76_put_page_pool_buf':

17:26 <stintel> /home/stijn/Development/OpenWrt/openwrt/build_dir/target-aarch64_cortex-a53_musl/linux-mediatek_mt7622/mt76-2024.08.25~904ef52a/mt76.h:1544:9: error: implicit declaration of function 'page_pool_put_full_page' [-Werror=implicit-function-declaration]

17:27 <stintel> this is after a make dirclean om mediatek/mt7622

17:28 <stintel> nbd: any ideas?

17:52 <stintel> looks like it might have been CONFIG_SRC_TREE_OVERRIDE=y and a git-src symlink in mt76 dir

17:54 <stintel> yep

17:55 <stintel> that's not typically something we'd use in CI, so maybe we should add warning that waits for interactive confirmation or something

17:55 <stintel> there's a big potential of breakage, if someone has this enabled

17:56 <stintel> so warn the user, pauze, let them continue by pressing enter or what not, but in case something fails, instruct them to find -type l -name git-src first

21:23 <karlp> that's a lot of handholding for someone who just forgot that they were a developer and were doign things deliberately :)

21:54 <Fijxu> it is safe to uncheck Firmware modules if my router is not going to use them at all?

21:55 <slh> there is no generic answer to this question, it depends on the device and the module/ firmware blob in question

21:56 <Fijxu> well

21:56 <Fijxu> my device is only going to use mediatek firmware

21:56 <Fijxu> I do not need realtek nor intel ones

21:57 <Fijxu> so those can be discarded safely right?

21:57 <slh> and neither of those will be preinstalled (if we aren't talking about x86_64)

21:57 <slh> in general the firmware images have only the minimum amount of packages preinstalled

21:57 <slh> without anything optional

21:58 <Fijxu> it is possible to get the config.buildinfo of my device instead of the target one?

21:59 <Fijxu> because I'm using https://downloads.openwrt.org/releases/23.05.4/targets/ramips/mt7621/config.buildinfo

21:59 <slh> no, yes'ish

21:59 <slh> config.buildinfo is the config used to build the downloadable images

22:00 <slh> and even that makes sure that (almost) nothing optional will end up in the resulting per-device images

22:00 <slh> of course menuconfig/ xconfig will give you fine grained config access

22:01 <slh> and -for personal/ private builds-, config.buildinfo is rather useless as a starting point - yes, it works just fine, but it will build a lot more than you need for your device (build, not install, mind the difference)

22:02 <Fijxu> nevermind, the modules that I was talking about cannot be deselected