ChanServ changed the topic of #wayland to: https://wayland.freedesktop.org | Discussion about the Wayland protocol and its implementations, plus libinput | register your nick to speak
caveman has quit [Quit: caveman]
Lucretia-backup has joined #wayland
cabal704 has quit [Ping timeout: 480 seconds]
Lucretia has quit [Ping timeout: 480 seconds]
fmuellner has quit [Ping timeout: 480 seconds]
c7s has joined #wayland
Arnavion has quit [Ping timeout: 480 seconds]
Arnavion has joined #wayland
masoudd has quit [Remote host closed the connection]
<pq>
8 month after creation of that MR, to the day of month
<pq>
755 comments in review discussions
rgallaispou has joined #wayland
<zzag>
has that been the hardest part or are there more merge requests to follow?
<pq>
That was just the opening one.
<kennylevinsen>
so close to 1000 comments, better luck next time :D
<zzag>
oh my..
<pq>
But it was difficult because it was the first MR to start actually using LCMS in Weston, and create the fallback implementation of all color transformations: 3D LUT.
<pq>
Also a huge part of the review was training in coding and commit style.
<pq>
originally the scope of that one MR was much bigger than how it landed, too, the rest will come next in easier chunks I hope
<pq>
Also note, that this has *nothing* with the Wayland protocol extension.
<pq>
But, if you now configure an ICC profile for an output, you should see the colors become... different. I'm not sure if they are right, probably not, but it's a starting point.
devilhorns has joined #wayland
<pq>
Of course, without protocol you are limited to sRGB to output transformations.
<dottedmag>
pq: Good illustration why I insist on "coding & commit style must documented, and it is prohibited to block reviews on grounds of undocumented commit/style violations" everywhere I work.
<dottedmag>
Which sometimes results in several MR updating style documents, but mostly cuts the amount of trivial back-and-forth to minimum.
<pq>
well, there is style and then there is "how to write the code so that it is easy to understand", this was more about the latter.
<dottedmag>
True, that's usually the meat of reviews.
<pq>
anyway, the discussions are all there to see for yourself - I'm sure I've forgot most of it
fmuellner has joined #wayland
cabal704 has joined #wayland
<pq>
to be fair, it was only 2 months ago that we decided to recude the MR scope a lot. You can also subtract a month from that due to Christmas.
<pq>
*reduce
<pq>
Summer vacations are also included in the 8 months.
<pq>
dottedmag, oh right, creating a recipe-style patch series was one hurdle.
cvmn has joined #wayland
Company has joined #wayland
<swick>
congrats!
<pq>
:-)
rakeen has joined #wayland
rakeen has quit [Remote host closed the connection]
shankaru has quit [Quit: Leaving.]
cvmn has quit [Ping timeout: 480 seconds]
bittin has quit [Remote host closed the connection]
rgallaispou has quit [Read error: Connection reset by peer]
cvmn has joined #wayland
cvmn has quit [Remote host closed the connection]
jmdaemon has quit [Ping timeout: 480 seconds]
cabal704 has quit [Quit: WeeChat 3.4]
shankaru has joined #wayland
danvet has joined #wayland
rgallaispou has joined #wayland
l4s8g_ has quit [Remote host closed the connection]
l4s8g has joined #wayland
l4s8g has quit []
l4s8g has joined #wayland
l4s8g has quit [Remote host closed the connection]
l4s8g has joined #wayland
bittin has joined #wayland
cphealy has joined #wayland
zebrag has joined #wayland
<wlb>
weston Merge request !661 closed (Draft: WIP LCMS color transform and inverse eotf)
colordrops has joined #wayland
cabal704 has joined #wayland
spstarr has quit [Remote host closed the connection]
eroux has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
___nick___ has quit [Ping timeout: 480 seconds]
ppascher has quit [Ping timeout: 480 seconds]
nigelvr has joined #wayland
ppascher has joined #wayland
rasterman has quit [Quit: Gettin' stinky!]
immibis has joined #wayland
fmuellner has joined #wayland
<Company>
in theory, when rendering in Wayland with GL, I could avoid the backbuffer, render to some drm buffer directly and wl_surface_attach() that buffer, right?
<emersion>
and get tearing
<Company>
why?
<emersion>
the compositor might still use the front buffer when you re-render
<Company>
if I only use this method I mean
<Company>
and never use the front/backbuffer
<Company>
that discussion just came up in #gtk and I wondered if there are some obvious drawbacks or benefits
<Company>
I mean, the obvious benefit is that I can control when I commit() because I don't use SwapBuffers() anymore
<emersion>
the compositor might still use the buffer you've submitted when you re-render
<Company>
of course, I'd need to do buffer management
<emersion>
SwapBuffers() immediately commits
<Company>
just like GTK already does with Cairo
<emersion>
ah, so if you add a swapchain to this, yeah, sure, but you suddently need to write a lot more code
<emersion>
that's what wlroots does fwiw
<emersion>
why do you want to do this?
<Company>
I was just wondering
<Company>
because someone was trying that approach on MacOS
<Company>
and I wondered about doing it on Wayland
<emersion>
SwapBuffers() plus SwapInterval(0) should be enough
<Company>
ultimately, it would simplify the swapchain handling across Cairo, GL and Vulkan
<emersion>
well, not really :P
<Company>
and allow more control over when GTK commit()s
<emersion>
because you need to create dmabufs, import them, integrate with your swapchain etc
<Company>
because commit() commits the whole surface state and the GL renderer is kinda separate from the other machinnery and...
<Company>
right, it's more work
<Company>
but there's no magic that Mesa does
<emersion>
with dmabufs comes modifiers, dmabuf feedback, etc
<emersion>
also you need something like GBM
<emersion>
there's no magic, but mesa does the right stuff, and it's easy not to
Piraty has joined #wayland
shankaru1 has quit []
<Company>
yeah, it's duplicating a bunch of code
<Company>
either between GTK and Mesa or inside GTK to integrate the different swapchain impls
<Company>
it's a pretty obvious choice in 2022 which one is the better choice
jmdaemon has quit [Quit: WeeChat 3.4]
jmdaemon has joined #wayland
danvet has quit [Ping timeout: 480 seconds]
dcz_ has quit [Ping timeout: 480 seconds]
Seirdy has quit []
peeterm_ has joined #wayland
peeterm has quit [Ping timeout: 480 seconds]
masoudd has quit [Ping timeout: 480 seconds]
hardening has quit [Ping timeout: 480 seconds]
maxzor has quit [Remote host closed the connection]