ChanServ changed the topic of #dri-devel to: <ajax> nothing involved with X should ever be unable to find a bar
LeviYun has quit [Ping timeout: 480 seconds]
LeviYun has joined #dri-devel
LeviYun has quit [Ping timeout: 480 seconds]
<KarenTheDorf>
Hazematman: I went back to before that merge request and same behaviour on resize.
<KarenTheDorf>
Also on latest main branch, so I'll file it as an issue
Rayyan is now known as rayyan2
glennk has quit [Ping timeout: 480 seconds]
rayyan2 has quit []
bolson has quit [Remote host closed the connection]
bolson has joined #dri-devel
LeviYun has joined #dri-devel
pcercuei has quit [Quit: dodo]
LeviYun has quit [Ping timeout: 480 seconds]
yyds has joined #dri-devel
iive has quit [Quit: They came for me...]
flynnjiang has joined #dri-devel
flynnjiang has quit [Remote host closed the connection]
nerdopolis has joined #dri-devel
LeviYun has joined #dri-devel
LeviYun has quit [Ping timeout: 480 seconds]
alane has quit []
alane has joined #dri-devel
epoch101 has quit []
LeviYun has joined #dri-devel
frieder has quit [Ping timeout: 480 seconds]
LeviYun has quit [Ping timeout: 480 seconds]
frieder has joined #dri-devel
nerdopolis has quit [Ping timeout: 480 seconds]
nerdopolis has joined #dri-devel
tdsmala^ has quit [Remote host closed the connection]
Namarrgon has quit [Ping timeout: 480 seconds]
Namarrgon has joined #dri-devel
LeviYun has joined #dri-devel
oneforall2 has quit [Remote host closed the connection]
oneforall2 has joined #dri-devel
nerdopolis has quit [Ping timeout: 480 seconds]
frieder has quit [Ping timeout: 480 seconds]
frieder has joined #dri-devel
LeviYun has quit [Ping timeout: 480 seconds]
kts has joined #dri-devel
yrlf has quit [Ping timeout: 480 seconds]
yrlf has joined #dri-devel
riteo has quit [Ping timeout: 480 seconds]
aravind has joined #dri-devel
riteo has joined #dri-devel
Company has joined #dri-devel
riteo has quit [Remote host closed the connection]
kts has quit [Ping timeout: 480 seconds]
fab has joined #dri-devel
LeviYun has joined #dri-devel
riteo has joined #dri-devel
LeviYun has quit [Ping timeout: 480 seconds]
krushia has quit [Read error: Connection reset by peer]
riteo has quit [Ping timeout: 480 seconds]
krushia has joined #dri-devel
sima has joined #dri-devel
riteo has joined #dri-devel
LeviYun has joined #dri-devel
glennk has joined #dri-devel
bmodem has joined #dri-devel
fab has quit [Quit: fab]
LeviYun has quit [Ping timeout: 480 seconds]
LeviYun has joined #dri-devel
rasterman has joined #dri-devel
tzimmermann has joined #dri-devel
LeviYun has quit [Ping timeout: 480 seconds]
fab has joined #dri-devel
yyds has quit []
yyds has joined #dri-devel
jsa has joined #dri-devel
warpme has joined #dri-devel
sghuge has quit [Remote host closed the connection]
warpme has quit []
sghuge has joined #dri-devel
LeviYun has joined #dri-devel
<sima>
tnt, I guess we need to allocate the tile64 modifier to sort this out?
sgruszka has joined #dri-devel
Duke`` has joined #dri-devel
<mripard>
lumag: the fwnode reference count discussion is kind of separate to me, so you can merge the whole thing
<tnt>
sima: yes, that'd be the first step :)
<lumag>
mripard, ack. My plan is to get 1-3 into drm-misc-next, then ask robclark to merge it into msm-next and then push patches on top of it to msm-next. This way I can send patches for other HDMI bridges without waiting for a backmerge.
<tnt>
ATM it seems that Tile64 is rarely used but if https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29244 is merged, then it becomes the default for Arc so anything exporting dmabuf will end up with that format and the modifier should reflect that.
<lumag>
mripard, for fwnode I understand your concerns, but I don't see a good resultion. Maybe i915 people can look at reworking their code.
<mripard>
lumag: sounds like a plan
<mripard>
and yeah, I think we'll need to, I was hoping for Hans to reply
<lumag>
mripard, n/p, it was a pleasure. It helped me to clean up the driver.
<lumag>
So, kudos goes to you for the framework code.
mohan43u has joined #dri-devel
mvlad has joined #dri-devel
simon-perretta-img has quit [Read error: Connection reset by peer]
simon-perretta-img has joined #dri-devel
<sima>
mripard, devm_ for a struct drm_bridge sounds extremely wrong to me, but I guess I'm not going to dig into this
<sima>
probably should be drmm for static bridges, and then when we start hotplugging I'll just run away screaming :-P
<mripard>
sima: I would agree, but what are you referring to ? :)
<sima>
oh just the bugfix you've merged recently for panel bridge
<mripard>
which commit id?
warpme has joined #dri-devel
<mripard>
panels are a shitshow here anyway, since they get registered without access to the drm_device so you can't use anything but devm_* allocations (or kmalloc in probe, kfree in remove, which is pretty much the same)
<sima>
uh that sounds like we should refcount them ...
<sima>
mripard, yeah essentially I guess both drm_bridge and drm_panel really should have been full blown struct dev things
<sima>
but then we'd probably never have gotten anywhere
warpme has quit []
warpme has joined #dri-devel
aravind has quit [Ping timeout: 480 seconds]
aravind has joined #dri-devel
kzd has quit [Ping timeout: 480 seconds]
purplebored has joined #dri-devel
purplebored has left #dri-devel [#dri-devel]
warpme has quit []
<mripard>
sima: by full blown struct dev thing you mean being part of their own bus?
<sima>
hm maybe not
<mripard>
because I think with refcounting we can have a pretty neat solution without too much trouble
<sima>
but it does start to smell like reinventing parts of the driver model a bit ...
<sima>
yeah kref is defo the incremental thing
<mripard>
in drm_panel_init, init the reference count, put it back at remove, and of_drm_find_panel takes one
warpme has joined #dri-devel
frieder has quit [Ping timeout: 480 seconds]
Rayyan has joined #dri-devel
frieder has joined #dri-devel
warpme has quit []
warpme has joined #dri-devel
warpme has quit []
warpme has joined #dri-devel
<Hazematman>
<KarenTheDorf> "Also on latest main branch, so I..." <- Thanks! If it didn't happen after you reverted my change I'm not quite sure of the cause. I'll check out the issue later though with all the details and I can do some debugging to see if I have any other ideas about what could be wrong
simon-perretta-img has quit [Ping timeout: 480 seconds]
simon-perretta-img has joined #dri-devel
<sima>
mripard, just realized that large chunks of the bridge/panel lifetime issues should be sorted with device_link_add
<sima>
which we still don't have
kts_ has joined #dri-devel
kts_ has quit []
warpme has quit []
kts has quit [Ping timeout: 480 seconds]
melonai has joined #dri-devel
<mripard>
sima: I was wondering if we don't miss a module_get somewhere
<mripard>
like, if you remove the panel module, then what?
<sima>
mripard, module_get only ensures the binary is around
<sima>
device_link_add ensures the actual driver sticks around
<sima>
so much better, because it also covers any other reason for that driver unbinding
<sima>
not just module unload
<mripard>
does it?
<mripard>
I thought it was just about ordering?
<sima>
go into the driver's sysfs, unbind it manually
<sima>
need to set the right flags iirc
<sima>
so that any unbind of that driver forces all dependent drivers to get unloaded first
<mripard>
I think it's just wiser to step away from that discussion and play dead :D
<mripard>
looks like a whole tank of worms
<sima>
understatement
oneforall2 has quit [Remote host closed the connection]
<sima>
but the problem doesn't become easier if we hand roll a shitty ill-specified version of these in bridge/panel framework
<sima>
so for now the status quo is that some drivers put this in their driver code, making a subsytem wide conversion even trickier
<sima>
plus there's still drivers using at least bridges with component.c, which handles this but differently
<sima>
or well, part of the device_link problem space
Haaninjo has joined #dri-devel
LeviYun has quit [Ping timeout: 480 seconds]
oneforall2 has joined #dri-devel
<lumag>
sima, we have been hitting the bridge disappearance for a few cycles. It's pretty easy to hit it if there is a significant amount of time between probe() and attach().
<sima>
lumag, oh on loading? that's more surprising ...
kts has joined #dri-devel
bolson has quit [Remote host closed the connection]
bolson has joined #dri-devel
simon-perretta-img has quit [Ping timeout: 480 seconds]
kts has quit [Read error: Connection reset by peer]
nchery has quit [Ping timeout: 480 seconds]
nchery has joined #dri-devel
Duke`` has quit [Ping timeout: 480 seconds]
LeviYun has joined #dri-devel
pjakobsson has quit [Ping timeout: 480 seconds]
simon-perretta-img has joined #dri-devel
Duke`` has joined #dri-devel
<lumag>
sima: yes, on load / probe. Especially if the bridge is registered, other driver gets a reference, then a bridge disappears thanks to -EPROBE_DEFER
<sima>
ugh
<sima>
lumag, so that's for bridge drivers which register the bridge, but then have further stuff which might cause an abort of the probe?
<sima>
device_link should help, but only against a remove, not an aborted probe of the bridge driver
<lumag>
sima, that's how we hit that. But the general feeling is that the whole bridge-to-bridge interface might be improved
<sima>
yeah if you register a bridge and then abort, there's a race
<sima>
and device_link can't plug that
simon-perretta-img has quit [Ping timeout: 480 seconds]
simon-perretta-img has joined #dri-devel
feaneron has joined #dri-devel
tzimmermann has quit [Quit: Leaving]
LeviYun has quit [Ping timeout: 480 seconds]
MrCooper has quit [Remote host closed the connection]
kts has joined #dri-devel
Kayden has quit [Quit: -> JF]
bolson has quit [Ping timeout: 480 seconds]
conchuod has joined #dri-devel
<conchuod>
If Tomeu Vizoso is in here, your email address from the rockchip npu series is bouncing.
<conchuod>
"tomeu.vizoso@tomeuvizoso.net: The email account that you tried to reach does not exist"
mbrost has joined #dri-devel
MrCooper has joined #dri-devel
riteo has quit [Remote host closed the connection]
LeviYun has joined #dri-devel
riteo has joined #dri-devel
<tomeu>
yeah, I managed to misstype my own email...
LeviYun has quit [Ping timeout: 480 seconds]
Kayden has joined #dri-devel
LeviYun has joined #dri-devel
simon-perretta-img has quit [Ping timeout: 480 seconds]
simon-perretta-img has joined #dri-devel
chaos_princess has quit [Quit: chaos_princess]
chaos_princess has joined #dri-devel
ellyq has quit []
rasterman has joined #dri-devel
ellyq has joined #dri-devel
mbrost has quit [Ping timeout: 480 seconds]
lynxeye has quit [Quit: Leaving.]
frieder has quit [Remote host closed the connection]
LeviYun has quit [Ping timeout: 480 seconds]
jsa has quit [Ping timeout: 480 seconds]
mbrost has joined #dri-devel
LeviYun has joined #dri-devel
LeviYun has quit [Ping timeout: 480 seconds]
warpme has joined #dri-devel
warpme has quit []
LeviYun has joined #dri-devel
LeviYun has quit [Ping timeout: 480 seconds]
mbrost has quit [Ping timeout: 480 seconds]
fab has quit [Quit: fab]
rasterman has quit [Quit: Gettin' stinky!]
apinheiro has joined #dri-devel
LeviYun has joined #dri-devel
gouchi has joined #dri-devel
gouchi has quit [Remote host closed the connection]
kts has quit [Quit: Konversation terminated!]
KarenTheDorf has joined #dri-devel
coldfeet has joined #dri-devel
guludo has quit [Quit: WeeChat 4.2.2]
guludo has joined #dri-devel
LeviYun has quit [Ping timeout: 480 seconds]
warpme has joined #dri-devel
warpme has quit []
iive has joined #dri-devel
mbrost has joined #dri-devel
LeviYun has joined #dri-devel
LeviYun has quit [Ping timeout: 480 seconds]
sima has quit [Ping timeout: 480 seconds]
LeviYun has joined #dri-devel
Kayden has quit [Quit: -> home]
Duke`` has quit [Ping timeout: 480 seconds]
Haaninjo has quit [Quit: Ex-Chat]
mbrost_ has joined #dri-devel
guludo has quit [Ping timeout: 480 seconds]
LeviYun has quit [Ping timeout: 480 seconds]
guludo has joined #dri-devel
mbrost has quit [Ping timeout: 480 seconds]
mbrost__ has joined #dri-devel
LeviYun has joined #dri-devel
mbrost_ has quit [Ping timeout: 480 seconds]
LeviYun has quit [Ping timeout: 480 seconds]
mbrost__ has quit [Ping timeout: 480 seconds]
coldfeet has quit [Quit: Lost terminal]
LeviYun has joined #dri-devel
davispuh has quit [Ping timeout: 480 seconds]
tobiasjakobi has joined #dri-devel
LeviYun has quit [Ping timeout: 480 seconds]
<karolherbst>
did anybody here ever looked into implementing PIPE_CAP_QUERY_TIMESTAMP for v3d?
mvlad has quit [Remote host closed the connection]
tobiasjakobi has quit []
kode542 has quit []
kode54 has joined #dri-devel
nerdopolis has joined #dri-devel
mbrost has joined #dri-devel
LeviYun has joined #dri-devel
Kayden has joined #dri-devel
guludo has quit [Quit: WeeChat 4.2.2]
LeviYun has quit [Ping timeout: 480 seconds]
mripard has quit [Remote host closed the connection]
mripard has joined #dri-devel
nerdopolis has quit [Ping timeout: 480 seconds]
apinheiro has quit [Quit: Leaving]
alanc has quit [Remote host closed the connection]
alanc has joined #dri-devel
Company has quit [Quit: Leaving]
LeviYun has joined #dri-devel
simon-perretta-img has quit [Ping timeout: 480 seconds]
simon-perretta-img has joined #dri-devel
mbrost has quit [Remote host closed the connection]
Leopold_ has joined #dri-devel
LeviYun has quit [Ping timeout: 480 seconds]
frankbinns has quit [Remote host closed the connection]
frankbinns has joined #dri-devel
LeviYun has joined #dri-devel
LeviYun has quit [Ping timeout: 480 seconds]
sukuna1 has quit [Remote host closed the connection]