<tokyovigilante>
Jookia: nice! what was the issue?
<Jookia>
i think switching polarities between u-boot and kernel broke things. i didn't mean to. i have to do more investigation and confirm values are set correctly, but probably not today
montjoie has joined #linux-sunxi
montjoie_ has quit [Ping timeout: 480 seconds]
apritzel has quit [Ping timeout: 480 seconds]
vagrantc has quit [Quit: leaving]
<tokyovigilante>
no drama
<tokyovigilante>
I'm off on holiday tomorrow, so will hopefully collect some more feedback on the DE33 patchset while i'm away ready for a v2 in a fortnight, and then the TCON changes will be more straightforward. I really do need to learn YAML it seems :(
<tokyovigilante>
loki666: thanks for the cpufreq testing
hexdump01 has joined #linux-sunxi
hexdump0815 has quit [Ping timeout: 480 seconds]
JohnDoe_71Rus has joined #linux-sunxi
junari has joined #linux-sunxi
apritzel has joined #linux-sunxi
Schimsalabim has quit [Ping timeout: 480 seconds]
Schimsalabim has joined #linux-sunxi
warpme has joined #linux-sunxi
ungeskriptet is now known as Guest9038
ungeskriptet has joined #linux-sunxi
aggi_ has joined #linux-sunxi
Guest9038 has quit [Ping timeout: 480 seconds]
aggi has quit [Ping timeout: 480 seconds]
Schimsalabim has quit [Read error: Connection reset by peer]
Schimsalabim has joined #linux-sunxi
freemangordon has quit []
freemangordon has joined #linux-sunxi
Schimsalabim has quit [Read error: Connection reset by peer]
apritzel has quit [Ping timeout: 480 seconds]
electricworry has joined #linux-sunxi
<loki666>
tokyovigilante, your welcome
<loki666>
You think I can start testing your de33 patches? And if so what can be tested
Schimsalabim has joined #linux-sunxi
warpme has quit []
Schimsalabim has quit [Ping timeout: 480 seconds]
Schimsalabim has joined #linux-sunxi
apritzel has joined #linux-sunxi
Schimsalabim has quit [Read error: Connection reset by peer]
Schimsalabim has joined #linux-sunxi
apritzel has quit [Ping timeout: 480 seconds]
Schimsalabim has quit [Ping timeout: 480 seconds]
Schimsalabim has joined #linux-sunxi
wingrime1 has joined #linux-sunxi
wingrime-ww has quit [Ping timeout: 480 seconds]
Schimsalabim has quit [Read error: Connection reset by peer]
Schimsalabim has joined #linux-sunxi
Schimsalabim has quit [Ping timeout: 480 seconds]
Jookia has quit [Read error: Connection reset by peer]
Jookia has joined #linux-sunxi
Schimsalabim has joined #linux-sunxi
JohnDoe3 has joined #linux-sunxi
JohnDoe_71Rus has quit [Ping timeout: 480 seconds]
dsimic is now known as Guest9056
dsimic has joined #linux-sunxi
Guest9056 has quit [Ping timeout: 480 seconds]
Schimsalabim has quit [Read error: Connection reset by peer]
Schimsalabim has joined #linux-sunxi
electricworry has quit [Remote host closed the connection]
Schimsalabim has quit [Ping timeout: 480 seconds]
Schimsalabim has joined #linux-sunxi
Schimsalabim has quit [Read error: Connection reset by peer]
Schimsalabim has joined #linux-sunxi
thecheofusi has joined #linux-sunxi
<thecheofusi>
Happy Sunday everyone
<thecheofusi>
started work on a V4L2 mem2mem driver for Allwinner's G2D engine
<thecheofusi>
Any comments or suggestions are very welcome
<loki666>
tokyovigilante: FYI, your cpufreq patch works fine on top of 6.10rc2, but using the same kconfig with your anbernic-image-hacks branch is giving me NMI errors when init kicks in
<loki666>
if I disable the opp dts, no more NMI errors, but cpu is stuck @400Mhz
apritzel has joined #linux-sunxi
<apritzel>
thecheofusi: nice one. The files say Copyright Allwinner 2016, so is this based on some BSP source code?
<apritzel>
thecheofusi: the coding style is a bit off. That seems like an unimportant detail, but slows down review, so maybe you can fix that?
<apritzel>
thecheofusi: so how would this be used? Is they existing software using this Rectfill mem2mem interface?
<loki666>
arf, v4l2 is for video capture... not going to be easy to test on a rg35xx-h, I guess I'll need a usb cam or something
<thecheofusi>
loki666: It's a mem2mem device, you don't need a usb cam.. just some pixels in memory
<apritzel>
loki666: this is using the v4l2 framework, but has nothing to do with video capture
<thecheofusi>
apritzel: I'll add a small C tool with an easy to use interface for testing.
<thecheofusi>
So anyone interesting doesn't have to deal directly with the V4L2 userspace interface
<thecheofusi>
apritzel: what do you mean by the coding style being off ?
<apritzel>
it's not proper kernel coding style, my eyes stumbled immediately - and so will the maintainer's and upstream reviewer's
<thecheofusi>
Ok I'll look into that
<apritzel>
empty line after variable declarations, continuation lines not starting aligned, no inline keyword in .c files, else/if cascades alignment, no #ifdef in .c files, ...
<apritzel>
also I guess as upstreaming is the goal, this should be moved into a proper kernel tree, not as a standalone module
<apritzel>
I understand you probably wanted to do this anyway at some point, but a proper upstream reviewer would state those things and then stop looking at the patch, so it's worth to get this right from the beginning
<apritzel>
I was wondering if any retro game emulators could directly use this interface, to speed up 2D operations, for sprites, for instance?
<apritzel>
that isn't really useful for any core that has a 3D GPU, but maybe the T113-s3 for instance would benefit, since it's quite wimpy to begin with?
<apritzel>
but I guess gaming systems with 2D operations are not a problem performance-wise anyway?
<thecheofusi>
apritzel: For now this would remain an out of tree module, until enough operations and
<thecheofusi>
a decent amount of people are using it
warpme has quit []
Schimsalabim has quit [Read error: Connection reset by peer]
<apritzel>
why, exactly? isn't upstreaming the goal?
<thecheofusi>
Upstreaming is the goal..and will happen when the driver has matured and enough people are using it
<thecheofusi>
For now it needs other people looking at it to determine if the G2D IP has been correctly modeled
<thecheofusi>
I need to get the architecture part right first before thinking of upstream
<apritzel>
by experience it's much easier to accommodate upstreaming from the beginning, not as a second step
<apritzel>
just merge it into a Linux tree and keep it rebased on say -rc2's: that should be relatively easy to pull off
ftg has joined #linux-sunxi
<apritzel>
and it would be good to get upstream advice early: that avoids disappointment if the structure is not quite right
<apritzel>
nothing worse than getting upstream comments that require quite some rewrite, after say half a year of work
<apritzel>
and I don't know who do you expect to judge the G2D IP modelling? and what does that mean anyway? I mean if it works, then the IP is apparently correctly programmed?
<apritzel>
But I would be more concerned about getting the Linux subsystem integration right, and for that you need a proper upstream review
<apritzel>
if I were you, I would implement a second command, then send an RFC upstream, to get early feedback on this
<apritzel>
you want people with a lot of experience like mripard to have a look
apritzel has quit [Ping timeout: 480 seconds]
montjoie has quit [Remote host closed the connection]
Schimsalabim has joined #linux-sunxi
warpme has joined #linux-sunxi
warpme has quit []
Schimsalabim has quit [Read error: Connection reset by peer]
Schimsalabim has joined #linux-sunxi
wingrime1 has quit []
wingrime-ww has joined #linux-sunxi
montjoie has joined #linux-sunxi
warpme has joined #linux-sunxi
apritzel has joined #linux-sunxi
apritzel has quit [Ping timeout: 480 seconds]
chewitt has quit [Quit: Zzz..]
warpme has quit []
junari has quit [Ping timeout: 480 seconds]
warpme has joined #linux-sunxi
warpme has quit []
thecheofusi has quit [Read error: Connection reset by peer]
JohnDoe3 has quit []
Schimsalabim has quit [Ping timeout: 480 seconds]
Schimsalabim has joined #linux-sunxi
wingrime-ww has quit [Ping timeout: 480 seconds]
Schimsalabim has quit [Read error: Connection reset by peer]
Schimsalabim has joined #linux-sunxi
apritzel has joined #linux-sunxi
Schimsalabim has quit [Read error: Connection reset by peer]