<tomba>
I'm a bit confused about the modes in different places. In drm_display_mode we have the normal timings and crtc_* timings. And then we have mode and adjusted_mode. My bridge needs to adjust the input timings, so I think the bridge should do it in atomic_check, and change adjusted_mode->clock. The crtc also needs to change the clock, depending on what clock can actually be achieved. I think crtc's mode_fixup() is the right place (or
<tomba>
atomic_check?), but it's not clear to me if it should change adjusted_mode->clock or adjusted_mode->crtc_clock. And in atomic check/enable, should the crtc use clock or crtc_clock to set the clock rate.
mripard has joined #dri-devel
<tomba>
In the bridge's atomic_enable, I believe crtc->state->adjusted_mode->crtc_clock should be used (and hope that it's what was requested in bridge's atomic_check)
<tomba>
Overall I just feel that I'm not sure what specific timing to look at in all these different places, and what to modify if needed. Is there any good example anywhere?
lemonzest has quit [Quit: WeeChat 4.5.2]
<tomba>
Also, who's responsible for updating the crtc_* values. I assume the crtc driver needs to do that... in... atomic_check?
lemonzest has joined #dri-devel
soze has quit [Remote host closed the connection]
jkrzyszt has joined #dri-devel
frankbinns has quit [Read error: Connection reset by peer]
sguddati has joined #dri-devel
pcercuei has joined #dri-devel
<eric_engestrom>
tjaalton: I'm checking with the gitlab admins to see when it's safe to make the release :)
soze has joined #dri-devel
<mripard>
tomba: to answer your last question, drm_mode_set_crtcinfo() sets the crtc_* values
lynxeye has joined #dri-devel
<mripard>
for the rest, adjusted_mode is indeed the one to modify in atomic_check, but it's pretty clunky when multiple components have to modify it
<mripard>
what are you trying to do?
<tomba>
mripard: well, for one, I just want to make sure this bridge and crtc driver use the right values. but ultimately the issue here is that the (dsi) bridge has requirements for the incoming pclk, but on the other hand the crtc can't provide just any clock, so it should use clk_round_rate to update the rate (somewhere) to the real one.
jsa1 has quit [Ping timeout: 480 seconds]
<tjaalton>
eric_engestrom: ack, thanks
zzyiwei has quit [Ping timeout: 480 seconds]
<eric_engestrom>
tjaalton: heard back, it should be fine, so I'll make the release in a few hours (about to be busy for a couple hours) :)
<tjaalton>
excellent :)
jsa1 has joined #dri-devel
Dragoon has joined #dri-devel
Dragoon is now known as Guest11786
DragoonAethis has quit [Ping timeout: 480 seconds]
<mripard>
tomba: I think that's one of the things where bridges in general fall short. We don't have an easy way to align clock rates along devices in DRM, and the extra abstraction provided by bridges make it harder to implement an ad-hoc function
<mripard>
do you have a specific thread / issue where this is discussed?
<tomba>
mripard: no, just a local WIP branch. the DSI PLL has a rather coarse grained resolution, and at the moment the driver doesn't support fine tuning the timings based on the pclk-byteclk difference (although even if it did, it could still fail). But, in this particular case, the crtc can provide very exact clock rates, so I think this gets more or less solved for now by just making the bridge ask for a crtc clock that matches the DSI
<tomba>
clock.
<tomba>
And I have that working, but I just felt a bit uncomfortable as I wasn't sure if I'm modifying and looking at the right values, from all those different options where we have the mode.
Guest11786 has quit []
<mripard>
I've been wondering for a while how we can solve that, we have a similar problem for panels pixel clocks for example.
<mripard>
but yeah, the framework isn't going to help you there, you're on your own :)
<tomba>
mripard: thanks, just the answer I wanted! ;)
DragoonAethis has joined #dri-devel
krei-se- has quit []
Kayden has quit [Quit: reboot]
krei-se has joined #dri-devel
Kayden has joined #dri-devel
DragoonAethis has quit [Remote host closed the connection]
DragoonAethis has joined #dri-devel
andersson123 has joined #dri-devel
hexa- has quit [Ping timeout: 480 seconds]
DragoonAethis has quit [Ping timeout: 480 seconds]
LeviYun has quit [Ping timeout: 480 seconds]
DragoonAethis has joined #dri-devel
hexa- has joined #dri-devel
DragoonAethis has quit [Remote host closed the connection]
DragoonAethis has joined #dri-devel
coldfeet has joined #dri-devel
kts has joined #dri-devel
LeviYun has joined #dri-devel
Tooniis[m] has left #dri-devel [#dri-devel]
amarsh04 has quit []
Company has joined #dri-devel
warpme has quit []
u-amarsh04 has joined #dri-devel
warpme has joined #dri-devel
u-amarsh04 has quit []
kts has quit [Ping timeout: 480 seconds]
mehdi-djait3397165695212282475 has quit []
coldfeet has quit [Quit: Lost terminal]
sguddati has quit [Ping timeout: 480 seconds]
kts has joined #dri-devel
che_ has quit [Remote host closed the connection]
u-amarsh04 has joined #dri-devel
guludo has joined #dri-devel
nerdopolis has joined #dri-devel
feaneron has joined #dri-devel
Daanct12 has quit [Ping timeout: 480 seconds]
mehdi-djait3397165695212282475 has joined #dri-devel
Daanct12 has joined #dri-devel
andersson123 has quit []
epoch101 has joined #dri-devel
<tzimmermann>
sima, airlied, can you please merge last week's PR of drm-misc-next-fixes
u-amarsh04 has quit []
jsa1 has quit [Ping timeout: 480 seconds]
warpme has quit []
jsa1 has joined #dri-devel
<tjaalton>
eric_engestrom: might be a bit too late, but if 9447de5d could be picked for 25.0 that would help a bit with #12823, the rest hasn't landed in master yet
chewitt has joined #dri-devel
<eric_engestrom>
tjaalton: I was about to start, perfect timing ^^
* eric_engestrom
looks
<tjaalton>
nice
<eric_engestrom>
oh yeah that's a very trivial commit, I'm including it :)
andersson123 has joined #dri-devel
warpme has joined #dri-devel
mszyprow has joined #dri-devel
amarsh04 has joined #dri-devel
crowen has joined #dri-devel
kts has quit [Ping timeout: 480 seconds]
amarsh04 has quit []
zzyiwei has joined #dri-devel
amarsh04 has joined #dri-devel
rasterman has joined #dri-devel
epoch101 has quit [Ping timeout: 480 seconds]
Jeremy_Rand_Talos__ has joined #dri-devel
Jeremy_Rand_Talos_ has quit [Remote host closed the connection]
<tjaalton>
great, one less thing to patch :)
bnieuwenhuizen has quit [Quit: Bye]
bnieuwenhuizen has joined #dri-devel
davispuh has joined #dri-devel
guludo has quit [Quit: WeeChat 4.5.2]
guludo has joined #dri-devel
soze has quit [Ping timeout: 480 seconds]
soze has joined #dri-devel
epoch101 has joined #dri-devel
kzd has joined #dri-devel
warpme has quit []
bolson has joined #dri-devel
jsa1 has quit [Ping timeout: 480 seconds]
kts has joined #dri-devel
andersson123 has quit [Ping timeout: 480 seconds]
andersson123 has joined #dri-devel
jsa1 has joined #dri-devel
clever_ has joined #dri-devel
LeviYun has quit [Ping timeout: 480 seconds]
clever has quit [Ping timeout: 480 seconds]
Daanct12 has quit [Quit: WeeChat 4.5.2]
warpme has joined #dri-devel
fab has quit [Quit: fab]
epoch101_ has joined #dri-devel
epoch101 has quit [Ping timeout: 480 seconds]
LeviYun has joined #dri-devel
coldfeet has joined #dri-devel
epoch101_ has quit []
haaninjo has joined #dri-devel
sguddati has joined #dri-devel
epoch101 has joined #dri-devel
mehdi-djait3397165695212282475 has quit []
mehdi-djait3397165695212282475 has joined #dri-devel
jsa1 has quit [Ping timeout: 480 seconds]
dolphin has quit [Quit: Leaving]
warpme has quit []
sally_ is now known as sally
mszyprow has quit [Ping timeout: 480 seconds]
epoch101_ has joined #dri-devel
epoch101 has quit [Ping timeout: 480 seconds]
jsa1 has joined #dri-devel
soze has quit [Ping timeout: 480 seconds]
warpme has joined #dri-devel
sguddati has quit [Ping timeout: 480 seconds]
warpme has quit []
tzimmermann has quit [Quit: Leaving]
soze has joined #dri-devel
soze has quit [Remote host closed the connection]
soze has joined #dri-devel
fab has joined #dri-devel
soze has quit [Ping timeout: 480 seconds]
tobiasjakobi has joined #dri-devel
tobiasjakobi has quit [Remote host closed the connection]
kts has quit [Ping timeout: 480 seconds]
chewitt has quit [Quit: Zzz..]
andersson123 has quit [Ping timeout: 480 seconds]
jsa1 has quit [Ping timeout: 480 seconds]
andersson123 has joined #dri-devel
epoch101 has joined #dri-devel
epoch101_ has quit [Ping timeout: 480 seconds]
soze has joined #dri-devel
mszyprow has joined #dri-devel
rasterman has quit [Quit: Gettin' stinky!]
mehdi-djait3397165695212282475 has quit []
andre_m has joined #dri-devel
<jljusten>
eric_engestrom: hey, was 0e648a238e2 ("intel/dev: Add BMG PCI IDs (0xe210, 0xe215, 0xe216)") missed for cherry-picking to 25.0?
andre_m has quit [Ping timeout: 480 seconds]
epoch101_ has joined #dri-devel
epoch101 has quit [Ping timeout: 480 seconds]
mbrost has joined #dri-devel
soze has quit [Ping timeout: 480 seconds]
soze has joined #dri-devel
andersson123 has quit []
coldfeet has quit [Quit: Lost terminal]
cyrinux9 has quit []
cyrinux9 has joined #dri-devel
jsa1 has joined #dri-devel
<mdnavare_>
Hi Does anyone know why drm_mode.h has two HDMI types #define DRM_MODE_CONNECTOR_HDMIA11
<mdnavare_>
#define DRM_MODE_CONNECTOR_HDMIB12
elongbug has joined #dri-devel
elongbug has quit []
<eric_engestrom>
jljusten: ah sorry about that! I just looked at it, and it has two `backport-to:` lines and there's currently a bug where only the first one applies, and I have a local script that I use as a workaround for now (because the proper fix requires a bunch of rewriting) and I had a bug in that script... so yeah ^^'
<eric_engestrom>
anyway, it's now in the branch and will be in the next release, 25.0.3 :)
<mdnavare_>
Ok great that helps thank you so much @jannau
mbrost has quit [Ping timeout: 480 seconds]
fab has quit [Quit: fab]
mbrost has joined #dri-devel
jkrzyszt has quit [Ping timeout: 480 seconds]
mbrost_ has joined #dri-devel
mbrost has quit [Ping timeout: 480 seconds]
<jljusten>
eric_engestrom: Yeah, I was trying to figure out what was preferred. I would have preferred "24.3, 25.0", but for some reason I thought maybe two lines were preferred by the script.