13:55 <ajhalaney[m]> I thought I had heard iommu.strict=0 or IOMMU_DEFAULT_DMA_LAZY=y would help with the USB speeds at agl7-x13s HdkR but I haven't used USB on this thing to verify any of that :)

17:21 <steev> jhovold: is your fix init-count imbalance patch needed, when bjorn's changes that in his patch 2 of the orientation switching stuff?

17:22 <jhovold> steev: yes, bjorns patches should be rebased on top

17:22 <steev> i'm sure he'll do that for v2 :)

17:23 <jhovold> it's an old bug that has been there since forever, but we better fix it before building more stuff relying on that counter

17:31 <init_x13s> I might have "improved" the internal keyboard responsivity by changing the keyboard interrupt to falling edge, but it's honestly hard to benchmark, fair chance it's better just in my head. It does not cause any problem however (i have been running my patch for a full week)

17:31 <init_x13s> still, I feel like this won't get better.

17:32 <steev> submit it upstream and see what people say :)

17:33 <init_x13s> I lack the proper credentials to pretend I understand what I do.

17:34 <steev> i have no idea what i'm doing 90% of the time... and got a bluetooth driver in (thanks to some wonderful code reviews), if i can do it, so can you

17:34 <init_x13s> Modest patch here , if you want to try it

17:35 <steev> well, bluetooth driver changes

17:35 <init_x13s> https://github.com/gabtremblay/x13s-alarm/blob/trunk/linux-x13s/0001-Fixed-internal-keyboard-interrupt-handling.patch

17:35 <init_x13s> i also have no idea where and how to submit this for review..

17:36 <steev> well, easy enough to learn :)

17:36 <steev> https://people.kernel.org/monsieuricon/sending-a-kernel-patch-with-b4-part-1

17:37 <init_x13s> thx for the ref

17:39 <init_x13s> Anyways, it still seems insufficient to fully fix it. The difference between a external usb keyboard vs the internal one is still very noticeable. "aka" the external one never misses a single key. So it might need something different, and/or can't be fixed at all.

17:39 <init_x13s> I don't trust my patch enough, and the results are imho, probably just better in my head

17:46 <HdkR> ajhalaney[m]: My results were with using that option

17:46 <steev> submit it anyway? worst case, they say it's wrong, best case, you improve it for everyone

17:47 <ajhalaney[m]> HdkR: good to know, not good to hear :/

17:48 <init_x13s> steev: alright, good advice.

17:49 <steev> i've submitted stuff that is just "disable this for now til someone smart can look at it"

17:50 <steev> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts?id=382e3e0eb6a83f1cf73d4dfa3448ade1ed721f22

18:11 <init_x13s> steev: should i send against linux next or current (6.3.1) ?

18:12 <steev> next

18:12 <init_x13s> thx