ChanServ changed the topic of #asahi-dev to: Asahi Linux: porting Linux to Apple Silicon macs | Non-development talk: #asahi | General development | GitHub: https://alx.sh/g | Wiki: https://alx.sh/w | Logs: https://alx.sh/l/asahi-dev
chadmed has joined #asahi-dev
chrisl has joined #asahi-dev
emilia-miki has joined #asahi-dev
chrisl has quit [Ping timeout: 480 seconds]
HitokiriKincho has joined #asahi-dev
yuyichao_ has quit [Ping timeout: 480 seconds]
Extern has joined #asahi-dev
Extern has quit []
HitokiriKincho has quit [Quit: Leaving...]
Extern has joined #asahi-dev
Extern has quit [Quit: WeeChat 4.1.1]
sudtho has joined #asahi-dev
sudtho has quit [Ping timeout: 480 seconds]
pb17 has quit [Ping timeout: 480 seconds]
pb17 has joined #asahi-dev
<chadmed>
is there any point to writing wrappers for some of these adt routines that are only ever called internally?
chrisl has joined #asahi-dev
emilia-miki has quit [Quit: emilia-miki]
chrisl has quit [Ping timeout: 480 seconds]
HitokiriKincho has joined #asahi-dev
chrisl has joined #asahi-dev
chrisl has quit [Ping timeout: 480 seconds]
pb17 has quit [Ping timeout: 480 seconds]
HitokiriKincho has quit [Remote host closed the connection]
HitokiriKincho has joined #asahi-dev
pb17 has joined #asahi-dev
Halian has quit [Quit: I'll be back.]
Halian has joined #asahi-dev
HitokiriKincho has quit [Ping timeout: 480 seconds]
HitokiriKincho has joined #asahi-dev
john-cabaj has joined #asahi-dev
HitokiriKincho has quit [Ping timeout: 480 seconds]
john-cabaj has quit [Ping timeout: 480 seconds]
HitokiriKincho has joined #asahi-dev
tobhe_ has joined #asahi-dev
tobhe has quit [Ping timeout: 480 seconds]
chadmed has quit [Quit: Konversation terminated!]
chadmed has joined #asahi-dev
pb17 has quit [Ping timeout: 480 seconds]
chadmed has quit [Quit: Konversation terminated!]
chadmed has joined #asahi-dev
nora_ has joined #asahi-dev
nora has quit [Ping timeout: 480 seconds]
ddxtanx has quit [Remote host closed the connection]
pb17 has joined #asahi-dev
chadmed has quit [Read error: No route to host]
chadmed has joined #asahi-dev
chrisl has joined #asahi-dev
duckworld has quit [Remote host closed the connection]
duckworld has joined #asahi-dev
JayBeeFOSS has quit [Remote host closed the connection]
duckworld has quit [Remote host closed the connection]
<chadmed>
the last bindings i did were glib<->Lua so this is kinda alien
chrisl has quit [Ping timeout: 480 seconds]
pb17 has quit [Ping timeout: 480 seconds]
mildsunrise has quit [Quit: disconnect]
mildsunrise has joined #asahi-dev
<chadmed>
one thing im not too sure on is the ADT_MAX_SIZE stuff. surely theres a way we can get the actual adt size. how does the dumper know where to stop?
<chadmed>
oh its in the boot args
pb17 has joined #asahi-dev
lena6 has joined #asahi-dev
<j`ey>
whats with check_header() using 0 as *const ADTNodeHeader>
Halian has quit [Quit: I'll be back.]
<j`ey>
you can also use prop.is_null() instead of casting to a number and == 0
<j`ey>
check_offset could return a Result<>. then you'd write: ret = ADT::check_offset(offset)?;
<chadmed>
j`ey: the adt header is just a "normal" node at the base address given to us by iboot
<chadmed>
its using 0 as the offset argument into check_node
<chadmed>
oh wait what lmfao i cast it
<j`ey>
yes you just pass 0 as a ptr and check_node() derefs that!
<chadmed>
i rewrote check_node to play nicer with everything else and didnt change check_header :p
<chadmed>
fixed, thanks
<j`ey>
data field isnt used yet, I guess because you never look into it itself, since youre using bindings
<chadmed>
yeah. to rewrite all the logic Properly(tm) we also need the boot args, and i cant figure out how lina did the agx struct versioning magic
<chadmed>
and i feel like given she _can_ do that, doing it the old fashioned way is just a waste of time
<j`ey>
this probably doesn't need all that?
<chadmed>
can we just grab the device tree size from the c land boot args
<j`ey>
you can just write a C function and add a binding, if its easier
<chadmed>
oh yeah...
<j`ey>
(to return the adt size)
gladiac has joined #asahi-dev
lena6 has quit [Remote host closed the connection]
chrisl has joined #asahi-dev
chrisl has quit [Ping timeout: 480 seconds]
tanty has quit [Ping timeout: 480 seconds]
BesterGester has joined #asahi-dev
opticron has quit [Read error: Connection reset by peer]
opticron has joined #asahi-dev
HitokiriKincho has quit [Remote host closed the connection]
iyes has quit [Ping timeout: 480 seconds]
HitokiriKincho has joined #asahi-dev
iyes has joined #asahi-dev
chrisl has joined #asahi-dev
tanty has joined #asahi-dev
chrisl has quit [Ping timeout: 480 seconds]
HitokiriKincho has quit [Remote host closed the connection]
chadmed has quit [Quit: Konversation terminated!]
HitokiriKincho has joined #asahi-dev
HitokiriKincho has quit [Remote host closed the connection]
HitokiriKincho has joined #asahi-dev
chadmed has joined #asahi-dev
<chadmed>
\o/ from m1n1 with a bunch of adt logic rewritten in rust (we love testing in prod)
<sven>
everyone tests in prod, some people are just lucky enough to also have a test environment ;)
<chadmed>
we have testers, theyre called users
<chaos_princess>
the best part is when you supposedly have an independent "test" environment, and after you push a release to there, you somehow break prod :P
<chaos_princess>
why adt btw, it is not an untrusted input, no?
<j`ey>
gotta start somewhere
<chadmed>
^
<chadmed>
i was going to start with the display config stuff that broke recently but everything is so entangled, and from quick vibe analysis it seems like ADT lives somewhere near the middle of that entanglement
<chaos_princess>
makes sense then
<chadmed>
it also seemed a little easier than other parts of m1n1 that have more moving parts, and ive never done this before :)
<chadmed>
it would be good to get rid of some of the #![feature] stuff too
HitokiriKincho has quit [Remote host closed the connection]
HitokiriKincho has joined #asahi-dev
chadmed has joined #asahi-dev
HitokiriKincho has quit [Ping timeout: 480 seconds]
sand4rt has joined #asahi-dev
pb17 has joined #asahi-dev
johey_ has joined #asahi-dev
sand4rt has quit [Ping timeout: 480 seconds]
johey has quit [Ping timeout: 480 seconds]
sting has quit [Quit: doei]
chrisl has joined #asahi-dev
sting has joined #asahi-dev
<sven>
nickchan: can you link me to your pending patch series that have to go through asahi-soc that are still pending?
chrisl has quit [Ping timeout: 480 seconds]
patrickm has quit [Ping timeout: 480 seconds]
HitokiriKincho has joined #asahi-dev
patrickm has joined #asahi-dev
lucyllewy has quit [Quit: Connection closed for inactivity]
pb17 has quit [Ping timeout: 480 seconds]
pb17 has joined #asahi-dev
nepeat_ has joined #asahi-dev
nepeat has quit [Ping timeout: 480 seconds]
chrisl has joined #asahi-dev
HitokiriKincho has quit [Ping timeout: 480 seconds]
chrisl has quit [Ping timeout: 480 seconds]
HitokiriKincho has joined #asahi-dev
<sven>
arnd: do you also need a PR for the updates to MAINTAINERS or are they going to be picked up directly since they were sent to soc@lists.linux.dev?
HitokiriKincho has quit [Ping timeout: 480 seconds]
<arnd>
in general, patches and pull requests sent to soc@lists.linux.dev are equivalent for simple changes, while for any larger series a pull request is nicer because it gives you the chance to have a summary for the merge commit that gets preserved in the git history, and you can be sure I get the exact same commit IDs that you have tested
<arnd>
for the maintainer file update, neither of those is important
<arnd>
I usually pick up updates to MAINTAINERS in the bugfix branch since it helps to have the latest version in the release, and there is no regression risk
<arnd>
I might change the subject line to s/myself/Janne/ since that makes more sense for the shortlog
HitokiriKincho has joined #asahi-dev
<sven>
makes sense, thanks!
johey_ has quit [Ping timeout: 480 seconds]
chrisl has joined #asahi-dev
sand4rt has joined #asahi-dev
chrisl has quit [Ping timeout: 480 seconds]
johey has joined #asahi-dev
HitokiriKincho has quit [Ping timeout: 480 seconds]
patrickm has quit [Ping timeout: 480 seconds]
patrickm has joined #asahi-dev
HitokiriKincho has joined #asahi-dev
HitokiriKincho has quit [Ping timeout: 480 seconds]
chrisl has joined #asahi-dev
pb17 has quit [Ping timeout: 480 seconds]
chrisl has quit [Ping timeout: 480 seconds]
pb17 has joined #asahi-dev
HitokiriKincho has joined #asahi-dev
patrickm has quit [Ping timeout: 480 seconds]
HitokiriKincho has quit [Ping timeout: 480 seconds]
patrickm has joined #asahi-dev
nimprod3l has joined #asahi-dev
nimprod3l has quit []
Extern has joined #asahi-dev
chrisl has joined #asahi-dev
sand4rt has quit [Ping timeout: 480 seconds]
HitokiriKincho has joined #asahi-dev
chrisl has quit [Ping timeout: 480 seconds]
HitokiriKincho has quit [Ping timeout: 480 seconds]
patrickm has quit [Remote host closed the connection]
patrickm has joined #asahi-dev
HitokiriKincho has joined #asahi-dev
patrickm has quit [Remote host closed the connection]
patrickm has joined #asahi-dev
<nickchan>
sven: 3 serieses and a singular patch, in order,
<nickchan>
3 and 4 conflicts with each other however because they add completely unrelated things to the same part of the .dts file (keep both is the resolution)
<nicolas17>
nickchan: A9 variants even use different files for iOS OTA updates
<nicolas17>
appledb had to change the json schema to deal with that ._.
chrisl has joined #asahi-dev
<sven>
nickchan: thx, will take a look tomorrow. if they are have reviews/ack i'll pull them in
<sven>
-are
chrisl has quit [Ping timeout: 480 seconds]
<nicolas17>
"The modesetting driver does not check the non-desktop connector property and keeps the device open and locked. If the touchbar daemon opens the device first modesetting breaks the whole X session. Simply refuse to open the device for X11 server processes as workaround." ew :(
<nickchan>
sven: Everything outside of arch/arm64/boot/dts/apple (the bindings) have acks from krzk, as for the actual .dts files however, only the PMGR ones have some acks, excluding "arm64: dts: apple: t8012: Add PMGR nodes"
<nickchan>
all of them are at least a month old without objections however
Extern has quit [Quit: WeeChat 4.1.1]
chrisl has joined #asahi-dev
HitokiriKincho has quit [Ping timeout: 480 seconds]
chrisl has quit [Ping timeout: 480 seconds]
HitokiriKincho has joined #asahi-dev
HitokiriKincho has quit [Ping timeout: 480 seconds]
yuyichao_ has joined #asahi-dev
chrisl has joined #asahi-dev
chrisl has quit [Ping timeout: 480 seconds]
<sven>
ok, I’ll take a look tomorrow then
chrisl has joined #asahi-dev
chrisl has quit [Ping timeout: 480 seconds]
HitokiriKincho has joined #asahi-dev
pb17 has quit [Ping timeout: 480 seconds]
HitokiriKincho has quit [Ping timeout: 480 seconds]
parazyd has quit [Quit: -YES]
pb17 has joined #asahi-dev
chrisl has joined #asahi-dev
chrisl has quit [Ping timeout: 480 seconds]
commandoline has quit [Quit: Bye!]
commandoline has joined #asahi-dev
commandoline has quit []
commandoline has joined #asahi-dev
sativa93 has joined #asahi-dev
HitokiriKincho has joined #asahi-dev
emilia-miki has joined #asahi-dev
HitokiriKincho has quit [Ping timeout: 480 seconds]
sativa93 has quit [Ping timeout: 480 seconds]
pb17 has quit [Ping timeout: 480 seconds]
sativa93 has joined #asahi-dev
chrisl has joined #asahi-dev
sativa93 has quit [Remote host closed the connection]
sativa93 has joined #asahi-dev
sativa93 has quit []
sativa93 has joined #asahi-dev
chrisl has quit [Ping timeout: 480 seconds]
emilia-miki has quit [Ping timeout: 480 seconds]
lena6 has joined #asahi-dev
HitokiriKincho has joined #asahi-dev
pb17 has joined #asahi-dev
HitokiriKincho has quit [Ping timeout: 480 seconds]