ChanServ changed the topic of #haiku to: Open-source operating system that specifically targets personal computing. | https://haiku-os.org | Nightlies: https://download.haiku-os.org | Bugtracker: https://dev.haiku-os.org | SCM: https://git.haiku-os.org/ | Logs: https://oftc.irclog.whitequark.org/haiku | Matrix: #haiku:matrix.org | XMPP: #haiku%irc.oftc.net@irc.jabberfr.org
HaikuUser has joined #haiku
HaikuUser has quit []
wintp has joined #haiku
<coolcoder613> Can I build bfs_tools for linux?
wintp has quit [Ping timeout: 480 seconds]
x10z has joined #haiku
HaikuUser has joined #haiku
HaikuUser has quit []
xet7 has quit [Ping timeout: 480 seconds]
ablyss has joined #haiku
wintp has joined #haiku
coolcoder613_ has joined #haiku
tuaris1 has joined #haiku
x10z has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
tuaris has quit [Ping timeout: 480 seconds]
coolcoder613 has quit [Ping timeout: 480 seconds]
wintp has quit [Ping timeout: 480 seconds]
wintp has joined #haiku
wintp has quit [Ping timeout: 480 seconds]
wintp has joined #haiku
wintp has quit [Ping timeout: 480 seconds]
<OscarL> note to future Begasus: aclocal (from automake) seems to be missing a dependency on cmd:libtoolize
wintp has joined #haiku
x10z has joined #haiku
wintp has quit [Ping timeout: 480 seconds]
wintp has joined #haiku
wintp has quit [Ping timeout: 480 seconds]
wintp has joined #haiku
mmu_man has quit [Ping timeout: 480 seconds]
wintp has quit [Ping timeout: 480 seconds]
wintp has joined #haiku
kescher_ has joined #haiku
kescher has quit [Ping timeout: 480 seconds]
kescher_ is now known as kescher
wintp has quit [Ping timeout: 480 seconds]
wintp has joined #haiku
HaikuUser has joined #haiku
HaikuUser has quit []
wintp has quit [Ping timeout: 480 seconds]
wintp has joined #haiku
Maturi0n_ has joined #haiku
Calisto has joined #haiku
<Calisto> Heyyyy... Btw since I'm going to try drafting a proposal sometime in the future for GSoC, should I be stating the issues that I have solved till now? PulkoMandy had given me 3 to get started out... Im going to try and fix the other one by tomorrow hopefully :) Any advice?
Maturi0n has quit [Ping timeout: 480 seconds]
wintp has quit [Ping timeout: 480 seconds]
<OscarL> Calisto: not many people awake at these hours, I think (at least not those with experience on GSoC matters).
<Calisto> Oh okay 😅
<Calisto> Right right i keep forgetting the time zone thing
<Calisto> Well in any case
<OscarL> you might try later today, or ask on the forums/mailing list.
<Calisto> Yup
<Calisto> The general one or the dev one?
<OscarL> dev one, I think.
<Calisto> Because if its the dev one, I might as well just reply to the current email sent to me by PulkoMandy right?
<OscarL> I know some past GSoC mentors do pay attention there, and haven't seem them here in a couple of years, for example :-D
<Calisto> Oh okayyyy
ClaudioM has quit [Quit: leaving]
wintp has joined #haiku
<OscarL> in general, using public channels will give you more changes of getting more replies from diferent people, I think.
<OscarL> s/changes/chanses/ (damn typos!)
<Calisto> Rightt that makes sense
<OscarL> *chances. damn!
* OscarL can't English.
<Calisto> Okay then I'll send an email on the dev mailing list as well
<Calisto> xD
<Calisto> Thank you so much OscarL
<Calisto> Btw what time zone are u in.
<Calisto> ?*
<OscarL> no problem! UTC-3:00 (Argentina)
<Calisto> Oh ok cool will keep that in mind
<Calisto> Okay then I'll be AFK for a while
<Calisto> Have uni now xD
<Calisto> Bye :)
<OscarL> later!
wintp has quit [Ping timeout: 480 seconds]
Calisto has quit [Ping timeout: 480 seconds]
Calisto has joined #haiku
Calisto has quit [Ping timeout: 480 seconds]
HaikuUser has joined #haiku
HaikuUser has quit []
wintp has joined #haiku
vdamewood has joined #haiku
wintp has quit [Ping timeout: 480 seconds]
wintp has joined #haiku
wintp has quit [Ping timeout: 480 seconds]
v_harkonnen has joined #haiku
wintp has joined #haiku
AlienSoldier has quit [Quit: Vision[]: i've been blurred!]
ablyss has quit [Remote host closed the connection]
wintp has quit [Ping timeout: 480 seconds]
coolcoder613 has joined #haiku
coolcoder613_ has quit [Read error: Connection reset by peer]
wintp has joined #haiku
HaikuUser has joined #haiku
sg94 has joined #haiku
wintp has quit [Ping timeout: 480 seconds]
HaikuUser has quit [Quit: Vision[]: i've been blurred!]
wintp has joined #haiku
v_harkonnen has quit [Ping timeout: 480 seconds]
wintp has quit [Ping timeout: 480 seconds]
Calisto has joined #haiku
HaikuUser has joined #haiku
HaikuUser has quit []
wintp has joined #haiku
OscarL has quit [Ping timeout: 480 seconds]
Calisto has quit [Ping timeout: 480 seconds]
vdamewood has quit [Quit: Textual IRC Client: www.textualapp.com]
Begasus has joined #haiku
<Begasus> g'morning peeps
<Begasus> note to OscarL ... fix automake then
Begasus has quit [Quit: Vision[]: i've been blurred!]
Begasus has joined #haiku
x10z has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
itaipu has quit [Ping timeout: 480 seconds]
x10z has joined #haiku
kinkinkijkin has joined #haiku
x10z has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
x10z has joined #haiku
<botifico> [haikuports/haikuports] Begasus pushed 1 commit to master [+2/-2/±0] https://github.com/haikuports/haikuports/compare/5fa5be42e16b...3c91f8a9c82f
<botifico> [haikuports/haikuports] Begasus 3c91f8a - gcompris, bump version (#10159)
kinkinkijkin has quit [Quit: Leaving]
<Begasus> whoot, only took less then a minute now to merge a fix upstream for gcompris :D
freddietilley has joined #haiku
x10z has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
coolcoder613_32 has quit [Quit: Vision[]: i've been blurred!]
sg94 has quit [Quit: Textual IRC Client: www.textualapp.com]
moparisthebest has joined #haiku
JakeSays has joined #haiku
nephele has joined #haiku
JakeSays1 has quit [Ping timeout: 480 seconds]
AlaskanEmily has quit [Remote host closed the connection]
Calisto has joined #haiku
<Begasus> still an anoying thing with the forum software is trying to add screenshots in a post :/
x10z has joined #haiku
x10z_ has joined #haiku
x10z__ has joined #haiku
x10z has quit [Ping timeout: 480 seconds]
x10z has joined #haiku
coolcoder613_ has joined #haiku
x10z_ has quit [Ping timeout: 480 seconds]
x10z__ has quit [Ping timeout: 480 seconds]
coolcoder613 has quit [Ping timeout: 480 seconds]
diver has quit [Quit: Leaving.]
diver has joined #haiku
JakeSays1 has joined #haiku
JakeSays has quit [Ping timeout: 480 seconds]
tuaris1 has quit [Ping timeout: 480 seconds]
<Begasus> biab
x10z_ has joined #haiku
coolcoder613_ has quit [Ping timeout: 480 seconds]
x10z has quit [Ping timeout: 480 seconds]
CalistoMathias has joined #haiku
<CalistoMathias> Hey so I just had a question.... turns out i made a tiny mistake while doing the Media Player Settings fix
<nephele> Oh no!
<CalistoMathias> i fixed it just now
<CalistoMathias> it was a pretty stupid mistake but its fine
<CalistoMathias> i want to edit the commit now
<CalistoMathias> like i have to edit the same one right?
<CalistoMathias> before pushing it again?
<Begasus[m]> happens to all of us ;)
<CalistoMathias> this time i tested it out on different font sizes and its pretty much fine
<CalistoMathias> i finally understood why the b_control_look->DefaultSpacingItem() was used in the first place xD
<CalistoMathias> so basically now that I want to change my commit...
<CalistoMathias> i just have to do the regular git add .
<CalistoMathias> but rather than git commit a new message and everything I need to do git commit --amend right?
<Begasus[m]> nephele should know there :)
<CalistoMathias> so should I be doing that?
<Begasus[m]> how I use it is git add/git commit --amend
<Begasus[m]> last one can be used to change the commit message
<CalistoMathias> oh okay so i have to do the git add followed by the regular commit just with an --amend
<Begasus[m]> but I don't know if that works the same at gerrit
<CalistoMathias> after that I need to rebase and push?
<CalistoMathias> like that's what I did yesterday night
<CalistoMathias> just wanted to confirm whether its like that while I need to edit the previous commit as well
<CalistoMathias> because the reviewer told there was an issue with the font size thing which I just fixed now
<nephele> if you have the git hook installed AND the HEAD commit is the one you want to change on gerrit
<nephele> then yes, use git add, then git commit --amend
<CalistoMathias> cool
<CalistoMathias> thanks so much
<CalistoMathias> after that its the regular rebasing + pushing right?
<CalistoMathias> nothing extra to do there?
<nephele> you can then check with "git show HEAD" or "git diff HEAD HEAD~1" that it's the right commit
<nephele> no need to rebase, just push it git push origin HEAD:refs/for/master
<nephele> you should rebase yourself sometimes to keep your sanity though
x10z_ has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
<CalistoMathias> okay its pushing xD
<CalistoMathias> kind of scared lmao
<CalistoMathias> hopefully everything goes fine
<CalistoMathias> i really don't want to screw this up xD
<Begasus> it's still a learning process CalistoMathias, I'm sure upstream can handle it :)
<CalistoMathias> yah :)
<CalistoMathias> well it worked properly :D
<CalistoMathias> and it pushed it
<CalistoMathias> hopefully it passes the review :D
<CalistoMathias> tho i think I fixed it fine this time
<CalistoMathias> btw could someone exactly tell what be_control_layout->DefaultSpacingItem() return? like does it return a responsive width or something?
<CalistoMathias> or is it just a fixed number?
<Begasus> If I build a package from source can I launch it in R1B4? (well it did with the About window) but still ;)
coolcoder613 has joined #haiku
<B2IA> (UnrealNeil) butler catsup
<nephele> CalistoMathias: control_layout? or control_look?
mmu_man has joined #haiku
<CalistoMathias> sorry sorry control_look
<CalistoMathias> also i don't really get the implication of weight
<CalistoMathias> in the .Add() [or equivalent] in the layout builders?
<CalistoMathias> what do they exactly do?
<nephele> I think you mean be_control_look->DefaultItemSpacing() ?
<CalistoMathias> yup that one... like I wanna know what exactly it returns ... and also what is the implication of the weight in the .Add() functions
<nephele> here the be_control_look is the current BControlLook that is configured, this is a *library* that the app_server will load, however this can be changed by the user, and change at runtime
<nephele> for example on the forums the FlatControlLook
<nephele> it is called because the ControlLook will dictate what spacing you ought to use
<nephele> it depends on the code of the controlLook what will be returns
<nephele> returned*
<nephele> You can check in src/kits/interface/HaikuControlLook.cpp for the default implementation in HaikuControlLook
CalistoMathias has quit [Quit: Vision[]: i've been blurred!]
<Calisto> Oh okay cool
<Calisto> Ill try reading through that
<nephele> The default in HaikuControlLook is return "ceilf(be_plain_font->Size() * 0.85);"
<Calisto> Ohhh okay
<Calisto> Just another small question... I was trying to fix another tiny issue that was given to me by mail from the GSoc reply
<Calisto> I tried compiling the source code for the app
<Calisto> But the app that I compile and run
<Begasus> whoot!!!
<Begasus> time to hop in :P
<Calisto> Is different from the app that is installed
<Calisto> So I'm kind of confused
<Calisto> The compiled edition gives me the same kind of issue as described in the ticket
<Calisto> While the installed edition is different
<Calisto> Or is it cuz until the ticket is fixed they are using a different edition of the app
<Calisto> ?
<nephele> more context please
<nephele> what application, what issue, and where did you try to fix it
<nephele> if the fix is in a system library you need to test this seperately
<Calisto> Devices
<Calisto> Is the one
<Calisto> Wait I'll give the ticket number
* Begasus retracks himself for duty for a while :D
<Calisto> The ticket is 18213
<Calisto> nephele:
x10z has joined #haiku
x10z_ has joined #haiku
coolcoder613 has quit [Ping timeout: 480 seconds]
wintp_ has joined #haiku
qwebirc96910 has joined #haiku
qwebirc96910 has quit []
x10z__ has joined #haiku
x10z_ has quit [Read error: Connection reset by peer]
x10z has quit [Ping timeout: 480 seconds]
wintp has quit [Ping timeout: 480 seconds]
wintp_ has quit [Quit: WeeChat 4.2.1]
wintp has joined #haiku
<nephele> Calisto: where did you develop the fix? in which system component?
<nephele> I'm guessing you just want to remove the TabView so this looks plane?
x10z__ has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
stux|away has quit [Read error: Connection reset by peer]
stux|away has joined #haiku
<Calisto> Yup that's the issue
<Calisto> That there's only one tab
<Calisto> So there's no point of a tab view
<Calisto> Or maybe it's just some weird issue
<Calisto> Wait lemme cross check
itaipu has joined #haiku
wicknix_ has joined #haiku
wicknix has quit [Ping timeout: 480 seconds]
<nephele> hmm :)
gouchi has joined #haiku
gouchi has quit [Remote host closed the connection]
<PulkoMandy> Calisto: Are you running beta 4? The Devices app changed a bit since beta4
<PulkoMandy> That's what this ticket is about, finishing up these changes by removing the now useless tab view with a single tab
zard has joined #haiku
x10z has joined #haiku
novaphoenix0 has quit [Quit: gone fishing]
novaphoenix has joined #haiku
Begasus_32 has joined #haiku
<Calisto> Yah i think I am
<Calisto> I was running the latest version I guess
<Calisto> Wait lemme just check once
<Calisto> So in the latest version, the ticket is already closed or something like that?
HaikuUser has joined #haiku
HaikuUser has quit []
<nephele> No. If it's closed it's closed.
<nephele> If it's open that means it's not fixed
<nephele> (unless someone forgot)
<PulkoMandy> Calisto: In beta 4 (last release, from last year), there were multiple tabs in the tab view
<PulkoMandy> In the current nightly builds, the one you compiled, there is only one tab, so a tab view is useless. The goal of a tab view is to switch between different tabs
<PulkoMandy> So the app must be further changed to remove the tab view, and have the content of the single tab put directly in the window, without a tab around it
Calisto has quit [Ping timeout: 480 seconds]
Calisto has joined #haiku
<Calisto> Yup I use r1/beta4 PulkoMandy
CalistoMathias has joined #haiku
v_harkonnen has joined #haiku
<andreasdr[m]> Hi there.
<CalistoMathias> oh okay i see @pulkomandy
<CalistoMathias> so now in the compiled version i should find a way to just show one view
<CalistoMathias> ill try getting that fixed
HaikuUser has joined #haiku
<zard> I'm thinking of putting PulkoMandy's post about how to help out with WebKit (https://discuss.haiku-os.org/t/my-progress-on-webkit2-port/11653/64) somewhere more discoverable...
HaikuUser has quit []
<zard> Maybe on HaikuWebKit's wiki?
<nephele> We have a wiki?
<zard> (Note: it doesn't have a wiki atm)
<nephele> Put it in a readme
<PulkoMandy> Putting it in a wiki that doesn't exist is not the greatest way :d
<PulkoMandy> But Iguesswe could put some pages on Trac about it
<nephele> or the website in the development section
<nephele> PulkoMandy: maybe you can release that post as a blog post on the website too?
* zard checks out the development section of the website
<PulkoMandy> I try to move things off the website, it's badly organized and not helpful to find development information
<zard> Interesting...
<PulkoMandy> But it could go in www.haiku-os.org/docs/develop/ since I decided to fix this by creating yet another place to put documents...
HaikuUser has joined #haiku
HaikuUser has quit []
<zard> Oh, so you were talking about another place before. /me was looking here :P
<zard> s/here/there already/
<PulkoMandy> Anyway, pick any one ofthese options, it willbe better thana forum post :)
<nephele> I'd say pulkomandys blod or docs/develop ;)
<zard> Haha! Strange to think it's not too hard to make a post on someone else's blog :P
<PulkoMandy> The website docs are in https://www.haiku-os.org/development/ and https://www.haiku-os.org/documents (both linked from the top navigation bar). No one understands how these are organized so there is also https://www.haiku-os.org/guides (not really linked from anywhere easy o reach). This is what's called "the website" (the part currently generated with Hugo, used to be Drupal before)
<PulkoMandy> If you copy the forum host into my blog I'm happy to merge it :)
<PulkoMandy> Just add a note at the top explaining that it was initially a forum post with a link to the thread or something
<zard> Alright, guess I'll go with the blog post :)
HaikuUser has joined #haiku
x10z_ has joined #haiku
x10z has quit [Ping timeout: 480 seconds]
CalistoMathias has quit [Quit: Vision[]: i've been blurred!]
x10z has joined #haiku
x10z_ has quit [Ping timeout: 480 seconds]
x10z has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
v_harkonnen has quit [Ping timeout: 480 seconds]
HaikuUser2 has joined #haiku
HaikuUser2 has quit []
wintp has quit [Ping timeout: 480 seconds]
<Begasus> wip ... grabbing kauth6-6.0.0-1-x86_64.hpkg and moving it to /Opslag/haikuports/packages/kauth6-6.0.0-1-x86_64.hpkg :)
HaikuUser has quit [Quit: Vision[]: i've been blurred!]
wintp has joined #haiku
v_harkonnen has joined #haiku
wintp has quit [Ping timeout: 480 seconds]
<botifico> [haiku/website] pulkomandy pushed 1 commit to master [+1/-0/±0] https://github.com/haiku/website/compare/4eed25940381...321d3e2ac0ec
<botifico> [haiku/website] Zardshard 321d3e2 - Post "So you want to help with WebKit?" (#667)
<zard> :D
<dovsienko> could anyone remind what hrev looks like for a master branch with some local commits and some uncommitted changes?
wintp has joined #haiku
<muhamed_emad[m]> how to compiling wit gcc2. does that mean to try to build on x86-32bit or what
<muhamed_emad[m]> s/compiling/compile/, s/wit/with/
wintp has quit [Ping timeout: 480 seconds]
<zard> Yes, if you compile on 32 bit, you should be compiling with gcc version 2
<zard> You can check using gcc -v (gcc --version, I'm not sure)
<muhamed_emad[m]> zard: Ohh, okay thanks.
<nephele> gcc2 is only relevant for OS development for parts that are build with gcc2
<nephele> if you develop any new or third party project don't use it
<Begasus> :P
<zard> And yet here is Icon-O-Matic, still using it
* zard wonders if that's actually necessary. Quite hard to support
<nephele> "Is this a library providing BeOS compatibility"?
<nephele> If the answer is No then no, it is not
<nephele> ideally someone could add a gcc2 abi support to clang/llvm, then we can use that and can gcc2
<zard> Perhaps it's because Icon-O-Matic has to interface to libicon? And libicon may need to be used by some part of the code that has to be compiled with gcc2?
<zard> Ah wait, we can compile libicon with a modern gcc, so that it works with Icon-O-Matic again
<zard> So, just have two copies of it on the system, if necessary
<PulkoMandy> We already do that for libraries
mmu_man has quit [Ping timeout: 480 seconds]
<PulkoMandy> For applications we have only started migrating some. But there are some arguments for staying with gcc2 (for example, in iconomatic, using old translators from beos to export your icons to strange image formats would be possible thanks to building it with gcc2)
andreaa72 has joined #haiku
wintp has joined #haiku
andreaa72 has left #haiku [#haiku]
wintp has quit [Ping timeout: 480 seconds]
mmu_man has joined #haiku
v_harkonnen has quit [Ping timeout: 480 seconds]
wintp has joined #haiku
nosycat has joined #haiku
hightower4 has joined #haiku
<nosycat> Hello!
<zard> o/
hightower3 has quit [Ping timeout: 480 seconds]
wintp has quit [Ping timeout: 480 seconds]
bbjimmy has quit [Quit: Vision[]: i've been blurred!]
OscarL has joined #haiku
hightower2 has joined #haiku
v_harkonnen has joined #haiku
hightower4 has quit [Ping timeout: 480 seconds]
hightower3 has joined #haiku
<OscarL> dovsienko: something like "hrev57609+dirty" if I'm not mistaken.
<dovsienko> I tried to find the bit of code that constructs the version string, but got lost in the build system files pretty quickly
wintp has joined #haiku
<OscarL> Only tried it once myself (installing a custom .hpkg), but hrevXXXX+dirty at least shows ups a couple of times on the IRC logs :-)
hightower4 has joined #haiku
hightower2 has quit [Ping timeout: 480 seconds]
<OscarL> Bah... fixed path hyperlink for my use case... broke it for paths starting with ~ :-D
hightower3 has quit [Ping timeout: 480 seconds]
<OscarL> well, broke detection of relative paths if it looks something like: "[~/rel/path (foobar)]" at least (as in my prompt line).
wintp has quit [Ping timeout: 480 seconds]
CalistoMathias has joined #haiku
<CalistoMathias> @OscarL they push was accepted :D
<CalistoMathias> Had to make a small change but it got accepted :D
<OscarL> CalistoMathias: congrats on the +1! Buuut... you need at least a +2 before it gets merged :-D
<CalistoMathias> oh yah I guessed that was the reason
<CalistoMathias> but im still so happy that it went through +1 atleast xD
<CalistoMathias> at first it didn't go through and i was like ughhhhh but then I realised I had made a very lame mistake and finally it went through... so now that it has gone through +1 will they assign a new reviewer who will check again for +2?
<OscarL> CalistoMathias: indeed! Just keep in mind that *sometimes*, even if you get a +2, it may take a while for your change to get merged.
<CalistoMathias> oh okay
<CalistoMathias> that's quite alright
<CalistoMathias> im just happy that im finally doing something with the C++ i learnt xD
<CalistoMathias> makes sense tho there are sooo many issues on gerrit
wintp has joined #haiku
<CalistoMathias> that probaby are more important than the small fix that I made
Calisto has quit [Ping timeout: 480 seconds]
<OscarL> CalistoMathias: not unusual for even small patches to require lots of back-and-forth too, so... don't despair if that happens with any of your proposed changes.
<CalistoMathias> yup... I guess its part of the process right?
<OscarL> indeed.
<OscarL> hopefully, you'll learn quicker than I do, so you'll have an easier time with this from now on :-D
<CalistoMathias> btw BRow doesn't have any docs?
<CalistoMathias> hopefully...
<CalistoMathias> at first i was scared to do the commit --amend thing
<CalistoMathias> because i thought it would mess up the commit history and stuff
<CalistoMathias> but it went alright :)
<CalistoMathias> as for cleaning the branch i should wait until it gets a +2 before thinking about doing that right?
<nephele> CalistoMathias: +1 can be done by anyone, +2 only by commiters
<nephele> Sometimes commiters may +2 the change and merge it themselves
<nephele> but it may also be that someone +1's your change and someone else -1's it
<CalistoMathias> ohhhh i see
<CalistoMathias> so its like a constant back anda forth until whatever the code is supposed to do is perfected
<CalistoMathias> and only then is it merged?
<CalistoMathias> makes sense
HaikuUser has joined #haiku
HaikuUser has quit []
<nephele> Well, it doesn't need to be perfect. But we try to avoid code that is wrong, or doesn't follow the code style
bbjimmy has joined #haiku
<CalistoMathias> yup
<nephele> for new apis this is even more "meh" since removing something from the public api is not so easy
<CalistoMathias> rightttt
<nephele> You can check my review for new apis for the colors, that was quite a bit of back and forth :D
<CalistoMathias> oh okay I will defenitely do that
<CalistoMathias> In the meantime I think I should go through the deskbar LayoutAPI code to better understand everyting
<CalistoMathias> and try my hand at fixing the tab view issue in the devices app
<CalistoMathias> though I have no idea how to get started on that as there is no API docs
<CalistoMathias> on the Haiku Book
<nephele> no api docs for what?
<zard> Yeah, it would be nice to have more docs on that. I usually read code that uses the api to figure out how it works if it has no docs
<zard> nephele: LayoutAPI
talos has quit [Ping timeout: 480 seconds]
<zard> If you want, you can try writing some docs for it ;)
<CalistoMathias> yah there is like a lot of docs that are missing
<CalistoMathias> but the only problem is even im just starting to learn the layoutAPI so its pretty hard to comprehend what something is doing
<CalistoMathias> maybe if someday i get pretty good at the API
<CalistoMathias> i can give it a shot
<nephele> But there are docs?
<CalistoMathias> yah there is
<CalistoMathias> but a lot of the classes are missing as well ig uess
<CalistoMathias> like the BRow thing that I wanted to read just now doesn't have a doc page at all
<nephele> yes it may not be optimal
<CalistoMathias> neither does ColumnTypes.h ever get referenced anywhere
<nephele> Hey, atleast we added a search function to the api docs :D
wintp has quit [Ping timeout: 480 seconds]
<CalistoMathias> so im just confused as to how to go forward with it
<CalistoMathias> yup
<CalistoMathias> honestly the docs that are written as of now
<CalistoMathias> are really good
<CalistoMathias> like they were pretty useful while I was trying to understand already written code
<nephele> should remove the search function, you will never be able to tell what I didn't document mihahaha
<dovsienko> perhaps it could be a useful idea to see which documentation is lacking, and to ask students to add the documentation before any code
<CalistoMathias> but for the ones that don't exist Im pretty confused
<nephele> dovsienko: ask students to document code they don't understand? D:
HaikuUser has joined #haiku
HaikuUser has quit []
talos has joined #haiku
<CalistoMathias> the only thing im worried about is whether I would be able to completel learning everythign that I would need :(
<CalistoMathias> before I can make in a proposal for the query tracker window
<CalistoMathias> PulkoMandy had first told me to learn the LayoutAPI followed by the Query system on Haiku so that I can make meaningful contributions sometime in the future
<dovsienko> in my experience, the method works better than nothing
<nephele> headers/private/interface/ColumnListView.h
<nephele> this is where BRow lives
<CalistoMathias> the documenting before creating the code?
<nephele> and this header actually has inline focumentation
<nephele> documentation*
<CalistoMathias> do you think it would help if I do that somewhere? while trying to read through a header file
<CalistoMathias> oh okay
<CalistoMathias> ill go through that one then
<CalistoMathias> idk i tried somethign weird
<nephele> Not really, if you understand it and feel docs are missing go ahead
<CalistoMathias> but it crashed the devices app that I compiled
<nephele> but i don't think just documenting something you don't understand yet helps
<CalistoMathias> the thing is the BTab that contains a PropertyView which I guess is a child class somewhere of BView... but when I tried to add the PropertyView directly to the Splitlayout
<CalistoMathias> and compiled it
<CalistoMathias> the app did compile
<CalistoMathias> but on running it... it crashes
<nephele> check the debug report
<CalistoMathias> so then I thought maybe I should try and read the definitions of the classes before giving it another shot
<Al2O3> have you stepped through it in gdb?
<dovsienko> the point is to capture missing knowledge at the time one realises which knowledge is missing, not after the project is done
<nephele> Al2O3: on Haiku?
<dovsienko> but you can use a different method, of course
<CalistoMathias> wait wait I didn't get you dovsienko?
<Al2O3> no gdb in Haiku?
<nephele> We have Debugger, which is a GUI application
<zard> Al2O3: No, not really
<Al2O3> is the GUI app/IDE got tracing, breakpoints, conditionals?
<zard> Yes, thought not all of it works perfectly
<nephele> it's not an IDE, it's a Debugger
<zard> Conditionals didn't work, last I tried
wintp has joined #haiku
<dovsienko> CalistoMathias: if the existing documentation does not say something important and you spend a considerable time figuring it out, it may be a good idea to update the documentation as soon as you have figured out which bit is missing, as opposed to after the entire project is done
<nephele> zard: that depends /s
<CalistoMathias> ohhh that definitely does make sense
<nephele> dovsienko: I agree on that point yeah
<CalistoMathias> i guess later... there is a tendency to forget something someone might have figured out as well
<CalistoMathias> i guess ill keep a notepad handy for now to make small notes into incase i find something intriguing
* zard is thinking of doing something similar as he tries to figure out WebPositive
<CalistoMathias> gonna try giving the header file nephele mentioned a read through
<dovsienko> otherwise you learn something useful, and maybe even remember it for a while, but the next guy still has to reinvent the same wheel again
<CalistoMathias> righttt that makes sense
<CalistoMathias> btw apart from all this i had a question about the way the tracker application works
<CalistoMathias> tho its just a gneeral question
<CalistoMathias> but why is it that whenever someone tries to open a folder... it opens a new window rather than just routing inside the tracker window itself?
<OscarL> CalistoMathias: "spatial mode", some *weird* people actually like it that way :-)
<dovsienko> that's what the old BeOS did, AFAIR
<OscarL> CalistoMathias: you can change it to Single window mode, from Tracker's settings.
<Al2O3> can that be set per window, or for Tracker in general.
<zard> OscarL: haha, agreed :)
<OscarL> CalistoMathias: from any Tracher window... see the menu item: "Window->Preferences..."
humdinger has joined #haiku
<Al2O3> I can see loads of windows, tiled or not being a problem.
<Begasus> Hola OscarL, for the moment someone else can tackle PR's at haikuports, doing my own thing atm :P
<OscarL> CalistoMathias: then, under "Windows", check "Single window navigation" (and "Show Navigator" while you're at it)
<OscarL> Begasus: no problem at all :-) messing with Terminal right now myself :-D
<CalistoMathias> oh wow this helps a lot xD
<humdinger> OscarL: you changed Terminal scrolling from SHIFT+cursor to OPT+SHIFT+cursor.
<OscarL> humdinger: yup. do I need to hide from your wrath?
<humdinger> OscarL: Q: should SHIFT+Pageup/down be changed to OPT+SHIFT+Pageup/down for consistency?
<zard> It would probably be nice to make that the default for Tracker, but...
<OscarL> humdinger: OPT+SHIFT+ up/down only... for left/right... it's now OPT+left/right.
<nephele> No, It wouldn't :)
* zard shudders thinking about the huge amount of back and forth that would result
<zard> nephele: heh :)
<zard> bbl
<OscarL> sorry, missed the "scrolling" qualifier on your question, humdinger.
<OscarL> It would make sense if the defaults actually matched user expectations, and those DO change with time.
<OscarL> humdinger: will have to get back to you after I test things more. Keyboard handling between Terminal/shell/programs makes my head spin.
<humdinger> no worries :)
<CalistoMathias> also where would the definition for BColumnListView be?
<OscarL> humdinger: thanks for bringing that up, tho!
<nephele> argh, why does it AGAIN try to build the bios loader >:(
<nephele> this time i definetely commented out that line 21
<OscarL> nephele: I commented ALL of them (the ones related to boot loader).
<OscarL> "local bootTarget ;" and the 3 lines on the loop below.
<humdinger> CalistoMathias: grepping src/headers/ reveals headers/private/interface/ColumnListView.h
<nephele> humdinger: you should install ripgrep :D
<OscarL> rg is somewhat slower on my PC :-/
<humdinger> never heard of that. tbh, I mostly use TextSearch :)
<humdinger> CalistoMathias: see also https://xref.landonf.org/source/
<nephele> ripgrep is much faster than grep
<CalistoMathias> oh yah xD idk why i never think to use grep until i get reminded about it
<CalistoMathias> should note that down and keep reminding myself to use
<nephele> not sure what the speed of TextSearch is
<CalistoMathias> it
<OscarL> nephele: that's what I've heard, why I tried, and why I stoped using it. It does not for me.
freddietilley has quit [Ping timeout: 480 seconds]
<nephele> ripgrep packages a "RELEASE-CHECLIST.MD" in the documentation dir .-.
<dovsienko> waddlesplash: if you remember the sshd-related kernel crash (ticket 17508), it just reproduced on the latest nightly build and I have the kernel debugger open still. would it help to extract any diagnostics from it?
<humdinger> TextSearch is quite sow.
<humdinger> SSDs make all tolerable
* OscarL cries on slow spinnng disks on a VBox VM :-D
* humdinger watches HDDs spin round and round. round and round...
<CalistoMathias> cool imma log off for a while ... gotta finish some uni work before I can get back to working on haiku... see ya guys later :D
CalistoMathias has quit [Quit: Vision[]: i've been blurred!]
<humdinger> OscarL: what are the chances you implementing text selection with SHIFT+cursor in Terminal?
<OscarL> TextSearch just uses grep (original name was TrackerGrep)
<humdinger> truth
<OscarL> humdinger: that's why I've changed it.
<humdinger> cool!
<OscarL> it works now for mcedit and turbo editors.
<humdinger> I mean when in bash
HaikuUser has joined #haiku
<OscarL> but again, keyboard handling, in VTs... is a nightmage.
<waddlesplash> dovsienko: hm... maybe open FDs of sshd
<waddlesplash> not sure what command that is though, never poked around too much in FD tables in KDL
<humdinger> abracadabra
<OscarL> humdinger: I'd say... almost zero changes. I wouldn't even know where to start :-D
<humdinger> aww :)
<waddlesplash> dovsienko: ohh, there's two WeakPointers in the chain? that is a bit more interesting
HaikuUser has quit []
<humdinger> why doesn my vision nick notification sound work no more?
<humdinger> working for you?
<dovsienko> waddlesplash: going AFK for 15 minutes, if you send me the commands to type into the prompt, I will do that upon return
L0rdRav3n has joined #haiku
<L0rdRav3n> is this the correct place to ask for support?
wintp has quit [Ping timeout: 480 seconds]
<humdinger> L0rdRav3n: sure
<L0rdRav3n> its a clean install Ive never had my wifi work, and from what i can tell,
<L0rdRav3n> Awesome! I just reinstalled my haiku hrev57609
<L0rdRav3n> the iaxwifi200 should be supported. my syslog says KERN: iawxwifi200: could not load firmware, -2147483639
HaikuUser has joined #haiku
<L0rdRav3n> i'm running an a lenovo L15 intel
HaikuUser has quit []
<L0rdRav3n> ive done pkgman full-sync and rebooted
<humdinger> that Q goes to waddlesplash...
<waddlesplash> that error is ETIMEDOUT
<waddlesplash> this happens randomly on some hardware, I don't know why and I've never reproduced it myself
<waddlesplash> there are some open tickets about this with idualwifi7260 as well. I suspect the problem is some missing PCI init or something but I have no idea what unfortunately
<L0rdRav3n> i do have another iaxwifi200 card i can try swapping in. do you think it could be the actual card, or the system
<waddlesplash> no idea, possibly the system
<waddlesplash> I think all times it's been tested, things work on other OSes
<waddlesplash> just not Haiku
<L0rdRav3n> ok thats why i reloaded hoping it was a bad install.
<waddlesplash> maybe I can ask around among the BSDs and find out if any of them might know what we are missing...
<L0rdRav3n> the card works in debian and win10+11
<L0rdRav3n> i thought i had read that i was fixed last year, but ive still got the issue
<Begasus> 57 packages so far ... :)
<OscarL> humdinger: got some *possible* leads on text selection (from some rejected patches to Gnome's VTE, no less). No promises thou. I suck at all this :-)
<humdinger> OscarL: If you touch the Terminal shortcuts again, can you change OPT+cursor left/right for switching tabs to ALT+cursor left/right ?
<humdinger> OscarL: seeing that ALT+SHIFT+cursor left/right moves the tab.
<humdinger> would be more consistent
wintp has joined #haiku
<waddlesplash> dovsienko: ok, so, let's see if we can figure out what the address is here
<OscarL> The fact that I use "Win/Lin mode" ain't helping with my keyboard/shortcut handling induced headaches, humdinger :-)
<waddlesplash> dovsienko: you need to read a 64bit value from the address in the KDL message, and that value will be a pointer to a net_socket struct. the sockaddr should be at offset 32 from that value
<humdinger> :) replace my OPT with B_OPTION_KEY and ALT with B_COMMAND_KEY, if that helps.... :)
<waddlesplash> dovsienko: something like this: "dl 0xffff..." to get the first address, then "dw 0xffff...+32 16"
<waddlesplash> and then we can see what the address is, because if the endpoint isn't bound it should be zero-length
<OscarL> humdinger: I think PulkoMandy *did* mentioned CMD+left/right as a possible alternative (and adding them to the menu).
<humdinger> OscarL: check https://www.haiku-os.org/docs/userguide/en/keyboard-shortcuts.html#terminal to see the current shortcuts and changes fit into it.
<OscarL> humdinger: but I choose the smaller changeset, as to not screw things even more. I'm bad at this, I tell you! :-)
<humdinger> I already updated the online tool version with your changes
<dovsienko> waddlesplash: there's plenty of 64-bit addresses there, which one?
<waddlesplash> the very first one
<humdinger> OscarL: that's what code reviews are for.
<waddlesplash> dovsienko: "bound endpoint <addr> not in hash"
<humdinger> (If people get the chance to comment before its merged.)
<dovsienko> trying now...
BrunoSpr has joined #haiku
<OscarL> welp... it WAS up since Dec 27 :-P
<BrunoSpr> hello OscarL, hello all
<humdinger> OscarL: some things slip thru the cracks...
<humdinger> hullo
<OscarL> humdinger: thanks for the link to the userguide. I probably should be reading it more often :-)
<OscarL> hi BrunoSpr!
<OscarL> humdinger: yeah! no worries, just pulling your leg a bit :-)
<humdinger> leg-pulling, chain-yanking... I'm torn ;)
<waddlesplash> dovsienko: hm, is there a chance something might've tried to connect/reconnect to SSH during shutdown
<dovsienko> kdebug> dl 0xffffffff80c6de00
<dovsienko> [0xffffffff80c6de00] `sD......'Q..... ffffffff8c447360 ffffffff815127c0
<waddlesplash> I might see a path by which this can happen if so
<dovsienko> there was one interactive SSH session and one sshfs mount, which I believe to have shut down both
BrunoSpr has quit [Quit: Vision[]: Ich wurde gewaschen!]
mr_lou has joined #haiku
BrunoSpr has joined #haiku
bbjimmy has quit [Quit: Vision[]: i've been blurred!]
freddietilley has joined #haiku
<waddlesplash> dovsienko: so it's that first address that you want to then use with "dw"
<waddlesplash> ffffffff8c447360
arnavbhatt288[m] has quit [Quit: Client limit exceeded: 20000]
wintp has quit [Ping timeout: 480 seconds]
* humdinger is idle: BRB
<dovsienko> waddlesplash: you can have the first two lines of "dw 0xffffffff80c6de00+32 16" also if that helps
<waddlesplash> the first two lines will be most of the sockaddr
<waddlesplash> hm
<waddlesplash> the peer address may be more interesting
<dovsienko> let me do both
<waddlesplash> dovsienko: at offset 160 there is the peer sockaddr
<waddlesplash> can you try and interpret that, see where this socket is coming from?
<dovsienko> I wonder if anyone considered connecting the kernel debugger to a serial port, as is done in NetBSD, for instance
<waddlesplash> it already is
<dovsienko> :-O
<waddlesplash> if you use -serial stdio in QEMU you can use it that way
<waddlesplash> or open the serial console
<dovsienko> let's try this next time I start the VM
<dovsienko> for now let me transcript it from the monitor
<waddlesplash> anyway the peer sockaddr could be interesting, however, if your VM is connected via NAT then I guess it won't be
<waddlesplash> but if you've bridged it then that might be interesting indeed
<waddlesplash> i.e. what on your local network is trying to connect
<dovsienko> okay, here goes the first dw, which is not what you explained later, but in case it is useful anyway...
<dovsienko> kdebug> dw 0xffffffff80c6de00+32 16
<dovsienko> [0xffffffff80c6de20] ................ 8ad6c980 ffffffff cccccccc cccccccc
<dovsienko> [0xffffffff80c6de50] ........`.C..... cccccc00 cccccccc 8c43e660 ffffffff
<dovsienko> [0xffffffff80c6de40] ............N... 00000000 00000000 00000000 0000014e
<dovsienko> [0xffffffff80c6de30] ........8.P..... cccccccc cccccccc 8150f338 ffffffff
<L0rdRav3n> Well... just for giggles, ive swapped with 3 other iaxwifi200 cards all 3 give the same result
<dovsienko> now doing "dw 0xffffffff8c447360+32 16", stop me soon if that's not what you need
freddietilley has quit [Ping timeout: 480 seconds]
<dovsienko> L0rdRav3n: TL-WN725N works OK, if you are looking for a happy path
wintp has joined #haiku
<nephele> nowadays shooting a picture and copieng text from the image actually works fairly decent
<L0rdRav3n> thank you dov
<dovsienko> nephele: old dog, new tricks...
<nephele> that's fine. atleast we made a bigger font for the kernel debugger :D
<dovsienko> so this is the big font?
L0rdRav3n has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
<nephele> Maybe, not sure which you are seeing
<nephele> iirc it is used when your screen is bigger than 1920 wide
<dovsienko> no, it is not. that explains it. anyway, here is the second dump:
<dovsienko> kdebug> dw 0xffffffff8c447360+32 16
<dovsienko> [0xffffffff8c447380] ................ 0101fe00 00000000 00000000 00000000
<dovsienko> [0xffffffff8c4473a0] ................ 00000000 00000000 00000000 00000000
<dovsienko> [0xffffffff8c447390] `sD............. 8c447360 ffffffff cccccccc cccccccc
<dovsienko> [0xffffffff8c4473b0] ................ 00000000 00000000 cccccccc cccccccc
<waddlesplash> dovsienko: I meant 0xffffffff80c6de00+160 16
nosycat has quit [Quit: Leaving]
<dovsienko> okay...
<waddlesplash> dovsienko: eh. this doesn't look like what we want or need anyway
<waddlesplash> I might have gotten the offsets wrong
x10z has joined #haiku
<waddlesplash> assuming that first +32 16 dump above is really a sockaddr it has size 128
<dovsienko> the last one is mostly zeroes, so won't be long
<waddlesplash> not 20 as one would hope
<waddlesplash> and the family is bogus
<waddlesplash> so, that's not right
<waddlesplash> oh well
<dovsienko> kdebug> dw 0xffffffff80c6de00+160 16
<dovsienko> [0xffffffff80c6deb0] ................ 00000000 00000000 00000000 00000000
<dovsienko> [0xffffffff80c6dec0] ................ cccccccc cc000000 00000000 00000000
<dovsienko> [0xffffffff80c6dea0] M.P............. 8150f34d ffffffff 00000000 00000000
<dovsienko> [0xffffffff80c6ded0] ................ 00000000 00000000 00000000 00000000
<Begasus> have to add "cmd:doxygen >= 1.9" for KF6 (requires > 1.8.13)
wintp has quit [Ping timeout: 480 seconds]
<dovsienko> waddlesplash: it is indeed bridged
ClaudioM has joined #haiku
tqh has joined #haiku
<waddlesplash> ok
<waddlesplash> so, something could be trying to connect to port 22
<waddlesplash> during the shutdown process
<OscarL> note to self, and to humdinger: cmd.exe + clink (on windows) has *proper* SHFIT+arrows text selection while using readline for the command prompt! (too bad it relies on a lot of custom code :-/)
<dovsienko> waddlesplash: that's not impossible, although I do not see what or who would be the client
<waddlesplash> no idea either, which is why I wanted to try and find the sockaddrs
<waddlesplash> but alas these aren't the right offsets
<waddlesplash> let's see if I can find better ones
<dovsienko> even if there was an unexpected incoming connection, it ought not cause such a problem
<waddlesplash> well, of course
wintp has joined #haiku
<waddlesplash> dovsienko: can you try to test that, I guess? just set up something in a loop trying to make connections as fast as possible
<waddlesplash> and then shut down
<waddlesplash> and see if that makes the KDL happen more often
<waddlesplash> I will check some other stuff from my end
<dovsienko> waddlesplash: I can try later tonight
<dovsienko> I tried TCP-forwarding a serial port into another Haiku VM and got messages during the startup, so this can be arranged during the next VM boot
<waddlesplash> ok
<dovsienko> the crashed VM will stay in the kdebug prompt for as long as you need
<waddlesplash> ok, so actually fSocket is not at offset 0, it's at 24
<waddlesplash> so the first command should have been dl 0xffffffff80c6de00+24
<waddlesplash> then we do the "dw"
<waddlesplash> (why does my IDE think it's at 0? it should be using clang for this, why does it think something different than what the compiler says? who knows)
<waddlesplash> I also have a prospective patch, should the problem readily reproduce
<waddlesplash> I guess I can try and reproduce it here
<dovsienko> waddlesplash: I have just quickly tried 10 parallel loops running "ssh <hostname> date" and whilst it was stressing all CPU cores for reasons I do not understand, the crash did not occur in the three boot/shutdown sequences I tried. this was R1/beta4.
<waddlesplash> hm
<waddlesplash> well that's very odd then
<waddlesplash> but I guess this crash can only happen in a very narrow window
<waddlesplash> or if the network stack deinitializes oddly
<waddlesplash> I can probably make it happen artificially here
<dovsienko> kdebug> dl 0xffffffff80c6de00+24
<dovsienko> [0xffffffff80c6de18] ..0............. ffffffff8c30ec10 ffffffff8ad6c980
<dovsienko> please confirm the dw command and I may be able to do it before I have to go AFK for a while
wintp has quit [Ping timeout: 480 seconds]
<dovsienko> in seems it is the master branch Haiku VM that is busily spinning all CPU cores...
<dovsienko> the one in kdebug
HaikuUser has joined #haiku
<waddlesplash> that's expected, yeah. however they should all be in `pause` loops
<waddlesplash> at least on my machine it says 100% all cores but the fans don't spin up (anymore, after I fixed a few things)
<waddlesplash> dovsienko: dw command should indeed be dw 0xffffffff8c30ec10+160
<dovsienko> on the Linux host it counts as nearly 100% "system" time. but anyway, let me transcribe that
<dovsienko> that's just 16 bytes, correct?
<waddlesplash> that should be enough, I think?
<waddlesplash> this is a sockaddr_in after all
<waddlesplash> so it's only 12 bytes that we need
<dovsienko> kdebug> dw 0xffffffff8c30ec10+160
<dovsienko> [0xffffffff8c30ecb0] ..H.........|... 48c20120 1200a8c0 00060006 0f07057c
<waddlesplash> now that's more like it
<dovsienko> looks like 192.168.0.18 to me, which was the address from that my SSH connection was opened
humdinger has quit [Quit: Vision[]: Oi with the poodles already!!]
<waddlesplash> ok
<waddlesplash> maybe it tried to reconnect or something, idk
<dovsienko> I suppose the next step would be to capture tcp/22 until it crashes again, to see how much closed the TCP session looks on the wire
<waddlesplash> dovsienko: what about the port? can you see what the port is on the machine that opened the SSH connection
<waddlesplash> i.e. what it is in netstat or something, maybe even a PID if it's still around
wintp has joined #haiku
v_harkonnen has quit [Ping timeout: 480 seconds]
<dovsienko> by this time my Linux host does not have any TCP sockets in any state ending in 192.168.0.0/16
<waddlesplash> ok
<dovsienko> at least today we learned it reproduces on master and it indeed somehow has to do with an SSH client
<waddlesplash> yeah, it's something
<waddlesplash> well, I can commit this fix which is definitely correct but it may not solve this problem
<waddlesplash> I guess I will experiment myself with reproducing
<dovsienko> so either the socket shutdown isn't clean, or some associated data does not deinitialize properly because of a race condition or something
<waddlesplash> actually the path I found is in socket spawn
<waddlesplash> spawn fails partway through -> socket has Bound state but is not in hash -> close() panics like this
<waddlesplash> solution: properly unset bound state when spawn fails
<dovsienko> it is not uncommon to have more than one bug and to see that one bug masks or unmasks another
<waddlesplash> oh, I well know that
<waddlesplash> "spawn fails partway through" may not be unexpected during shutdown though
<dovsienko> I must leave for a while, the VM is in kdebug in case you need more hex dumps later
<waddlesplash> I won't, may as well shut it off
<waddlesplash> anyway the primary way spawn could fail is if the net stack started deinitializing, and the modules it wants to use somehow are gone before it expected
wintp has quit [Ping timeout: 480 seconds]
Anarchos has joined #haiku
<nekobot> [haiku/haiku] waddlesplash pushed 4 commits to master [hrev57610] - https://git.haiku-os.org/haiku/log/?qt=range&q=4d120bec16ba+%5Eb3a7feb16884
<nekobot> [haiku/haiku] 9c274ccd098e - Document new rgb_color apis, apply their usage.
<nekobot> [haiku/haiku] d260dfde10f7 - Tests: fix app/messaging compile
<nekobot> [haiku/haiku] f3fc706a688c - Tests: Disable PPP tests
<nekobot> [haiku/haiku] 4d120bec16ba - Tests: fix kit/interface/GetMouseTest
wintp has joined #haiku
<nephele> hmm, libprint in AboutSystem has no license mentioned
<nephele> is that a bug?
wintp has quit [Ping timeout: 480 seconds]
<Anarchos> hello
<nephele> hi Anarchos
kinkinkijkin has joined #haiku
<OscarL> nephele: shouldn't we use the B_PRIxxx constants instead of "%ld" and such? (looking at your GetMoustText.cpp fixes.
* OscarL waves at Anarchos.
<nephele> OscarL: what is B_PRI? I only fixed those because gcc complained about %lld and suggested %ld instead
<nephele> I only know BStrings formatting apart from that
<OscarL> See SupportDefs.h ("B_PRIx32", and family)
<Anarchos> OscarL hello
<Anarchos> OscarL you are right for B_PRIXXX
<OscarL> mmm a tin roof on a heavy summer rain.... I'm going deaf :-/
<nephele> I don't really know, it seems to be "just" a different way to write the same thing?
hightower3 has joined #haiku
<OscarL> nephele: example of a similar change I did (but following lots of examples I found earlier): https://review.haiku-os.org/c/haiku/+/6044
<OscarL> I think the issue is on how int32 is defined for 32 bits?
<botifico> [haiku/infrastructure] kallisti5 pushed 1 commit to master [+1/-0/±0] https://github.com/haiku/infrastructure/compare/c1030195d3e6...de2e7439541e
<botifico> [haiku/infrastructure] kallisti5 de2e743 - tools: Add a script to take an inventory of HaikuPorts repo hashes
wintp has joined #haiku
v_harkonnen has joined #haiku
<OscarL> btw, I'm asking just to learn.
hightower4 has quit [Ping timeout: 480 seconds]
Anarchos has quit [Ping timeout: 480 seconds]
<nephele> Well. I honestly don't know
<nephele> maybe waddlesplash has an answer :g
<augiedoggie> "long" changes sizes between 64 and 32 bit, so you need a macro to account for that
mr_lou has quit [Remote host closed the connection]
mr_lou has joined #haiku
wintp has quit [Ping timeout: 480 seconds]
tuaris has joined #haiku
HaikuUser has quit [Quit: Vision[]: i've been blurred!]
<nekobot> [haiku/haiku] waddlesplash pushed 1 commit to master [hrev57611] - https://git.haiku-os.org/haiku/log/?qt=range&q=da24b14bf281+%5E4d120bec16ba
<nekobot> [haiku/haiku] da24b14bf281 - FlatControlLook: build fix
wintp has joined #haiku
<OscarL> for bigtime_t there's even B_PRIiBIGTIME :-)
<nephele> oh okay. I'm not sure if i needed that for the GetMouseText.cpp fixes
<OscarL> (I should remember those type-spefic ones more often)
Calisto has joined #haiku
<nephele> hmm, is there something more i could make a patch for now :3
wintp has quit [Ping timeout: 480 seconds]
wintp has joined #haiku
BrunoSpr has quit [Quit: Vision[]: Ich wurde gewaschen!]
BrunoSpr has joined #haiku
BrunoSpr has quit []
BrunoSpr has joined #haiku
BrunoSpr has quit []
<Calisto> Btw in general when does a second reviewer review a commit?
<Begasus> The first time he checks it?
<nephele> depends on the commit, not every reviewer knows every system component
<nephele> you can bet that I will skip any commit that touches the posix memory api for example :D
<zard> Sometimes takes a while, like several days
<nephele> I'm having reverse vi syndrome. I remember starting with linux and panicking when i couldn't get out of vi
<nephele> now i'm panicking when git gives me nano and it *doesn't* behave like vi
<Begasus> you can change that I think? (vi - nano)
<Calisto> Real xD
<Calisto> I was having the same issue
<Calisto> I kept typing esc + :wq in nano that day xD
<Begasus> 87 packages ... still on the frameworks :)
<nephele> the more you package the more somebody will say "but why is N not packaged?"
<Begasus> these are just the basics (already got plenty more there) :)
<Begasus> 108 for 5.114.0
<Begasus> first app I want to check is neochat 24.02.0
wintp has quit [Quit: WeeChat 4.2.1]
CalistoMathias has joined #haiku
<CalistoMathias> @nephele so like i was saying before
<CalistoMathias> I know this is a really stupid fix but I was just trying it regardless ... will spend time reading the exact definitions of everything... but basically in the source file of the DevicesViews.cpp, there is a BTab which contains a PropertiesView .... I just tried Adding that PropertyView directly to the Split Layout Builder
<CalistoMathias> but this causes a crash in the app
* OscarL is a total heretic, and is trialing `git config core.editor` set to `tvedit` for HaikuPorts, and `turbo` for Haiku repos.
<zard> CalistoMathias: I have some suggestions... but, unfortunately, not enough time left to discuss them today
<CalistoMathias> oh that's quite alright
<CalistoMathias> if possible then do list them down... otherwise ill be back online tomorrow as well :)
<CalistoMathias> what time zone are you in?
<zard> UTC-5
<zard> One quick suggestion is the Debugger might give you more information about the crash
<CalistoMathias> oh okay ....
<CalistoMathias> ive never used it but ill give it a try i guess
<CalistoMathias> wouldn't hurt to learn how to use it I guess :)
<zard> The crash report would work nearly as well
<nephele> CalistoMathias: I already said to investigate the crash?
<CalistoMathias> yah I was trying to read the file
<CalistoMathias> i generated the report
<CalistoMathias> but i have no idea how to read this thing :I
<CalistoMathias> :( *
<CalistoMathias> i guess ill try figuring out something :(
<nephele> well, you can upload it to for example 0x0.st if you want others to look at it
<CalistoMathias> oh okay that would help a lot
<nephele> but with no idea what you changed, and only a vague "it crashes" i can't help you
<CalistoMathias> yah ... but basically in the source code where it renders the fTabView ... i removed that and instead directly tried to add the PropertiesView as a child to split layout builder
<CalistoMathias> but doing so makes it crash for a reason that I do not understand
<nephele> the description does not help me, either upload your change somewhere (maybe WIP flagged on gerrit) or send the debug report :)
<CalistoMathias> oh okay cool ill just upload it give me a minute
zard has quit [Quit: leaving]
<CalistoMathias> i uploaded the debug report on this link
<CalistoMathias> if you could understand what is going wrong it would be a great help :)
<nephele> that's assembly output, so you are not compiling with debug symbols :g
<nephele> can you put the code on gerrit with the WIP flag? I think that is easier
<CalistoMathias> oh okay fine
<nephele> (then i could also download it and try myself)
<CalistoMathias> so i should just create a commit and push it with an extra flag?
<CalistoMathias> cool
<CalistoMathias> just give me a minute
<CalistoMathias> ill do that
OscarL has quit [Read error: Connection reset by peer]
HaikuUser has joined #haiku
CalistoMathias has quit [Ping timeout: 480 seconds]
CalistoMathias has joined #haiku
<CalistoMathias> heyyy
<CalistoMathias> sorry i had an internet connection issue
<CalistoMathias> @nephele nevermind that issue i realised what I was doing wrong
<nephele> :)
<CalistoMathias> I fixed the ticket i guess.... the reason for the crash was because i was commenting out the unneeded lines of code...
<CalistoMathias> but the same variables were being referenced in another section
<CalistoMathias> but i got it fixed
<CalistoMathias> :D
<nephele> Then make a review on gerrit, I'm still awake now to review a bit
<CalistoMathias> yup ill push it to gerrit
<CalistoMathias> one sec
mr_lou has quit [Quit: Leaving]
v_harkonnen has quit [Remote host closed the connection]
<CalistoMathias> yup its rebasing
Begasus_32 has quit [Quit: Vision[]: Gone to the dogs!]
<CalistoMathias> counting objects takes so long :(
v_harkonnen has joined #haiku
<CalistoMathias> okay it worked
<CalistoMathias> but it did something weird with my old commit
<CalistoMathias> is that a problem??
<nephele> I have no idea what "something weird" means
<nephele> i dont see your review yet
<CalistoMathias> idk i did the rebase and the push and it uploaded a patch set 3 on my other commit
<CalistoMathias> saying that i rebased patch set 2
<CalistoMathias> i mean it didn't really change the commit or anything
<CalistoMathias> but it changed the time of the commit
janjo has joined #haiku
<CalistoMathias> i have no idea why... i did the exact process as yesterday.... like how OscarL guided me... i created a new branch on my system made the commit on that branch ... rebased and pushed
<CalistoMathias> i guess its fine?
janjo has quit [Remote host closed the connection]
<CalistoMathias> im really sorry :(
<nephele> Wow, i was just afk for a bit. No need to apologize!
<nephele> Don't worry, you didn't do anything wrong :)
<CalistoMathias> oh okay thank god :D
<CalistoMathias> so the other commit was supposed to be modified that way?
<nephele> what happend is basically this: You now have two commits above master which are not yet merged, when pusshing gerrit will consider all local commits you still have with change-ids
<nephele> so it found both, and since it is rebased, it updated both commits
<nephele> the review for your old commit was only rebased. That wasn't neccesary but it isn't harmfull either
<CalistoMathias> oh okay
<nephele> if you want to avoid that you have to be on a branch that only has the patches you actually want to push iirc
<CalistoMathias> oh okay
<nephele> or maybe there is some more magic to the git push command i dont know
<CalistoMathias> i probably need to read a bit more on how that rebase thing works properly
<CalistoMathias> tho i get the basic idea of it
<CalistoMathias> but still
<CalistoMathias> i mean this issue fix didn't need much other than deleting and retyping a few lines of code so :)
<nephele> that's not really the issue though. Even small changes require work if you are unfamiliar with our tooling :)
<CalistoMathias> oh okay :)
<CalistoMathias> btw i didn't really understand the commnet
<nephele> see above, you panicking over gerrit. (but don't worry, even if you somehow manage to majorly screw up your reviews, nobody will be angry)
<nephele> what comment?
<CalistoMathias> you wrote that the whitespacing was an issue? I didn't get what that meant?
<CalistoMathias> is it in the file?
<CalistoMathias> like the indentation thing that I made or something like that?
<nephele> It is an in-line comment based on a specific line number
<nephele> it points to a change where you removed a single space in the line after a comma ;)
<CalistoMathias> ohhh
<CalistoMathias> between the number and the thing
<CalistoMathias> oh got it
<CalistoMathias> so i need to edit that space back in and recommit?
<CalistoMathias> like ammend the commit
<CalistoMathias> amend*
<CalistoMathias> okay ill just do that
<CalistoMathias> also could you just tell me what thing I should be doing exactly to prevent that extra rebasing from happening in the other commit?
HaikuUser2 has joined #haiku
<CalistoMathias> for now ill just repeat the same thing
HaikuUser2 has quit []
<nephele> you can remove it from your local checkout
<CalistoMathias> the previous commit you mean?
<nephele> for example with "git rebase -i HEAD~3" and then delete the line that picks it
<nephele> yeah
<nephele> you can also re-order them with rebase -i
<nephele> I also commented on the other change for a whitespace issue :)
<nephele> you could try fixing this one first, ammending. then switching them, fixing the other one. and commiting both
<nephele> err, not commiting. pushing them :)
<CalistoMathias> so now there are two comments on the commit?
<nephele> No. you have two reviews, i commented on the other one aswell
<nephele> there is an extra tab there
<CalistoMathias> oh okay in the other review
<CalistoMathias> got it
<CalistoMathias> okay ill fix both of them
<CalistoMathias> i guess i need to give the styleguide a re-read xD
<nephele> you can configure most editors to highlight trailing whitespace
<nephele> though Koder is really slow with large files if you do this :(
flag_ has joined #haiku
<CalistoMathias> oh okay
<CalistoMathias> i was using the inbuilt Pe editor
<CalistoMathias> for making changes as of now
<CalistoMathias> don't know why but the UI was just really comfortable
<CalistoMathias> :D
<nephele> that's fine. Use whatever Editor you are compfortable with
<nephele> anyway, I'll review your fixed versions tommorow. Unless someone beats me to it. You can if you uploaded the new changes use the "Done" function on my comments to indicate that you adressed the critique
<nephele> have a good night
<CalistoMathias> thank you so much @nephele
<CalistoMathias> for all the help :)
<CalistoMathias> good night
<CalistoMathias> ill fix the spacing issues
<CalistoMathias> on both
<nephele> (why do you keep putting an @ before my name?)
<CalistoMathias> and recommit
<CalistoMathias> aaah i should probably stop with that... actually I was using an IRC chat app on my mobile phone which uses @ to search through usernames... and I was on discord before that so like tagging people was done with @
<nephele> no problem :)
<CalistoMathias> but i should probably stop that xD
<nephele> @name on irc usually means "that person has ops"
<CalistoMathias> btw one last thing before you go
<CalistoMathias> like if I want to amend a commit with a specific id
<nephele> you can mention people without @, it will just check if the name appears in the message
<CalistoMathias> what exactly do I do?
<CalistoMathias> git commit --amend <id?>
<CalistoMathias> i thought ill amend both the commits right now
<CalistoMathias> and push it both at once?
<CalistoMathias> is that possible too?
<CalistoMathias> or do I have to do it one by one
<nephele> git commit --amend will ammend the top commit
<CalistoMathias> yup
<nephele> so what you can do: Make the change for the commit that is the current top commit (i.e HEAD), then use git commit --amend to change it
flag has quit [Ping timeout: 480 seconds]
<CalistoMathias> yup that's what I did just now
<nephele> afterwards use git rebase -i HEAD~2 and change the order of the last two commits in the list
<CalistoMathias> oh so it puts it to the HEAD
<nephele> then fix the second commit with git commit --amend
<CalistoMathias> and then i again do the same thing
<CalistoMathias> and commit
<CalistoMathias> rightttt
<nephele> and then push poth
<CalistoMathias> that makes sense
<CalistoMathias> oh rip the push both thing :(
<CalistoMathias> shooot i pushed one
<CalistoMathias> should I cancel it
<nephele> :)
<CalistoMathias> before it goes through completely?
<CalistoMathias> its just counting the objects as of now anyways
<CalistoMathias> so ill cancel it and do what you said
<nephele> Doesn't matter, you can cancel it if you want
<nephele> or you can continue
v_harkonnen has quit [Ping timeout: 480 seconds]
<nephele> You can also use "git help <command>" to view the help page of git as html, though it sometimes is not that helpfull. but it will list all options and what they are supposed to do
<CalistoMathias> oh okay
<CalistoMathias> wait just a last doub
<CalistoMathias> i know you need to go but just if you could help with this last bit :)
<CalistoMathias> so i did the git rebase -i HEAD~2
<CalistoMathias> it opened up an editor and its my first time using this specific git command....
<CalistoMathias> what exactly am I supposed to do?
<nephele> at the top it will say "pick <commit>"
<Begasus> k, done for today, although not perfect, can now use NeoChat 24.02.0 with KF6 :) https://0x0.st/HRVh.0.png
<CalistoMathias> yup so i just uncomment that line out?
<nephele> Reorder those two lines
<nephele> so the change you want to work on now should be on the bottom of those
<CalistoMathias> oh okay
<nephele> if you delete the line you will remove the commit from your branch
<CalistoMathias> ohhhh rip no
xet7 has joined #haiku
<nephele> If you did that it's not that tragic. Just go back to the review on gerrit that has the commit you wanted to work on, click the Download button and pick the line for "Cherry-pick"
<CalistoMathias> okay cool thanks for all the help nephele
<Begasus> closing down here, cu peeps!
Begasus has quit [Quit: Vision[]: i've been blurred!]
<nephele> :)
<nephele> night
<CalistoMathias> good night :)
nephele has quit [Quit: Vision[]: i've been blurred!]
<dovsienko> .back
<dovsienko> waddlesplash: so, I am resetting the VM to attach the serial port and to set up a packet capture for future diagnostics
CalistoMathias has quit [Ping timeout: 480 seconds]
coolcoder613_32 has joined #haiku
freddietilley has joined #haiku
tqh has quit [Quit: Leaving]
freddietilley has quit [Ping timeout: 480 seconds]
HaikuUser2 has joined #haiku
freddietilley has joined #haiku
HaikuUser2 has quit []
v_harkonnen has joined #haiku
OscarL has joined #haiku
Anarchos has joined #haiku
DKnoto has quit [Ping timeout: 480 seconds]
freddietilley has quit [Ping timeout: 480 seconds]
HaikuUser2 has joined #haiku
<coolcoder613_32> Good morning
HaikuUser2 has quit []
<andreasdr[m]> Hi there.
* OscarL extends his formal salutations to Mr. andreasdr[m] and Mr. coolcoder613_32.
kinkinkijkin has quit [Quit: Leaving]
v_harkonnen has quit [Ping timeout: 480 seconds]
Anarchos has quit [Quit: Vision[]: i've been blurred!]
x10z has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
vezhlys has quit [Remote host closed the connection]
mmu_man has quit [Ping timeout: 480 seconds]
hightower3 has quit [Remote host closed the connection]
hightower3 has joined #haiku
<nekobot> [haiku/haiku] waddlesplash pushed 1 commit to master [hrev57612] - https://git.haiku-os.org/haiku/log/?qt=range&q=629f071bb906+%5Eda24b14bf281
<nekobot> [haiku/haiku] 629f071bb906 - pci: extend MSI interrupt vector number to 32 bits
<nekobot> [haiku/haiku] waddlesplash pushed 1 commit to master [hrev57613] - https://git.haiku-os.org/haiku/log/?qt=range&q=b005f8c9753e+%5E629f071bb906
<nekobot> [haiku/haiku] b005f8c9753e - DeskCalc: Fix expressionView text color
<nekobot> [haiku/haiku] waddlesplash pushed 2 commits to master [hrev57614] - https://git.haiku-os.org/haiku/log/?qt=range&q=d62ce6347f8c+%5Eb005f8c9753e
<nekobot> [haiku/haiku] ffa42ceaf70c - MediaPlayer Settings: Fix Misalignment Issue for 2nd and 3rd Checkboxes
<nekobot> [haiku/haiku] d62ce6347f8c - Device Tab View: Remove Unnecessary Tab View By Replacing it with required Properties View
mmu_man has joined #haiku
<nekobot> [haiku/haiku] waddlesplash pushed 1 commit to master [hrev57615] - https://git.haiku-os.org/haiku/log/?qt=range&q=8da8973460f3+%5Ed62ce6347f8c
<nekobot> [haiku/haiku] 8da8973460f3 - iaxwifi200 & idualwifi7265: Port a fix from OpenBSD.
<OscarL> Calisto: congrats on landing your first TWO patches! :-)
<OscarL> how come that botifico shows both the commiter *and* the patch author, but nekobot only the commiter?
Calisto has quit [Ping timeout: 480 seconds]
<andreasdr[m]> Hi OscarL
<OscarL> Famous pirate lag still there, I see, yarrr!
HaikuUser has quit [Quit: Vision[]: i've been blurred!]
HaikuUser has joined #haiku
HaikuUser has quit []
ClaudioM has quit [Quit: leaving]
hightower3 has quit [Remote host closed the connection]
hightower3 has joined #haiku