zardshard has left #haiku [Error from remote client]
zardshard has joined #haiku
Yoke has quit [Quit: Vision[]: i've been blurred!]
BrunoSpr has joined #haiku
<nipos>
Is B_STIKEOUT_FACE of BFont not yet implemented in Haiku?
<myriad>
Hello everyone! myriad here. Looking forward to contribute to Haiku and connecting with you all
<nipos>
Hello
<myriad>
i am stuck at a problem while trying to get the source code of Haiku, can anyone please help me with it?
<nipos>
What is the problem exactly?
<myriad>
i was following the instructions given on the website when i got to the part where we were asked to add and verify the email address that we use for commits to our gerrit account
<myriad>
i use the noreply.github.com email address for commits, so i cant verify that
<nipos>
myriad: Use your normal email address instead.Haiku development doesn't take place on M$ Github
<nephele_xmpp>
myriad: If you want to login with github then use the github login instead
<nephele_xmpp>
don’t put fake email adresses into email fieldss
<nipos>
nephele_xmpp: Thanks for the commit.Implementing B_STRIKEOUT_FACE in a similar way should be easy,I think,let me try...
<nephele_xmpp>
Feel free to ask if you need more pointers :)
<myriad>
nipos: yeah, i am new to gerrit so i was setting it up. But when i was setting git locally for the first time, i read that we should not use our normal email address here in the git config file. So i ticked the "keep my email address private" option on github and github then gave a private email address of the format "123456789+username@users.noreply.github.com" which i have been using since
<nipos>
It was somewhat funny how the attribute is correctly preserved and sent over AIM to the Windows machine that displays it right,but on Haiku it appears as normal text lol
<nipos>
myriad: If you fear spam,you can use a second email address that you don't keep as private as your normal one.We even have a Haiku Mail provider at https://haikumail.online (run by a community member,not Haiku itself).Using nonsense/noreply addresses isn't that great,I
<myriad>
nipos: I see, will look into it.
<nephele_xmpp>
myriad: where are you tryingg to verify this email adress?
<nephele_xmpp>
i am using severall different ones for gerrit, so the git config one having to be the same makes no sense to me
<nephele_xmpp>
show the guide and what step you are on, please
<myriad>
nephele_xmpp: There was always some error, and the "ssh -vT $USER@git.haiku-os.org" command says permission denied. But I have already tried many times to set the correct ssh key on my gerrit acc. but there's always some issue.
<myriad>
Sorry, i was going to link the guide next, but accidentally pressed enter
<nipos>
Downloading the source does not requiring authentication,only uploading changes does
<nipos>
Also,you don't use git.haiku-os.org since that's read-only,but review.haiku-os.org
<myriad>
nephele_xmpp: I am probably wrong to think that the email address verification is causing the issue, that was just one of the ways i was trying to solve the issue after trying other things
<nephele_xmpp>
myriad: yes it is, but if you clone via ssh too you will have to use your key every time to clone, and if that has a password enter it each time, that is why for my copies i always configure push for ssh and pull for https :) but yes you can use ssh for both
<nephele_xmpp>
did you change $USER to whatever your gerrit user is as the guide implies to do?
<nephele_xmpp>
also: “Make sure your SSH key is generated using ed25519. RSA keys will not work with Gerrit.”
<nephele_xmpp>
atleast, it didn’t work for me with any rsa keys, hence why i wrote that warning
<nephele_xmpp>
I’m confused where you got your ssh line from anyhow, there are two sections on how to clone the repo and install the git hook
<myriad>
nephele_xmpp: yes I changed it my username and I made sure that I am using the ed25519 generated ssh key. But it still says permission denied
<nephele_xmpp>
did you give the ssh line your key with -i or adjusted the ssh config to mention that this key is needed for this host?
<myriad>
Yeah, did that too
<dovsienko>
nephele_xmpp: 1. that's what ~/.ssh/config (or the Haiku equivalent) is for; 2. that's what ssh-add and ssh-agent are for
<nephele_xmpp>
dovsienko…. yes? that’s why i mentioned it...
<nephele_xmpp>
ssh-agent is your own choice to use, i’m not going to use it, i *still* need to enter my password for pulling after i start my computer, and i simply don’t want to
<nephele_xmpp>
myriad: I’m confused a bit. Did gerrit accept the key you uploaded?
<myriad>
nephele_xmpp: yes, I also the mail regarding that
<myriad>
For surity, I deleted it and uploaded it once more
<myriad>
But everything remains same
<nephele_xmpp>
so with gerrit having the correct key configured, and you supplying the ssh key to the correct server it’s still denied? hmm, at this point I am a bit stumped to be honest
<nephele_xmpp>
maybe another developer has an idea, if you want you can file a bug against gerrit on https://dev.haiku-os.org
<nephele_xmpp>
in your case I’d clone via https for now so you can work on what you wanted to work on, reconfiguring the repo to use ssh is quite easy later with “git remote”
<nipos>
I'm currently rebuilding app_server with support for B_STRIKEOUT_FACE in fonts.Can I replace the running app_server process with my self-built one without crashing everything?I think I can't,right?
<myriad>
I see, will take your advice and clone via https for now. Atleast I would be able to start
<nipos>
I mean,LD_PRELOADing my own libbe.so will not be sufficient to notice any changes if the change is in app_server,if I'm not completely mistaken?
deneel has quit [Remote host closed the connection]
myriad has left #haiku [#haiku]
Halian has quit [Quit: I'll be back.]
Halian has joined #haiku
<nephele_xmpp>
yes, put it into non-packaged, blacklist the other one, and reboot
<nephele_xmpp>
sadly live restarting doesn’t work yet
x10z has joined #haiku
<nipos>
Thanks for confirming,I assumed something like that
<nipos>
I'll simply rebuild haiku.hpkg locally,that makes it easier to undo my mess by installing a repo version again.Building the whole OS takes a lot of time,but it's 25% done already
freakazoid332 has quit [Ping timeout: 480 seconds]
BrunoSpr has quit [Quit: Vision[]: Ich wurde eingeweicht!]
BrunoSpr has joined #haiku
dalme has joined #haiku
<nephele_xmpp>
deleting a file from non-packaged is not that hard, but yes rebuilding it works too
HaikuUser has joined #haiku
HaikuUser has quit []
MisthaLu has joined #haiku
Halian has quit [Quit: I'll be back.]
Halian has joined #haiku
Halian has quit []
Halian has joined #haiku
BrunoSpr has quit [Quit: Vision[]: Ich wurde eingeweicht!]
Halian has quit [Quit: I'll be back.]
Halian has joined #haiku
Halian has quit []
dalme has quit [Ping timeout: 480 seconds]
diver has joined #haiku
Halian has joined #haiku
hoanga[m] has joined #haiku
Halian has quit [Quit: I'll be back.]
Halian has joined #haiku
Halian|Jardin has joined #haiku
cp- has quit [Ping timeout: 480 seconds]
BrunoSpr has joined #haiku
x10z has quit [Quit: My Unrecognized Mac has gone to sleep. ZZZzzz…]
cp- has joined #haiku
x10z has joined #haiku
<nipos>
I forgot to checkout origin/master after my last change (that is already merged).Is it a problem that it's now shown as a relation chain on Gerrit?
x10z has quit [Quit: My Unrecognized Mac has gone to sleep. ZZZzzz…]
Anarchos has joined #haiku
<Anarchos>
i lost 8€ in a silly way :/
<Anarchos>
i bought an adapter for my PS2 purple keyboard to usb male.
Halian|Jardin has quit [Quit: I'll be back.]
Anarchos has quit []
HaikuUser has joined #haiku
<phschafft>
... so?
Anarchos has joined #haiku
HaikuUser has quit []
thesynthax has quit [Ping timeout: 480 seconds]
<Halian>
Of course they left immediately :(
piusbird has quit [Remote host closed the connection]
jmairboeck has joined #haiku
<gordonjcp>
Halian: who did?
<Halian>
Anarchos
* phschafft
points to Anarchos in the nick list.
<Anarchos>
Halian i just reboot to confirm a thing in my bios
<Anarchos>
i wrote passive PS2 --> usb adapter, and of course no option in bios or whatever to make it works
<Halian>
I missed you rejoining right before I said that >w<
<Halian>
Sorry
<Anarchos>
i should have read carefully before
dru_satori has joined #haiku
diver has quit [Quit: Leaving.]
<Skipp_OSX>
well 8€ is the price of lesson learned
<Anarchos>
Skipp_OSX :)
<nipos>
Skipp_OSX: Should I remove the commented out code for underscores also or only for the new strikeout?
<Skipp_OSX>
both
<Skipp_OSX>
We try to keep code free of these commented out code blocks as much as possible but the agg renderer doesn't get touched much.
<nipos>
Thanks,done,it's uploading
xet7 has joined #haiku
BrunoSpr has quit [Quit: Vision[]: Ich wurde eingeweicht!]
HaikuUser has joined #haiku
HaikuUser has quit []
<Skipp_OSX>
For my first suggestion, it looks like AGGTextRenderer::RenderString is the consumer of StringRenderer and that's where a bitmap flags array could get created. Looks like it's creating all the bools there anyway.
<Skipp_OSX>
We can leave that up to future revision I suppose. I could write the code but don't want to hold up progress.
<Skipp_OSX>
The strikeout portion of what you did looks good, it's the code that surrounds it that needs work and that's not your fault.
<nipos>
I understand what you mean and I think I could do that with some try-and-fail,but it sounds more complicated than what we have right now
<Skipp_OSX>
Well the benefit would be you don't have to add another parameters next time.
<Skipp_OSX>
just tack on to the flags bitmap, I called it array but that's not the correct word.
<Skipp_OSX>
or something like that, actually it would take a bit more than that because you'd have to setup all the options as powers of 2 in a table
<nipos>
Funnily,something like that is already in use in BeAIM where I make use of the strikeout code and noticed that it doesn't actually work.
<Skipp_OSX>
yeah... well underscore didn't work either before...
<nipos>
I think I could really do that,but then it's probably better to make it a separate commit at least as it's not specifically about B_STRIKEOUT_FACE anymore
<Skipp_OSX>
yeah true
<Skipp_OSX>
more food for thought
<Skipp_OSX>
pretty much every time you're adding a bunch of bool params to a function you're doing it wrong, but again, you didn't write this but inherited it.
<nipos>
I'll look into refactoring this the next days (tuesday probably)
MisthaLu has quit [Quit: Leaving]
AlienSoldier has joined #haiku
<Skipp_OSX>
I wonder if we can make it so that you can submit a change from Gerrit if you get 2 separate +1's on a patch instead of only on a +2.
<Skipp_OSX>
Who controls the project.config file? I assume must be on a server somewhere
diver has joined #haiku
<nipos>
There's probably a reason that there's a +2 required.I just noticed there's a problem with my change that would have resulted in weird bugs
dalme has joined #haiku
dodo75 has quit [Quit: Vision[]: i've been blurred!]
FreeFull has quit []
<nipos>
That's a difficult one,no idea honestly.I can't use b.top because that may be different for each char,but it's also not safe to assume that top is 0,since it's probably not using relative chars (assuming top=0 resulted in no visible line at all).And I don't think any additional coordinates are given.
<nephele_xmpp>
Skipp_OSX: that’d change the semantics of +1. and anyone can give +1 not only devs
<nephele_xmpp>
And to be honest: nothing is stopping you from *submitting* a change that has two seperate +1, you simply have to press the +2 button and then submit it
Begasus has quit [Quit: Vision[]: i've been blurred!]
vdamewood has quit [Quit: My Unrecognized Mac has gone to sleep. ZZZzzz…]
HaikuUser has joined #haiku
HaikuUser2 has joined #haiku
HaikuUser2 has quit []
HaikuUser has quit [Remote host closed the connection]
bbjimmy has quit [Read error: No route to host]
B2IA has quit [Quit: Vision[]: i've been blurred!]
B2IA has joined #haiku
x10z has joined #haiku
FreeFull has joined #haiku
B2IA has quit [Quit: Vision[]: i've been blurred!]
B2IA has joined #haiku
<Skipp_OSX>
I still think two +1's should be submittable, 1 is not enough but if you get 2 then submit, +2 is a tougher ask
OrangeBomb has joined #haiku
<waddlesplash>
Skipp_OSX: why? it just requires one of the devs to give it
<waddlesplash>
you are a dev, you can give it :P
<Skipp_OSX>
I need somebody to test shortcuts patch makes sure it doesn't break anything...
<waddlesplash>
ask diver again I suppose
<waddlesplash>
just CC him on the patch itself, probably?
<Skipp_OSX>
humdinger was testing before but I don't think he's around
jmairboeck has quit [Quit: Konversation terminated!]
<Skipp_OSX>
I think it's ready to go now, there were a couple issues though that I fixed.
<waddlesplash>
well, let's ask diver to give it a pass and see
<Skipp_OSX>
ok
x10z has quit [Quit: My Unrecognized Mac has gone to sleep. ZZZzzz…]
x10z has joined #haiku
<dru_satori>
waddlesplash I have adjusted that header, but it looks there is now a conflict with an additional change.
mikezt has quit [Quit: ret]
<dru_satori>
or apparently, git failed to pickup the change on the commit.
x10z has quit [Quit: My Unrecognized Mac has gone to sleep. ZZZzzz…]
x10z has joined #haiku
<dru_satori>
apparently, I'm too dumb to use git. the code is changed. git commit sees the file is changed locally. git push doesn't push the change.
HaikuUser has joined #haiku
HaikuUser has quit []
<phschafft>
have you added the change?
<dru_satori>
yes, diff shows the change.
<dovsienko>
when I was learning git, it turned out way less difficult when I started using gitk to verify the actual commit history is what I thought it to be
<dru_satori>
I've been using git for years, but not from the command line, so I'm out of practice, but this is just stuff being stupid
<dovsienko>
"git log --graph" would be similar, but not as readable. I imagine there is a number of other GUI tools that can display the directed graph properly
<dru_satori>
( it doesn't help that my source tree currently also includes other changes that I have to pull out because I thought this was done )
<phschafft>
dru_satori: does git diff --cached show it?
<nephele_xmpp>
Skipp_OSX: still don’t see the issue, anyone who *can* submit patches can also provide the +2 required for it. If you want to submit it based on two +1s, you can do so. The only thing that doesn’t work is ignoring a -2 (on gerrit), unless you push directly
Anarchos has quit [Quit: Vision[]: i've been blurred!]
<dru_satori>
my irritation with git has rapidly climbed this evening, and my patience is at an end with it.
<dru_satori>
despite my telling git to not stage the additional files for the network drive, it did., and my irritation and patience is shot
<dru_satori>
( and yes, this was using git-gui )
<waddlesplash>
not sure how one can get confused in git-gui here
<waddlesplash>
the first files box is unstaged and the second is staged
<waddlesplash>
pretty easy to see what is in them when you commit
<nephele_xmpp>
I always check git status for a commit, or git diff or git show HEAD etc
<waddlesplash>
yes
<nephele_xmpp>
waddlesplas: fwif I talked about proposal (in regards to hiring) in IRC here, not sure what other public venues would be expected. But then there isn’t a faq entry on this either ;)
<waddlesplash>
mailing list
<waddlesplash>
IRC is ephemeral, this is not the place to discuss really serious proposals
<waddlesplash>
but like I said, they don't have enough donations every year to pay my contract usually, so another will just drain savings even faster
<nephele_xmpp>
if you don’t mind me asking, how many hours do you have in your contract you can work?
<nephele_xmpp>
(per week)
<dovsienko>
"can work" and "will be paid for" are not the same
<waddlesplash>
nephele_xmpp: you can go read the mailing list archives, at maximum hours for a year I would be paid around $75k
<waddlesplash>
the Inc. routinely gets only around $30k in donations a year recently
<nephele_xmpp>
your proposal doesn’t say anything about hours, only 3-4 days per week
<dovsienko>
NetBSD aims to get $50000 per year, but they have many developers
<dovsienko>
(ones that contribute at their own cost, that is)
<dovsienko>
in my experience, keeping FOSS development sustainable is an art that few master
<dovsienko>
in 1990s, when PCs started to become commonplace, the effect of switching to computers from desk calculators and paper spreadsheets was so good that many employers didn't care how many hours you had to spend fixing a bug in an open source software you need for the job
<dovsienko>
in 2000s, when the Internet started to join software and people en masse, this attitude sustained or didn't decline much
<dovsienko>
roughly at the time when smartphones became commonplace, the attitude started to became more like "every man for himself"
<nephele_xmpp>
waddlesplash: anyhow, thanks for the pointer. I might send a proposal again to the Mailing list. That obviously doesn’t change the financial situation though, but perhaps it will change in the future regardless. :)
x10z has quit [Quit: My Unrecognized Mac has gone to sleep. ZZZzzz…]
<dovsienko>
year 2020, somewhat unexpectedly, was different because people started to have more time (and fewer paid jobs) and to realise that life does not reduce to taking as much as one can, there is also meaning in giving back