<OscarL>
Note to Begasus: KeePassXC 2.6.2 started without issues for me on an up-to-date beta4 32 bits. (I have installed_ libpcre 8.45-3, libpcre_x86 8.45-3, libpcre2 10.39-3, and libprce2_x86 10.43-1)
<EncryptedUnicorn>
hey there! finally installed haiku on bare metal again after many years - and everything works so far, i'm impressed. awesome work :D
<OscarL>
Always nice to hear from returning (and happy) users :-)
<OscarL>
(spoken as one of those myself)
L0rdRav3n has quit [Ping timeout: 480 seconds]
L0rdRav3n has joined #haiku
<EncryptedUnicorn>
yay! wifi has pretty much always been an issue before, so I kept it to VMs whenever I was curious. now it works on this laptop! (beta 4) only crash I had so far was when I accidentally disconnected a flash drive seemingly before unmounting was done hmmm
zard has joined #haiku
Oscar-L has joined #haiku
L0rdRav3n has quit [Ping timeout: 480 seconds]
OscarL has quit [Ping timeout: 480 seconds]
Oscar-L is now known as OscarL
EncryptedUnicorn has quit [Quit: Vision[]: i've been blurred!]
OscarL has quit [Ping timeout: 480 seconds]
zard has quit [Quit: leaving]
ablyss has quit [Remote host closed the connection]
mmu_man has quit [Ping timeout: 480 seconds]
L0rdRav3n has joined #haiku
ablyss has joined #haiku
L0rdRav3n has quit [Ping timeout: 480 seconds]
rakka_ has quit [Remote host closed the connection]
rakka has joined #haiku
Maturi0n_ has joined #haiku
Maturi0n has quit [Ping timeout: 480 seconds]
x10z has joined #haiku
Mobbu has joined #haiku
<Mobbu>
hello!
<zdykstra>
Hello!
hightower3 has joined #haiku
<Mobbu>
I'm pretty interested in submitting a proposal for this years GSOC, more specifically the porting VirtualBox to haiku. Does anyone know what's the best way to contact mmu_man about this?
x10z_ has joined #haiku
hightower4 has quit [Ping timeout: 480 seconds]
x10z has quit [Ping timeout: 480 seconds]
L0rdRav3n has joined #haiku
Mobbu has quit [Ping timeout: 480 seconds]
L0rdRav3n has quit [Ping timeout: 480 seconds]
dpirate has quit [Remote host closed the connection]
dpirate has joined #haiku
Mobbu has joined #haiku
ablyss has quit [Remote host closed the connection]
<Calisto>
OscarL: Do u think it would be a good idea for me to start working on ticket #18316 listed on Trac
<Calisto>
Or is it something complicated and hard and I should try more simple issues first?
<Calisto>
For now since atleast the first half of my project is going to be LayoutAPI i thought to stick to that but I did go through the basics of Queries and the underlying code to execute a query
Begasus has joined #haiku
<Begasus>
g'morning peeps
<Begasus>
augiedoggie, did you also do test run on the libpcre 10.39?
<augiedoggie>
no
<augiedoggie>
i think the previous one was 10.42 and that one didn't have any problems running apps
<Begasus>
OK, I'll do one here later for that too then
<Begasus>
ah, so 10.42 would still be fine then
<augiedoggie>
i believe so
* augiedoggie
boots his 32 bit vm
<augiedoggie>
yeah, 10.42 is fine on 32 bit
<augiedoggie>
i didn't run the test suite but apps run fine
<Begasus>
doctools build is fine here
<Begasus>
ok, reverting to 10.42 should be fine then
<Begasus>
libpcre2 doesn't seem to be used for kdoctools
<augiedoggie>
it's used by other tools that are used during the build though
<augiedoggie>
anything linking to Qt is going to have a problem because Qt links to pcre2
<augiedoggie>
apps or command line tools or whatever
<Begasus>
I only fine libpcre (not libpcre2) in the activated packages for kdoctools (unlike on the buildmaster)
<augiedoggie>
dunno, i haven't looked into the kdoctools problem
* augiedoggie
tired
<augiedoggie>
almost time for bed
<Begasus>
np, I'll hunt this down further, if nothing else you can tackle later if you are up and feeling better
<Begasus>
thanks so far
<Begasus>
update/reboot ... biab
Begasus has quit [Quit: Vision[]: i've been blurred!]
Begasus has joined #haiku
<Begasus>
k, let's do a testrun on 10.42
<PriyanshuGupta[m]>
good morning everyone!
<Begasus>
so far Akregator and Tokodon still up and running with 5.115.0 :D
<Begasus>
g'morning PriyanshuGupta[m]
<Begasus>
hmm ... only 4 test cases and one failure there
<botifico>
[haiku/website] pulkomandy db58c5d - Update mentors list
L0rdRav3n has quit [Ping timeout: 480 seconds]
x10z_ has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
<Begasus>
Must be a student or an open source beginner.* Maybe I could apply too? :P
slendi has joined #haiku
<slendi>
Hello, can I hide the Tracker if no windows are open?
<Begasus>
Tracker of Deskbar (either way wouldn't know here) :)
diver1 has joined #haiku
<Begasus>
Deskbar Preferences: auto hide?
diver has quit [Ping timeout: 480 seconds]
x10z has joined #haiku
x10z_ has joined #haiku
<slendi>
Wouldnt that hide the whole deskbar?
x10z has quit [Ping timeout: 480 seconds]
x10z_ has quit [Read error: Connection reset by peer]
x10z has joined #haiku
<Begasus>
yep
L0rdRav3n has joined #haiku
L0rdRav3n has quit [Ping timeout: 480 seconds]
x10z has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
<Calisto>
Heyy... So I was going through the Haiku Book on the interface kit and I came across that when a BButton is created using the BRect Frame parameter... Then it can't be positioned with the LayoutAPI.. does the same thing happen to every BView child class which is created using a Frame?
<slendi>
Yeah I need a way to hide just the Tracker when it has no windows, it's taking up quite some space :P
<slendi>
In the Deskbar
tuaris has quit [Quit: Leaving.]
diver has joined #haiku
<PriyanshuGupta[m]>
hey Calisto:
diver1 has quit [Ping timeout: 480 seconds]
<Begasus>
not sure what you mean by hiding the Tracker slendi
<Calisto>
Heyy PriyanshuGupta[m]
<Begasus>
hi there :)
<Calisto>
Hii
<Calisto>
I finally started reading through all the docs and now things are starting to make so much more sense xD
<Calisto>
By any chance Begasus would u suggest that I continue with the issue that I mentioned before
<Calisto>
?
<Calisto>
The one where it needs to add Functionality into the BGroupLayoutBuilder to Directly add a Box as well? Or would that be something that I should do once I get more exp with the layoutAPI in general?
<Begasus>
Calisto, as mentioned, I'm no developer, can't even write a simple "Hello World!" without tutor :)
<slendi>
Anyways I'll be going now, will be back later tho
<slendi>
cya
slendi has quit [Quit: WeeChat 4.1.2]
<Calisto>
Ohhhh
<Calisto>
I keep forgetting
<Calisto>
Potato memory issues xD
<Begasus>
np, I know my way around recipes, and can read some code (and understand some), but that's about it
<Calisto>
Oh okay
L0rdRav3n has joined #haiku
<Calisto>
Well do u have any suggestions for something that I can enhance in the tracker application?
<Calisto>
For my GSoC project I'm listing down all the ideas that I could try my hand at
<Begasus>
nope, I'm fine :) (hence I'm still on R1B4) :D
<Calisto>
Ohh okay
<Calisto>
Well then that's fine xD
<Begasus>
or you could fix my issue with kio (KF6), but that's not Haiku related :D
<PriyanshuGupta[m]>
calisto u have generated ur pr
<PriyanshuGupta[m]>
can u take me through the process
<Calisto>
Well not exactly PR since this is on Gerrit
<Begasus>
looking forward on how 3dEyes did that for 5.115.0
<Calisto>
Well sure ... Basically it's the same thing like on GitHub but what I did was I created a branch committed the files.. rebased my branch and ran the command for pushing it that was listed on the page
<Begasus>
guys one time, *write all down* (I talk from experience) :)
<Begasus>
time/tip*
<Calisto>
I didn't get what u mean Begasus :(
<Calisto>
One sec I'll just tell u the time of the conversation PriyanshuGupta[m]
<Calisto>
U could read the things that OscarL helped me out as well
<Begasus>
in the case of creating/opening/altering tickets at gerrit, write down how you did it
<Begasus>
yeah, saw the logs :)
<Calisto>
Yahh he helped out a lot with it
<Calisto>
One sec I'll just find it
<PriyanshuGupta[m]>
okay
<Begasus>
he's experienced there
<PriyanshuGupta[m]>
is the rebasing necessary part
mmu_man has joined #haiku
<Calisto>
I did it as OscarL suggested it
<Calisto>
He said it doesn't harm the commit
<Calisto>
But he said it's not exactly necessary either
<Calisto>
Btw u can check the log for 27 Feb
<Calisto>
It's there at the very end of it
<Calisto>
But in short... First I followed the https://www.haiku-os.org/guides/building/get-source-git/ ... Set up the whole ssh keys and everything... After that I created a branch of my own ... Committed my changes there (by following the guide)... Rebased and pushed it using the command listed down on the guide...
<Calisto>
Hopefully that should help :)
L0rdRav3n has quit [Ping timeout: 480 seconds]
diver1 has joined #haiku
diver has quit [Ping timeout: 480 seconds]
<Calisto>
Oh and also there is a little bit of back-and-forth involved where u need to amend your commits after getting suggestions from the reviewers assigned and that mostly follows the guides as well :D
<Calisto>
But that's about it i guess
<Calisto>
Or atleast that's all I know but OscarL should be able to help you out more with this thing :)
AlienSoldier has quit [Quit: Vision[]: i've been blurred!]
<botifico>
[haiku/website] pulkomandy a81938a - GSoC contributors guide: clarify that personal information needs not be shared in GSoC application drafts
<dovsienko>
waddlesplash: thank you for looking into #17058, I still have a packet capture running, so if the problem occurs again after hrev57616 within the next week, better diagnostics will be available
x10z_ has joined #haiku
x10z has quit [Ping timeout: 480 seconds]
andreaa71 has joined #haiku
x10z has joined #haiku
x10z_ has quit [Read error: Connection reset by peer]
x10z_ has joined #haiku
x10z has quit [Ping timeout: 480 seconds]
diver1 has quit [Read error: Connection reset by peer]
<bitigchi[m]>
Can anyone push to Gerrit? It was working an hour ago
andreaa71 has left #haiku [#haiku]
<bitigchi[m]>
<bitigchi[m]> "Can anyone push to Gerrit? It..." <- Fine now
mmu_man has quit [Ping timeout: 480 seconds]
x10z has joined #haiku
x10z_ has quit [Remote host closed the connection]
<nekobot>
[haiku/haiku] d0f06357f51a - app_server FontManager: load all fonts and named-variants from a file
<bbjimmy>
Github in WebPositive is no fun, many buttons do not show or do not show the label. makes commiting a pull request a guseeing game.
<zard>
Maybe once we get webkit2 for WebPositive. I'm planning to work on that for GSoC
<nephele>
webkit2 won't help with that
humdinger has joined #haiku
<nephele>
zard: have you worked with haikuwebkit yet?
<zard>
Not much yet. Haven't even compiled it yet
<humdinger>
bbjimmy: look for a theme setting at github and set dark colours. makes buttons etc. readable.
<bbjimmy>
Looks like I need to go hunting for github settings.
<waddlesplash>
nephele: not publicly
<nephele>
zard: well, if you want to work on for gsoc you would (probably) need a computer that can atleast compfortably compile it, i have a machine that does a clean build in 48min, that is a 12core one with 32gb of ram
<nephele>
it would be good to test this out beforehand
<waddlesplash>
zard: 10:49:28 AM: Error: Error building site: "/opt/build/repo/content/blog/pulkomandy/2024-02-28_so_you_want_to_help_with_webkit.md:9:46": unrecognized character in shortcode action: U+005B "[". Note: Parameters with non-alphanumeric args must be quoted
<nephele>
if you want i can give you some tasks to work on for haikuwebkit
<nephele>
Maybe you are better of using Gnome Web for github, they are constantly ramping up their use of complex uneccesary apis
<nephele>
and i honestly don't want to spend my time investiagting those
<bbjimmy>
Don't like the look, but if it makes the buttons show up I'm all in.
<humdinger>
dark theme works. I don't like Web too much
<humdinger>
I try to be as short at github as possible...
<nephele>
github in the last week started doing some much wierder stuff than usualy
<humdinger>
also because the site pegs a core and throws my fan into hispeed
<nephele>
i'm sure it can be fixed, but i'd rather investiage other stuff
<waddlesplash>
above commit succeeded, website deploy in progress
<humdinger>
enough bugs around for all... :)
<nephele>
Yes, but i don't see the github situation getting any better in WebPositive
<nephele>
If any other dev wants to investigate github issues in haikuwebkit I would be happy to assist with pointers for the webkit codebase, but other than that i just cant be bothered with that website
<Begasus>
closing down, cu peeps
Begasus has quit [Quit: Vision[]: i've been blurred!]
<nephele>
waddlesplash: Okay, i suppose I'll wait for the api docs to show up "eventually" :)
<waddlesplash>
they also get deployed in the same process
tqh has joined #haiku
<waddlesplash>
so that should now be done
<humdinger>
chances are other sites have similar issues, so you may end up solving github issues as unintentional sideeffect. :)
<nephele>
Doubtfull
<nephele>
If the past github issues are anything to go by
<nephele>
like "pegs a core 100% because it spams the javascript log everytime it can't use a specific api"
<zard>
Yikes!
<nephele>
that was InterSectionObserver api btw
<nephele>
Github needed this for the immensely complex task of "render a three line menu"
<zard>
re powerful computer needed for compiling haikuwebkit: I have one with 12 cores and 24 gb ram. Looks like I won't be able to run Haiku in a VM anymore though :P
<nephele>
That should be sufficient. The Ram may be a bit icky but other than that probably fine
<nephele>
by that i mean: each job needs a specific ammount of ram usually, so 2gb/core is maybe too little. but you can adjust by using less jobs iirc
<zard>
Ah, ok
* zard
already compiles Haiku-PyAPI with 8 cores because the VM only has 6gb memory
* zard
starts working on fixing error from Haiku website
bebert has joined #haiku
<nephele>
best would be to just try it out anyhow
bebert has left #haiku [#haiku]
<waddlesplash>
zard: I already fixed it
<zard>
Ah, that explains why I failed to reproduce it :^)
<nephele>
"And you are not coming back!"
<tqh>
200MB should be enough for anyone!
<zard>
Just need enough swap!
<tqh>
No swap, zram maybe
<nephele>
tqh: I kind of hate that when building that PC my requirements really *were* guided by "this should be able to compfortably compile webkit"
<nephele>
luckily it was only webkit, for chromium there is no way i would even be able to afford the computer
<zard>
Wait till you here how much memory it takes to build Android!
beberthaiku has joined #haiku
<tqh>
nephele, I agree. We need to invent an alternative to html megalomaniacs :)
<nephele>
No thanks. I stopped at the *disk requirements*
<zard>
IIRC, it is 128 gb. Otherwise, you *need* swap
Anarchos has joined #haiku
<nephele>
tqh: honestly. Yeah. there are many things that could be done much nicer
<nephele>
gemini is a bit "eh" it's http but like, mediocre... doesn't really improve on anything, just tunes out the complexity a bit
<tqh>
nephele, yes I was only half-joking.
<zard>
bbiab
<nephele>
Well, once I'm done destroying the posix shell layer we can work on webrowsers ;)
<tqh>
and bring back <blink>
<nephele>
but beware that I will probably want insane requirements like SCTP and DTLS
<nephele>
... need to implement SCTP for Haiku
beberthaiku has quit []
* phschafft
is all in for SCTP.
humdinger has quit [Quit: Vision[]: Oi with the poodles already!!]
Anarchos has quit [Quit: Vision[]: i've been blurred!]
<nephele>
hi zard
<zard>
Before I can download haikuwebkit, I either need to resize the BFS drive or to connect to a network drive somehow
<nephele>
hm?
<zard>
Don't have enough storage space on my BeFS partition atm
<nephele>
make a second partition? :P
<zard>
Ah, there's an idea
gouchi has joined #haiku
gouchi has quit [Remote host closed the connection]
DKnoto_W has quit [Ping timeout: 480 seconds]
<nephele>
one haikuwebkit checkout is 14GB on disk, the other 15GB for me
<nephele>
so i suppose 25GB or something would be sufficient for a while
<zard>
Yikes! you didn't use --depth, did you?
* zard
hopes he can get away with --depth, and still work with the multiple branches of haikuwebkit
<nephele>
dunno
<nephele>
multiple branches?
<zard>
The webkit2 branch and the master branch
<nephele>
We only work on the "haiku" branch
<nephele>
you can ignore master and webkit2
<dovsienko>
"git worktree" may be a good solution
<zard>
Ah, I meant haiku and haiku-webkit2
<nephele>
One webkit gsoc is ancient and unmerged, the other is updated but broken
<nephele>
and the majority is in haiku but doesn't work either
<nephele>
so just stick with the haiku branch unless you need specific stuff
<zard>
Ok, interesting
<nephele>
if you want I can give you tasks in the haikuwebkit codebase to do
<zard>
Don't need any yet. Still need to get familiar and all. But soon, perhaps
<nephele>
alright. shoot me an email if you have any questions or want some help. Gonna go sleep in a bit
<zard>
+1
<nephele>
my email adress is zardWebkitHelpLine at packageloss.eu
<zard>
Nice email :P
<nephele>
:)
Hannah has joined #haiku
nephele has quit [Quit: Vision[]: i've been blurred!]
x10z_ has joined #haiku
* zard
managed to make a similar system using only gmail's + email extensions
x10z has quit [Ping timeout: 480 seconds]
<zard>
Here I go, testing how well Haiku can manage a FAT filesystem in read/write mode
<zard>
Hopefully no data corruption bugs
<zard>
"Sorry, could not create a new folder." :/
x10z has joined #haiku
x10z_ has quit [Remote host closed the connection]
Calisto has joined #haiku
<zard>
Now where was that syslog...
<zard>
Answer: /system/var/log/syslog
<zard>
Maybe would be better if I used an ext4 partition instead of a FAT partition
<zard>
But, that's all for today. Goodbye!
zard has quit [Quit: leaving]
<PriyanshuGupta[m]>
hello
<PriyanshuGupta[m]>
is oscar here?
janjo has joined #haiku
<B2IA>
(AGMS) Don't seem to be any Oscars in the IRC list of users online.
<PriyanshuGupta[m]>
B2IA: can u help me with this
<PriyanshuGupta[m]>
in my current pr for review oscar suggested me to save the patchset set2
<PriyanshuGupta[m]>
but I can't seem to find it
<B2IA>
(AGMS) That's a list of changes in the Gerrit review system. Either you can upload a new change (which makes a new patchset), or you can make additional changes to an existing patchset (download it first as a Git branch, make changes, upload with some metadata that identifies where it should go).
<B2IA>
(AGMS) Looks like you are doing the xfs global free space thing.
<B2IA>
(AGMS) And it has two patchsets.
<PriyanshuGupta[m]>
yes
<PriyanshuGupta[m]>
i had successfully did it
<B2IA>
(AGMS) It has files and comments for the patchsets, pick the one which goes from Base to Patchset 2, then click the download button over the right hand side column headings.
<B2IA>
(AGMS) That will give you a screen full of git commands for getting patchset 2.
<PriyanshuGupta[m]>
i did the commit previously
<PriyanshuGupta[m]>
should i do push now?
<B2IA>
(AGMS) Maybe. Does your commit message have a Change-Id: at the end of the text?
<PriyanshuGupta[m]>
yes i have attached the same change id
<PriyanshuGupta[m]>
in the commit message
<B2IA>
(AGMS) Ah, I see OscarL has left instructions in the patchset for how to do a commit, and I assume a push follows.
<B2IA>
(AGMS) Try it out and fix it if it breaks?
<PriyanshuGupta[m]>
okay
<B2IA>
(AGMS) Let us know when it's ready, then I can have a look at Gerrit to see if it changed.
<PriyanshuGupta[m]>
one problem
c644ever has quit [Quit: Leaving]
<PriyanshuGupta[m]>
it's saying same change id here🥲
<PriyanshuGupta[m]>
should i remove change id?
tuaris has joined #haiku
<B2IA>
(AGMS) Hmmm, reading Gerrit documentation.
ClaudioM has quit [Quit: leaving]
mr_lou has quit [Quit: Leaving]
v_harkonnen has joined #haiku
<B2IA>
(AGMS) It doesn't say anying about appending to patchsets.
<B2IA>
(AGMS) It should know which patchset to apply things to based on the branch you downloaded, which has the hash code of the last thing modified in the patchset.
<B2IA>
(AGMS) So you'd only need the ChangeID if uploading a totally new patchset.
<B2IA>
(AGMS) Try it without the ChangeID in the commit message?
<B2IA>
(AGMS) Or maybe you have to always start a new patchset? No idea here. Maybe OscarL knows.
<B2IA>
(AGMS) Pity there isn't a Test repository where you could experiment and see what works.
<PriyanshuGupta[m]>
okay I'm removing the change id
<PriyanshuGupta[m]>
B2IA: can u check now?
<B2IA>
(AGMS) OK. Just a sec.
<PriyanshuGupta[m]>
i think it's correct this time
<B2IA>
(AGMS) Nope, it created a totally new change, #7492. See if you can delete it.
<PriyanshuGupta[m]>
should i abandon it?
<B2IA>
(AGMS) Yup.
<B2IA>
(AGMS) I suggest starting over. Save your new source code files somewhere outside git, then redownload the patchset2 branch.
<B2IA>
(AGMS) Then copy your files over the patchset2 ones in your new branch, and make a commit with the ChangeID and then push it.
<B2IA>
(AGMS) And if that doesn't work, make a patchset3.
mmu_man has quit [Ping timeout: 480 seconds]
jmairboeck has joined #haiku
v_harkonnen has quit [Ping timeout: 480 seconds]
mmu_man has joined #haiku
<PriyanshuGupta[m]>
hey B2IA take a look at my previous patch
<PriyanshuGupta[m]>
it's saying about the link to new one
OscarL has joined #haiku
<PriyanshuGupta[m]>
hii oscar
<PriyanshuGupta[m]>
waiting for u only
<PriyanshuGupta[m]>
right now
<OscarL>
Hi PriyanshuGupta[m].
<PriyanshuGupta[m]>
take a look at my new patch
<OscarL>
I see that you tried to push a new patchset, but you didn't do it exactly right :-)
<PriyanshuGupta[m]>
then help me out
<PriyanshuGupta[m]>
please
<OscarL>
I'll try.
<PriyanshuGupta[m]>
should i abandon the current one?
<B2IA>
(AGMS) Whew, OscarL is back. Maybe you can help PriyanshuGupta[m] append stuff to patchset2 rather than creating a whole new change.
<B2IA>
(AGMS) 7491 is the original change with all the comments.
<OscarL>
When you want to modify your patchsets on Gerrit, "git commit --amend" (instead of creating and pushing new commits).
<B2IA>
(AGMS) OK, key piece of information I didn't know.
<OscarL>
PriyanshuGupta[m]: as I had already modified your commit message (or if other reviewer had made modifications to your patchset)... you need to make sure that you'r local repo has the last "revision" of that change.
<PriyanshuGupta[m]>
okay
<OscarL>
that's why to need to "download" that patchset 2 (in this case)
<OscarL>
before starting to work over it.
jmairboeck has quit [Quit: Konversation terminated!]
<PriyanshuGupta[m]>
okay
<OscarL>
As I don't know the state of your repo, and I'm far from being a git expert... lets start with some basics.
<PriyanshuGupta[m]>
okay
<OscarL>
did you originally started working from a branch?
<PriyanshuGupta[m]>
yea
<PriyanshuGupta[m]>
yes*
<OscarL>
alright. then you made your fist commit, and pushed it... then you saw my comment and you manually edited your commit?
<PriyanshuGupta[m]>
i edited the require files
<PriyanshuGupta[m]>
the copyright thing
<OscarL>
I'm asking about this: "20:19 <PriyanshuGupta[m]> yes i have attached the same change id "
<PriyanshuGupta[m]>
yes
<PriyanshuGupta[m]>
i did
<OscarL>
Not ideal, as I had already edited that commit message on Gerrit, and why I asked that you made sure you had THAT version of the commit.
<PriyanshuGupta[m]>
okay
<PriyanshuGupta[m]>
i misinterpreted that
<OscarL>
Maybe I should have just asked you do that locally instead, but I wasn't sure I would connect to IRC today, sorry.
<PriyanshuGupta[m]>
nope that's not a problem
<PriyanshuGupta[m]>
what should i do now
<OscarL>
In any case, not THAT big of a deal, git saves stuff for us.
<OscarL>
so, you are on your branch, and that branch has two commits now, your original one, and the one with the modified headers and such, right?
<PriyanshuGupta[m]>
yes
<PriyanshuGupta[m]>
actually i abandon that commit on gerrit
<OscarL>
that's fine.
<PriyanshuGupta[m]>
From ssh://git.haiku-os.org/haiku
<OscarL>
give me a sec while my slow PC starts, so I can give correct suggestions :-)
<OscarL>
Can you please post a bit more of that log? (use https://bpa.st or https://0x00.st) the one you posted above has repeated info, instead of showing all your commits.
<PriyanshuGupta[m]>
i think these one are different
<OscarL>
that shows at least 3 commits.
<PriyanshuGupta[m]>
there are 2 more
<PriyanshuGupta[m]>
but have same id as the top one
<OscarL>
ok, see the one with hash 84116acec837ea3409f1fbe44e343446f02126b2 ?
<OscarL>
that's the one you manually added the "Change-Id" to, right? (just so I understand what's going on :-D)
<PriyanshuGupta[m]>
the one in which i manually add change id failed
<PriyanshuGupta[m]>
and the error it says is it's the same change id
<Calisto>
Hiii OscarL and PriyanshuGupta :)
<PriyanshuGupta[m]>
hii
<OscarL>
hey Calisto.
floof58 has quit [Ping timeout: 480 seconds]
<OscarL>
PriyanshuGupta[m]: what I'm not seeing, is the the commit that you "downloaded" from gerrit. Any way...
<PriyanshuGupta[m]>
I'm really getting confused right now
<OscarL>
One way to solve this would be to squash all those commits into one, making sure that the commit message contains ONLY one Change-Id..
<Calisto>
Btw OscarL after ur done with ur conversation with PriyanshuM i needed a bit of help with the cleaning up of my branch like u said... For now I'll just be online and wait for Priyanshu to get his Gerrit issue sorted :)
<PriyanshuGupta[m]>
oscar should i abandon my previous request for review and start with a new branch
<PriyanshuGupta[m]>
this one is easy i think
<OscarL>
PriyanshuGupta[m]: another would be: switch to master, download the patchset 2 in a differnt branch (that would be a clean state)....
<PriyanshuGupta[m]>
yess
<OscarL>
and re-apply your latest changes on top of that.
<OscarL>
Calisto: alright :-). Just remember that I'm slow :-)
<PriyanshuGupta[m]>
only the one with right changes?
<PriyanshuGupta[m]>
Switched to a new branch 'change-7491'
<PriyanshuGupta[m]>
result after that git fetch command
<OscarL>
good! now git log should show YOUR commit, + the Change-Id that I've added, right?
<PriyanshuGupta[m]>
yes
<PriyanshuGupta[m]>
only the single one
<OscarL>
we're on the right track :-)
<PriyanshuGupta[m]>
in which u added change id
<OscarL>
now you can add your changes on top of it, the do `git add <files you changed>`, but make sure you use `git commit --amend`
<PriyanshuGupta[m]>
okay
<OscarL>
that will avoid creating new commits, and will just modify the original one.
<PriyanshuGupta[m]>
okay
<OscarL>
then you can `git push origin HEAD:refs/for/master` when you finish.
x10z has quit [Ping timeout: 480 seconds]
<OscarL>
but before pushing, `use git log` to see that you only have one commit, and with "Change-Id: I41160453bc91f06103df8b4f246c9458d347ae63" as the last line.
<PriyanshuGupta[m]>
yes
<PriyanshuGupta[m]>
finally
<OscarL>
PriyanshuGupta[m]: when using `git commit --amend`, you can edit the commit message, if necessary (to include aditional info, and such), just leave that Change-Id line at the bottom as is)
<PriyanshuGupta[m]>
I'm pushing
<PriyanshuGupta[m]>
take a look at gerrit
* OscarL
braces for impact!
<OscarL>
:-P
<PriyanshuGupta[m]>
you are a great help man
<PriyanshuGupta[m]>
thank you a lot
<PriyanshuGupta[m]>
it's 3.30 am in here
<OscarL>
did the push finished yet? (and sleep well, in any case :-D)
<PriyanshuGupta[m]>
done
<OscarL>
yes! I see patchset 3!
<OscarL>
now you know the basics... and proper reviwers will comment on your code!
<PriyanshuGupta[m]>
thank you Oscar
<OscarL>
no problem, happy to help if I can :-)
<PriyanshuGupta[m]>
now i think i should sleep
wicknix_ has joined #haiku
* augiedoggie
despises gerrit
<OscarL>
Indeed. Sleep tight!
* OscarL
dislikes gerrit UI semi-passionately :-P
wicknix has quit [Ping timeout: 480 seconds]
<OscarL>
heh, seems he hadn't setup git correctly at the time of his first commit "Author: New Author Name" :-)
<OscarL>
Calisto: what can I do for you?
Anarchos has joined #haiku
* OscarL
re-reads the logs, and thanks AGMS for the assist :-)
<B2IA>
(AGMS) No problem, learnt a bit - modify the existing commit!
x10z has joined #haiku
<Calisto>
Heyyyyy
<Calisto>
Actually I remember you telling me that I should clean up my branches as and when I'm done with merging changes
<Calisto>
i didn't want to leave that undone so I thought of getting back to u :)
<OscarL>
alright.
<OscarL>
you had two different branches for the changes you pushed?
<Calisto>
Yup
x10z_ has quit [Read error: Connection reset by peer]
<OscarL>
ok, if you don't have uncommited/unpushed changes on those...
<OscarL>
you can just `git branch -D <branch-name>`, now that you'r changes have been merged.
<Calisto>
Nope everything is pushed and nothing is left as unpushed on those branches as of now
<Calisto>
Ohh okay
<Calisto>
So just delete the branch and that's about it?
<OscarL>
yup
<Calisto>
Oh okay :D
<OscarL>
specially for short-lived branches like those.... IMO... best to not let them accumulate too much :-D
<OscarL>
Calisto: a bit about the need or not for "rebase"...
<Calisto>
Btw OscarL I was working on my GSoC proposal document... I know you might not be a GSoC mentor but u have guided me quite a lot over the past week. I was thinking whether I could upload it on Google docs and you could give it a quick read through whenever u get the time .. it's a work in progress :)
<Calisto>
Yahh i was confused about that
<Calisto>
Too
<Calisto>
Like when should I be doing a rebase exactly?
<OscarL>
when you expect changes on code related to the one you're working with, for example.
<OscarL>
Say...
<Calisto>
For now i had rebased for both the commits (only while pushing the first version of the commit)
<Calisto>
Ohhhh okay
<OscarL>
another dev is ALSO working on MediaPlayer, at the same time that you...
<Calisto>
Like if someone else is working on the same app
<Calisto>
As me and making changes as well
<Calisto>
Ohhh okay that makes sense
<Calisto>
So whenever I'm pretty sure noone is working on the same application .. there's no need to rebase as such?
<OscarL>
if you don't rebase often, most likely your changes will "conflict", thus preventing a merge.
<OscarL>
Calisto: yeah... specially when working on a branch of your own.
<Calisto>
Oh okay that makes sense
tqh has quit [Remote host closed the connection]
<Calisto>
But in the case that I do rebase everytime.. does it harm the process in any way?
<Calisto>
Or is it fine as a good safeguard assuming I may not know if someone is making changes on the application at the same time?
<OscarL>
if you push, and see that Gerrit says: CONFLICT, the you NEED to rebase, and fix those conflcts before pushing again.
<Calisto>
Ohhh I see
<Calisto>
That makes sense
<Calisto>
Thanks so much OscarL :)
<OscarL>
Calisto: doesn't hurt, other than adding new "empty" patchsets versions for only the rebase
<Calisto>
Oh yess... I did notice that for the commits I had made
<Calisto>
I guess it becomes a hassle for the reviewers?
<Calisto>
Or is there no difference as such?
<OscarL>
If you rebase, AND make mods... is "more OK" :-D
<Calisto>
Righttt
<Calisto>
Otherwise it's just like what happened before
<Calisto>
Where there were empty patchsets on my commits
<OscarL>
doub't it is much of a hassle, just not really adding much, unless there's code changes, or a need for it.
<Calisto>
That makes sense
<Calisto>
Thanks so much :D
<OscarL>
let me re-read your comment about that GSoC proposal (I'm also a slow reader :-D)
<Calisto>
That's quite alright xD... Me too
<OscarL>
Calisto: as long as I don't need to sign in to google to read your proposal, I guess that another pair of eyes can't hurt :-)
<OscarL>
(albeit, indeed, I have no say in anything related to GSoC)
<Calisto>
Yah that's quite alright.... Just thought that I could get advice in general on ways to make the proposal better in any way :)
<OscarL>
I can at least try, I guess.
<Calisto>
Even if you can't give me advice on the project itself... Things like whether I should elaborate more or make it shorter... Any advice would be really helpful :)
<PulkoMandy>
Calisto: Ycu can share it on the haiku-development mailing list, or send it just to the mentors if you don't want it to be public
<Calisto>
Oh okay I'll do that then
<PulkoMandy>
(I'm not reading all messages on this chat, there are too much. But I read everything on the mailing list and most things on the forum)
<Calisto>
Oh okay cool
<Calisto>
I did make a post about it on the forum around 20 minutes ago
<Calisto>
I had forgotten to make it a few days back but I did get it done today :)
<Calisto>
Is it okay if I upload the doc while it is a work in progress?
<Calisto>
Or should it be completed before I send it on the mailing list / forum
<PulkoMandy>
Just say that it's a work in progress and you look for help completing it
<Calisto>
Oh okay
<Calisto>
Ill do that
<PulkoMandy>
It's not really a contest or a school assignment, we're here to help and try to work together to advance the Haiku project
<PulkoMandy>
So I don't think there is anything to gain by trying towork all on your own
<Calisto>
Yah thats what I was thinking as well 😅
<Calisto>
Okay then :) I'll do that.. uploading the doc right now... I think i might be able to finish the basic version of it in a few days and keep improving it till the deadline (or that's the plan atleast xD)
<Anarchos>
Calisto what area of haiku is your proposal about ?
<Calisto>
The user interface project
<Calisto>
My main project idea is to improve and rebuild the user interface of The tracker query window from scratch again
<Calisto>
And also to fix bugs and try solving issues listed on Trac as I go along
<dovsienko>
I wonder if it would be simple to fix gitk from the git_gui package
<Calisto>
Wait i dint get what you said dovsienko
<dovsienko>
because it starts in some kind of a nested X server window, which the program window does not fit, but trying to resize the window crashes the process
<Anarchos>
Calisto ok
<OscarL>
dovsienko: problem with that is the undroidwish uses SLD2, and there's a known issue with some SLD2 apps that crash (related to some OpenGL lock)
<dovsienko>
Calisto: "pkgman install git_gui", then "cd <some repository>", then "gitk", then try to resize the window
<Calisto>
Ohhh okay give me a few minutes I'll just try that out
<dovsienko>
it does say something about OpenGL indeed, which is a bit out of place for a Tcl/Tk program, IMO
<OscarL>
dovsienko: undroidwish being what provides for tk/wish on Haiku.
<PulkoMandy>
dovsienko: There is a ticket at haikuports with some info and workarounds
xet7 has quit [Remote host closed the connection]
<OscarL>
at least until xlibe can manage it better :-)
<Calisto>
Anarchos: btw I did make a forum post on it so It would definitely help if you went through that ... Im still in the early stages of creating the proposal so definitely looking for suggestions :)
<dovsienko>
I used to think SDL if a game development library...
<Calisto>
Btw I know this might be a very bad question... But is there a preference given to certain areas of development under the ideas listed under GSoC? Or are they all weighed equally during the selections for GSoC. Also I read about submitting multiple ideas but I was thinking of sticking to one for a while until I get a good hang of the development in Haiku. Any suggestions?
<Habbie>
definitely not just that
<Habbie>
i'm currently using SDL to build a Home Assistant frontend :)
<OscarL>
that should look a lot better, once the bugs get squashed :-D
<Anarchos>
Calisto cab't really read the forum on Web+ : i use haiku bare metal here
<OscarL>
Calisto: I *think* proposals are weigthed more as in: "does it looks like this has a chance to succeed?", but probably let mentors anwser that :-D
<Calisto>
Ohhh i see... I run haiku on bare metal too... But for working on the proposal I'm working off my other OS. That's quite alright tho... If you do get the chance to read it on your mobile phone, I would love to receive your feedbacks :)
<Calisto>
Would it be possible for u to go through it if I sent the Google doc link here?
<Calisto>
Ohhh I see OscarL ... Well that's a bit relieving to know 😅
<Calisto>
I was starting to think that maybe the issue I chose was one that had a lower chance of getting accepted tho I was still planning to stick to only this for now, regardless 😬
<OscarL>
will show you that quite diverse proposals were accepted.
<Calisto>
Ohhh I was going through the 2022 projects on this... Was blown away by things that were achieved during such a short period of time 🫠
<OscarL>
ranging from "improve this particular app" to things like porting C#.
<Calisto>
Yahhh
<OscarL>
If I proposed myself to port language X... I'd get laughed out of the chat room.
<OscarL>
If my proposal was inline with what I've shown I can accomplish...
<OscarL>
I would ALSO get laughed out of the room... but that's just my case :-P
ablyss has joined #haiku
<Calisto>
Wow If you say that I have no idea what to say about mine xD
<Calisto>
But let's see
<Calisto>
Regardless, I'll still keep contributing because improving my C++ skills was the end goal anyways xD and the happiness from those two successful merges was the happiest I've been this week xD so 🫠🫠
<Calisto>
Anywyas it's getting pretty late here 🥲🥲
<OscarL>
Sleep well Calisto! Read you soon!
<Calisto>
Yup... Probably will be back online tomorrow tho I might not be as active as I have a university event to attend 😅.. Good night OscarL... See ya tomorrow :)
<Anarchos>
OscarL i ported interlisp in one week :)
<OscarL>
And that's what separates real programmers... from me :-)
<Anarchos>
OscarL interlisp was not much a big deal : it is write in C
<OscarL>
my skill set is like this: a toolset with many of missing pieces, in a battered toolbox, used by a mechanic that has lost half his marbles :-)
<Habbie>
the marbles falling down is how the toolbox got so battered
<OscarL>
that explains a lot :-)
<Habbie>
:)
<Anarchos>
OscarL i have many areas to improve too ! i can't do no assembly at all
Anarchos has quit [Quit: Vision[]: i've been blurred!]
Oscar-L has joined #haiku
<Oscar-L>
once upon a time, I could do some basic Z80 ASM, and read a *tiny* bit of x86. Doubt I could do more than "xor swap without temp" now :-D