<jmairboeck>
Thanks Begasus! I already wanted to ask you if you want to port Kile
<jmairboeck>
it is the editor I used the most for my Latex things
<Begasus>
heh
<Begasus>
had it here for a while already ;)
<Begasus>
looking into bumping it to the latest beta (uses KF6)
<Begasus>
first need to see for some changes to Okular, so that Kile can pick that up too
<jmairboeck>
that would be nice if that works
<Begasus>
well, it's the KF6 version for Okular here :P
<jmairboeck>
ah, that makes sense that they don't work together :)
<Begasus>
but shouldn't be so hard to make those changes to the one in the depot I guess, I thiink it searches $binDir for okular (which is currently installed in $appsDir)
<jmairboeck>
I think it only uses the Okular KPart, so I guess that should be somewhere in $libDir. I would be surprised if it uses the actual executable for that.
<Begasus>
it's not listed/mentioned when building ends (it needs the dev part though)
<Begasus>
This is TeXk, Version 3.141592653 (TeX Live 2024/Haiku) (preloaded format=tex) (nice jmairboeck) :D
<jmairboeck>
nice Begasus! although currently the 2024 version can only be built locally. But I think the upgrade isn't really urgent, so we can wait for the upgrade of the buildmasters.
<Begasus>
yeah, at least 2 people can enjoy it for now jmairboeck :P
<jmairboeck>
the 2023 version is still fine I think. My openSUSE system still has 2021 I think
<Begasus>
and you can check with Kile if something needs fixing or not :)
<Begasus>
yeah, probably is
<jmairboeck>
I will check that later
maylay has joined #haiku
<Begasus>
can't add a not in the forum about it, more then 3 replies in a row is not possible :P
<Begasus>
I don't think you can use 4.8.4 for that
<Begasus>
whoot! upstream is already at 5.12.0 :p
<Anarchos>
Begasus i just copied the recipe and change all the -4 for -3 reference
<Anarchos>
and copy the build instruction from the source (which is basicallay autogen.sh;configure;make)
<Begasus>
jikes, spaces instead of tabs in the beginning of the lines :)
<Begasus>
I don't think you can create gtksourceview-3 from a 4.* archive?
<Anarchos>
no but i changed the url for the source
<Begasus>
SOURCE_URI is the same (checked with ponpokodiff)
<Anarchos>
because there is gtksourceview-$portVersion.tar.gz so it takes care of the -3.24.0 version in the recipe name ?
<Begasus>
ah!
<Begasus>
so that's the portversion you used :)
<Begasus>
first thing, remove all the spaces in the indents and replace them with tab(s)
<Begasus>
autogen.sh was already failing because of the spaces here (grabbed 3.99.7)
<_-Caleb-_>
Begasus, sorry for ask one more update...would be posible update squashfs-tools ? Last versión IS a 2017 versión and i cant use on haiku, need to boot a linux Desktop to work with the sfs files hehehe (created with 4.x version), 2.x in the Depot
<Begasus>
grabbing gtksourceview3-3.24.0-1-x86_64.hpkg and moving it to /Opslag/haikuports/packages/gtksourceview3-3.24.0-1-x86_64.hpkg
<Begasus>
grabbing gtksourceview3_devel-3.24.0-1-x86_64.hpkg and moving it to /Opslag/haikuports/packages/gtksourceview3_devel-3.24.0-1-x86_64.hpkg
<Begasus>
;)
<Begasus>
libversioncompat is wrong also in the recipe (me wonders if that correct also in the 4 version)
<Begasus>
that/that is*
MajorBiscuit has quit [Ping timeout: 480 seconds]
bbjimmy has quit [Quit: Vision[]: i've been blurred!]
<Anarchos>
Begasus you mean this line : " gtksourceview$secondaryArchSuffix = $portVersion compat >= 4" ?
<Begasus>
that too :)
<Begasus>
compat >= 3
<Begasus>
0.0.0 compat >= 0 (isn't right also)
bbjimmy has joined #haiku
<Begasus>
libgtksourceview_3 isn't correct either ...
<Begasus>
hint ... Warning: POLICY WARNING: "/packaging/gtksourceview3/lib/libgtksourceview-3.0.so.1" needs library "libharfbuzz.so.0", but the package doesn't seem to declare that as a requirement
<Anarchos>
Begasus you got farther than me i have no hpkg yet :)
<Begasus>
heh
<Begasus>
it's not always copy/paste :)
<Anarchos>
Begasus i know but i hate to write recipes
<Begasus>
it takes some practice, but if even I can manage Anarchos ;)
<Anarchos>
Begasus i added "find . -name Makefile.am -exec sed -i '/@CODE_COVERAGE_RULES@/d' {} +" from the archlinux link between autogen.sh et runconfigure. Same trouble.
<Begasus>
before autogen.sh
<Begasus>
Makefile.am is used by configure.ac, not configure
<Anarchos>
ah thanks
<Begasus>
and autogen.sh uses configure.ac to build configure
* Begasus
has GCI flashbacks
<Anarchos>
autoconf is such a mess..
<Begasus>
heh
<Anarchos>
dealing from PDP-11 to android platform i guess :)
<Begasus>
has been a while since I played with it
<Anarchos>
Begasus got better : configure finished. But : /port.recipe: line 85: $'\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240autoconf_archive': command not found
<Anarchos>
spaces in front of --disable-dependency-tracking ....
<jmairboeck>
Begasus: I now tested Kile, the system check fails and it says "check disk space" - could that be a packagefs problem? did you try the packaged version or a manually built one?
<jmairboeck>
in the texlive installer I also had to disable the disk space check because it claimed 0 free disk space ...
<Begasus>
cmake project (you can see that in the recipe jmairboeck)
<jmairboeck>
no, I mean after running it
<Begasus>
yes Anarchos, loose the spaces in front of the lines
<jmairboeck>
I just installed the package
<Begasus>
packaged version jmairboeck
<Begasus>
could be that it did a manual check earlier last week though
<Begasus>
installing on 32bit
mattlacey has quit [Ping timeout: 480 seconds]
<jmairboeck>
I'll check if it works, if it does, the system check is not critical
<Begasus>
missing runtime dep on libokular too it seems
<Begasus>
no mention for the diskspace here jmairboeck
<Begasus>
don't have texlive installed yet there too, but that's another thing :)
<Begasus>
installing texstudio should fix that
<Begasus>
_-Caleb-_, update should fix the missing dependency on click_python310 :)
<Begasus>
Anarchos, --disable-dependency-tracking (shouldn't be needed) :)
<Begasus>
there is also a testsuite :P
<jmairboeck>
looks like Kile works here :)
<Begasus>
+1
<Begasus>
you could ask if M3dEyes[m] could rebuild okular to put the binary in $binDir ;)
<Begasus>
there is no option in Kile to set the path for that
<jmairboeck>
it just didn't really like my 10 year old project file, it said that it couldn't determine the master file and wouldn't build it using that
<Begasus>
slap it :)
<jmairboeck>
but it did work opening the .tex file directly, so that is good enough I think
<Begasus>
I just grabbed a few tex projects from the net and got a few from Bruno
<jmairboeck>
maybe a dependency on Okular would be a good thing though
<Begasus>
it's strange that it didn't produce a policy warning on missing lib dependency for that
<jmairboeck>
I'm not sure exactly how KParts work, I think it doesn't link it directly
<jmairboeck>
then haikuporter doesn't detect it
<Begasus>
jmairboeck, it's not that hard to change the recipe for that (okular), and it functions just as good
<Anarchos>
just kidding : throw away texstudio, just use the native BeTeX !! (as soon as i could made my PR accepted ;))
<jmairboeck>
Kile is also in /bin, not in $appsDir. Is that intentional?
<Begasus>
maybe it searches for the lower case binary, now it's $appsDir/Okular
<jmairboeck>
that could also be
<Begasus>
on Kile ... yes
<Begasus>
iirc M3dEyes[m] mentioned that having a bin "foo" and an app "Foo" produces 2 seperate setting directories in ~/config/settings
<jmairboeck>
maybe a symlink is also sufficient
<jmairboeck>
did you try that?
<Begasus>
Well it creates a "Foo" directory even with the Deskbar link (but that's empty)
<Begasus>
for Kile there is only the deskbar link
<Begasus>
and for Okular I did the same for the KF6 version
MajorBiscuit has joined #haiku
<Begasus>
kcalc and konsole are 2 examples that are being used by other apps also
<jmairboeck>
Konsole can be used in Kile too :)
<Begasus>
hence I linked kcalc back into $binDir for KMyMoney (iirc) :)
<Begasus>
yep
<Begasus>
that's also KF6 here ;)
<Anarchos>
Begasus error more easy to tackle for me (later in the afternoon) : https://bpa.st/WCLQ
<Begasus>
Anarchos cc1: all warnings being treated as errors
<Begasus>
"--disable-Werror"
<Begasus>
with configure
<Anarchos>
that's what i was thinking right now :)
<Begasus>
you need another option there, but you'll hit that next I think ;)
<Begasus>
I usually grep the source dir for "werror" and in configure the option popped up
_leosma has joined #haiku
<Begasus>
on the Haiku tools "PonpokoDiff and TexSearch" are my biggest friends :D
* Anarchos
time for a break
<Begasus>
ttyl
<Begasus>
biab
OscarL has joined #haiku
v_harkonnen has quit [Remote host closed the connection]
* OscarL
(puts on his zealot hat and shouts:) Repent, sinners! Cast away the fat evil of TeX, and follow the slim savior of Lout instead!
* Begasus
grabs some ducktape for a certain loud peep in the channnel
<OscarL>
"savior", up to the point you find out the naming convention hits author used for Lout's sources: https://github.com/william8000/lout
* OscarL
runs away from the heretic Begasus!
<Begasus>
Anarchos, go for 3.24.11 (it's the latest 3.* series mentioned at repology, and works too)
<Begasus>
my rath will hunt you! :P
<Begasus>
(hope I wrote that right)* :D
<OscarL>
I'm afraid to look up that one, Begasus :-)
<OscarL>
*wrath, IIRC.
<Begasus>
after last time I can imaging OscarL
<Begasus>
grabbing gtksourceview3-3.24.11-1-x86_64.hpkg and moving it to /Opslag/haikuports/packages/gtksourceview3-3.24.11-1-x86_64.hpkg
<OscarL>
aazam[m]: (as you got no reply, let me try): kits/interface/textview* is not "app_server" code, but part of the implementation of the GUI controls.
<Anarchos>
Begasus Warning: Command '['bash', '-c', '. /wrapper-script']' returned non-zero exit status 1.
<Begasus>
? what did you do? ;)
<Anarchos>
hp gtksourceview-3.24.0 :)
<Begasus>
that shouldn't be the error :P
<Begasus>
fwiw, I've put that Arch "fix" into PATCH()
<Begasus>
maybe you ran it twice and produces an error now
<OscarL>
aazam[m]: the one you linked earlier, it is part of the TextView control... used on the StyledEdit app, for example, and that uses different fonts, of course.
<Begasus>
TeXView?
<Anarchos>
Begasus not sure the tool i use will be happy with gtksourceview 3.24.11 isntead of 3.24.0 ...
<Begasus>
doesn't matter for the recipe, only change is the checksum
<Begasus>
but you can stick with the one you have (and check later once you got a build up and running for it)
<Begasus>
on that matter, having OCalm would be nice for RKWard and other also ? :)
<Begasus>
k, heading out for a bit, cu later
HaikuUser has joined #haiku
HaikuUser has quit []
_leosma has quit [Quit: Vision[]: i've been blurred!]
_leosma has joined #haiku
][655321][ has joined #haiku
][655321][ has quit []
MajorBiscuit has quit [Quit: WeeChat 4.2.1]
walkingdisaster has quit [Quit: Vision[]: i've been blurred!]
Oscar-L has joined #haiku
OscarL has quit [Ping timeout: 480 seconds]
Oscar-L is now known as OscarL
v_harkonnen has joined #haiku
OscarL has quit [Ping timeout: 480 seconds]
<_-Caleb-_>
Guys another question, can anyone comment the "language" files of pe? I want to insert markdown, gemtext and maybe yab to the highlights but i dont know how because im not a developer (some scripts and this is all)
rennj has joined #haiku
OscarL has joined #haiku
OscarL_ has joined #haiku
<OscarL_>
darn HexChat keeps disconnecting me :-/
nosycat has joined #haiku
<OscarL_>
_-Caleb-_: I've done sever of Pe's language extensions, mostly by ~stealing~ modifying what other languages did :-)
<OscarL_>
s/sever/several/
<Anarchos>
Begasus runConfigure --disable-Werror did'nt prevent this "-Werror=deprecated-declarations" to show up....
_-Caleb-_ has left #haiku [#haiku]
_-Caleb-_ has joined #haiku
<OscarL_>
_-Caleb-_: my suggestion would be: try to start with the most similar to the one you want to make, say... for yab... I would probably start by hacking up the Python_Language.cpp
OscarL has quit [Ping timeout: 480 seconds]
OscarL_ is now known as OscarL
<_-Caleb-_>
OscarL: Ok but idk nothing about c++ ... But i can try at least with gemtext, just #/##/###/*/=>/```/ >
<OscarL>
or Lua_Language.cpp
<_-Caleb-_>
Ok ok later today i Will try that then, thanks!!
<OscarL>
_-Caleb-_: I still can barely read C or C++, and I knew even less when I originally did my Pe's languages :-) (took a bit of trial and error, thou! :-D)
<nosycat>
Can you point me at one of those source files? I'm curious now.
<nosycat>
The code is clear, not so much what to change for another language.
<OscarL>
I remember that I even had a "skeleton" language because someone asked me about it at the time (they wanted to add ruby support). Wonder if I can find that archive...
<_-Caleb-_>
Ive done the highlight syntax for gemtext in nano time ago
<Begasus>
jmairboeck, all good on 32bit aside from Okular with Kile now :D
HaikuUser has joined #haiku
HaikuUser has quit []
<jmairboeck>
thanks Begasus
<Anarchos>
Begasus i just did autogen, not the NOCONFIGURE=1 . Is it mandatory ?
<Begasus>
otherwise it will run "configure" twice Anarchos
HaikuUser has joined #haiku
HaikuUser has quit []
<OscarL>
_leosma: re conda... unless someone is interested enough in porting it AND maintaining it... doubt you'll have any luck. We're have already enough work trying to keep up with regular Python and pip3 :-)
<Anarchos>
Begasus will try
<Begasus>
from a user point of view, pip3 is working fine I guess OscarL :)
<Begasus>
you probably need to disable nls also :)
<dovsienko>
jmairboeck: it is not impossible that the compromised tarball contains more than one surprise
<Begasus>
biab
mmu_man has joined #haiku
<jmairboeck>
dovsienko: you are right. I'll wait if I get a reply from korli and probably let him handle that though. (he did the recent upgrade of the package)
rennj has quit [Quit: Leaving]
gingi has quit [Quit: Vision[]: i've been blurred!]
hightower3 has quit []
hightower2 has joined #haiku
rennj has joined #haiku
zard has quit [Quit: leaving]
nosycat has quit [Quit: Leaving]
rennj has quit [Ping timeout: 480 seconds]
BrunoSpr has joined #haiku
<augiedoggie>
that hack specifically checks for x86_64 linux
<augiedoggie>
from the openwall list..
<augiedoggie>
These conditions include targeting only x86-64 linux:
<botifico>
[haikuports/haikuports] OscarL 9f161e1 - lout: update to version 3.43. (#10272)
<OscarL>
I was working on another recipe... used a template with that $HOMEPAGE on SOURCE_URI... and didn't liked it when I saw it on lout recipe this time around. I wasn't really expecting lout to ever get a new version, really :-) (so few people use it, or even know about it!)
<BrunoSpr>
hello all, hello Begasus... Roman asks in Telegram "Haiku"channel: "Is it possible to compile nvim on Haiku yet? I tried yesterday but no luck, it fails on libvterm linking or something like that. Maybe someone knows some trick to make it work? At least partially? Many thanks for any help with that!"
<OscarL>
BrunoSpr, as far as I know, many folks have tried porting neovim, but none successfully just yet.
<Begasus>
got stuck the other day also BrunoSpr, so no progress
<BrunoSpr>
ah ok thank you!
<BrunoSpr>
With the new ffmpeg, some software works better or now?
<BrunoSpr>
*not
<Begasus>
ffmpeg6 has been around for a while
<BrunoSpr>
Glaxnimate for example, cannot import videofiles in Haiku
<Begasus>
only internaly in the nightlies it's new I think
<BrunoSpr>
Yes I tried it you can do amazing Masks with it if it works
<BrunoSpr>
but I did not manage to get a video file in there
<BrunoSpr>
internaly?
<BrunoSpr>
I tried with haiku 64bit nightly
<Begasus>
ps BrunoSpr, Kile is available now too, so a new toy to play with tex files :)
<BrunoSpr>
oh that sounds good
<OscarL>
BrunoSpr: Begasus said internaly, because Haiku switched to ffmpeg6 (only on nightlies) a few days ago.
<BrunoSpr>
Maybe Glaxnimate can import video files in 32bit?
<Begasus>
can't announce it in the forum before someone else posts something there :)
<BrunoSpr>
I did not try yet!
<Begasus>
worked well with the examples you provided :)
<BrunoSpr>
OscarL, yes I know
<BrunoSpr>
But Glaxnimate is not compiled with ffmpeg it seems?
<Begasus>
it is: devel:libavcodec$secondaryArchSuffix >= 59
<BrunoSpr>
Begasus, great to hear, it was a lot of work to port it!
<BrunoSpr>
Hopefully students will use it
<BrunoSpr>
with ffmpeg 6?
<BrunoSpr>
or ffmpeg 4.2
<BrunoSpr>
So it should work
<Begasus>
seems ffmpeg5
Calisto has joined #haiku
<BrunoSpr>
Glaxnimate cannot see/sniff the video codecs it seems (avi, mpeg, mov, mpg4, wmv...
<BrunoSpr>
The sample video folder is always empty
<Begasus>
whoops, wouldn't even know how to check it :P
<botifico>
[haikuports/haikuports] jmairboeck 3644a3d - xz_utils: switch the SOURCE_URI to the Github generated archive
maylay has quit [Quit: Pipe Terminated]
<jmairboeck>
dovsienko: I switched the source for the xz_utils package to the Github archive, so we should be safe now (even more than before)
<dovsienko>
jmairboeck: adding github.com to the problem space does not make the problem space smaller, as far as I see it
<jmairboeck>
it was also hosted on Github before, I don't think that makes much difference
<dovsienko>
what gets in the way of downgrading the package to a version that is not compromised?
maylay has joined #haiku
<jmairboeck>
that could have been done too, given that SoftwareUpdater uses full-sync under the hood, so users installing updates via the GUI or use full-sync on the command line would get the downgraded version, but apparently just using a different source is sufficient. At least Arch Linux did the same.
<dovsienko>
how do you know?
<dovsienko>
and do Haiku packages have an equivalent of RPM epoch?
<jmairboeck>
no, I don't think so, we just have version and revision number
<dovsienko>
in that case it would take to apply a huge patch to make the source one of the old releases before the compromise, which is one or two years ago, as far as people mention on the interwebs
HaikuUser has joined #haiku
<jmairboeck>
other Linux which did downgrade also just downgraded to the last stable version 5.4.6 which was released in January this year
<dovsienko>
let's say there is a space for improvement in Haiku processes, and if you begin to address it now, it will not spiral out of control after R1
<dovsienko>
maybe it would be better for me to focus on my own homework for now
<botifico>
[haikuports/haikuports] jmairboeck e2f4699 - texlive_core: move reautoconf from PATCH to BUILD
<Anarchos>
is this line ok when building a recipe : grabbing gtksourceview-3.24.0-1-x86_64.hpkg and moving it to /boot/home/HAIKU/haikuports/packages/.obsolete/gtksourceview-3.24.0-1-x86_64.hpkg
<Anarchos>
i never say that .obsolete before
<jmairboeck>
older versions are moved to .obsolete automatically
<jmairboeck>
maybe you should rename your recipe to gtksourceview3 or something so that it can be installed side by side with the newer version
<jmairboeck>
normally, only the newest version is available for installation
OrangeBomb has quit [Quit: Slacking off]
<Anarchos>
jmairboeck my recipe is gtksourceview-3.24.0.recipe and the existing was gtksourceview-4.8.4.recipe
<Anarchos>
but i have a framework stuck with gtksourceview-3 so i did this recipe for it :)
<jmairboeck>
Anarchos: you should rename your recipe to gtksourceview3-3.24.0.recipe
<jmairboeck>
i.e. add a "3" to the package name before the version
jmairboeck has quit [Quit: Konversation terminated!]
OrangeBomb has joined #haiku
<Anarchos>
and same fort gtksourceview4 i guess ?
<augiedoggie>
no
<Anarchos>
augiedoggie oh ok so it just transforms into another version side by side, but not an obsolete one
<augiedoggie>
usually the current version is without the number and only added to the older recipes we keep for compatibility
<Anarchos>
augiedoggie ok
<Anarchos>
nice
<Anarchos>
i can't wait to see now if i can compile lablgtk3-sourceview3, the ocaml package used by coq, to be able to install the famous https://compcert.org/ on haiku !
<_-Caleb-__Haiku>
and mksquashfs folder/ filename.opk
<_-Caleb-__Haiku>
opk is the fileformat of Open Dingux (Rg350 family handheld consoles)
<OscarL>
alright... let me get tha on my 32 bits machine. Thanks.
<_-Caleb-__Haiku>
atm i have this message in Haiku
<_-Caleb-__Haiku>
Filesystem on FreeDoom_V_1.5.opk is (4:0), which is a later filesystem version than I support!
<_-Caleb-__Haiku>
thank you :-)
<_-Caleb-__Haiku>
in the opendingux case it's use the .opk (squashfs files) as the hpkg in haiku, read one by one in the boot and put in the menus... because the system is read-only fs :-)
<_-Caleb-__Haiku>
that's why i use squashfs, to package and/or edit opendingux packages :--)
<_-Caleb-__Haiku>
but also use sometimes to make backups, etc. :-)
<Anarchos>
Is there a command from Terminal to close all Tracker window ?
<OscarL>
IF download ends today... will be able to test :-D
<OscarL>
Anarchos: "shutdown -r" :-P
<_-Caleb-__Haiku>
jajajaj Anarchos maybe with a "hey" script?
<Anarchos>
OscarL i am connected on my server by ssh, but top shows a Tracker window eating cpu....
<Anarchos>
_-Caleb-__Haiku i thought to that but could not do it, my hey skill is rather low
<OscarL>
Anarchos: kill Tracker with kill? that should work :-P
<augiedoggie>
you could tell Tracker to quit, that would close all of the windows :P
<Anarchos>
OscarL isn't tracker automatically relaunched, as Deskbar .
<OscarL>
Anarchos: yes, but unless Tracker is seriously cursed.... it should stop that high CPU usage, I think.
<_-Caleb-__Haiku>
OscarL if you need i can send u the file in other way
<OscarL>
_-Caleb-__Haiku: got the file. Will test and report.
<_-Caleb-__Haiku>
oki thanks
<Anarchos>
OscarL i have this trouble too with 'recent document' when i click on a 'query' it can freezes the computer for minutes if the query returned thousands of files…
rennj has joined #haiku
<OscarL>
_-Caleb-__Haiku: you sure that file is valid?
<_-Caleb-__Haiku>
i am
<_-Caleb-__Haiku>
but idk if in the upload/download we lost some data
Anarchos has quit [Quit: time to sleep]
<OscarL>
FATAL ERROR: Can't find a valid SQUASHFS superblock on filename.opk
<augiedoggie>
too bad he left, i found the hey command
<OscarL>
_-Caleb-__Haiku: creating new files and unpacking seems to work, but the files I create start with "sqsh", the one you linked... start with "hsqs". Will need to find where an endianness swap might be missing.
<OscarL>
old version (4.3) doesn't seems to have any issue unpacking the one I've created with 4.6.1 at least.
<OscarL>
(other than the missing XATTR support)
<_-Caleb-__Haiku>
mmmmm ok ok
<OscarL>
Found possible source of problem. Need some coffee first :-)
<_-Caleb-__Haiku>
ahahaha ok ok
_leosma has joined #haiku
<_-Caleb-__Haiku>
well, if it's possible cool, if not, don't worry, anyway thanks for the effort !!!!
<_-Caleb-__Haiku>
:-)
_leosma has quit []
_leosma has joined #haiku
<OscarL>
_-Caleb-__Haiku: yup... seems I found the problem (seems the problem was already there on the previous version?)
<_-Caleb-__Haiku>
oh great!
<OscarL>
was able to unsquash both PicoDrive[...].opk as well at the first one you linked (the 33 MiB one from 0x0.st)
<OscarL>
"Manual del Pack FreeDoom" from manualES.txt :-)
<OscarL>
and the new version supports extended attributes. NOICE :-)